- In the switch statement in SpecialElectronPdf.php line 48 - the redirect case falls through to the default case. Well this doesn't overly matter since the page ends up a redirect, it could be a little confusing if someone was refactoring the code at a later date and didn't notice. I think the code would be more clear if that case also had a return.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Fix switch fall through | mediawiki/extensions/ElectronPdfService | master | +1 -0 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Addshore | T150185 Deploy ElectronPdfService Extension to production | |||
Resolved | Addshore | T149080 Security review for ElectronPdfService Extension | |||
Resolved | WMDE-Fisch | T149774 SpecialElectronPdf switch statement has misleading fall through to default |
Event Timeline
Comment Actions
Change 319285 had a related patch set uploaded (by WMDE-Fisch):
Fix switch fall through