Page MenuHomePhabricator
Create Task
Maniphest T151021

Section(?) edit links aren't re-set-up on save, so clicking on section link opens OWE and then switches to NWE on second edit without a refresh
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Go to Preferences and set Editing mode to "Always give me Source Editor"
  2. Now click on section link to open NWE
  3. Make some changes and save
  4. Click on section link again to open NWE

Observed Result:
Instead of opening NWE its opening OWE

Details

SubjectRepoBranchLines +/-
init.mw.DesktopArticleTarget: properly set up section linksmediawiki/extensions/VisualEditormaster+76 -75
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ryasmeen created this task.Nov 18 2016, 5:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2016, 5:22 AM
Jdforrester-WMF triaged this task as Medium priority.Nov 21 2016, 10:10 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF added a project: VisualEditor-MediaWiki-2017WikitextEditor.
Jdforrester-WMF mentioned this in T151258: Edit tab can perform wrong action in NWE + SET.Nov 21 2016, 10:14 PM
Jdforrester-WMF raised the priority of this task from Medium to High.Dec 13 2016, 11:25 PM

I can't replicate step 2 — now when "always source mode" I'm getting OWE not NWE.

Ryasmeen added a comment.EditedDec 14 2016, 10:47 PM

James, yeah I missed a step here, sorry. I enabled NWE mode from Preferences first. Then step2 will open NWE. But after I save some changes using NWE and click on section link again, it opens OWE instead of NWE.

Ryasmeen added a comment.Jan 23 2017, 9:12 PM

T153561 is probably the same bug?

Jdforrester-WMF renamed this task from Clicking on section link opens OWE instead of NWE when Editing mode is set to "Always Source Editor" to Clicking on section link opens OWE instead of NWE when Editing mode is set to "Always Source Editor" on second edit without a refresh.Feb 6 2017, 7:11 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a parent task: T142523: Provide a second version of a beta modern wikitext editor integrated into the visual editor.Feb 21 2017, 7:03 PM
Jdforrester-WMF merged a task: T153370: Section link opens NWE when the preference was set to "Always give me the visual editor".Feb 21 2017, 7:41 PM
Jdforrester-WMF renamed this task from Clicking on section link opens OWE instead of NWE when Editing mode is set to "Always Source Editor" on second edit without a refresh to Section edit links aren't re-set-up on save, so clicking on section link opens OWE and then switches to NWE on second edit without a refresh.Feb 21 2017, 7:43 PM
Jdforrester-WMF renamed this task from Section edit links aren't re-set-up on save, so clicking on section link opens OWE and then switches to NWE on second edit without a refresh to Section(?) edit links aren't re-set-up on save, so clicking on section link opens OWE and then switches to NWE on second edit without a refresh.Feb 21 2017, 8:12 PM
Jdforrester-WMF mentioned this in T153312: Beta wikitext editor do not open in some situations.
Jdforrester-WMF mentioned this in T153561: Sometimes old WikiText editor loads after user has switched to new WikiText editor.Feb 21 2017, 8:30 PM
• Elitre subscribed.Feb 28 2017, 11:19 AM
DLynch subscribed.Oct 16 2017, 5:03 PM

I fixed something related for T159374, so this bug is now better-fixed. Current state is that in "always source" mode, the section-edit link after saving will still open visual mode.

It does this for a conflux of reasons:

  1. replacePageContent assumes it just has to set up the visual half of the links, and so hardcodes 'visual'.
  2. The post-save HTML that's returned has the links coded for visual-mode, and we're not running the normal page-setup transforms on them.

So, fixing that.

gerritbot subscribed.Oct 16 2017, 5:03 PM

Change 384560 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] init.mw.DesktopArticleTarget: properly set up section links

https://gerrit.wikimedia.org/r/384560

gerritbot added a project: Patch-For-Review.Oct 16 2017, 5:03 PM
gerritbot added a comment.Oct 17 2017, 4:28 PM

Change 384560 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] init.mw.DesktopArticleTarget: properly set up section links

https://gerrit.wikimedia.org/r/384560

• Deskana closed this task as Resolved.Oct 17 2017, 4:47 PM
• Deskana assigned this task to DLynch.
• Deskana changed the point value for this task from 1 to 8.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 17 2017, 4:47 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)).Oct 17 2017, 5:00 PM
Ryasmeen added a project: Verified.Oct 17 2017, 6:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL