Description
Details
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Open | Goal | None | T98668 Convert all extensions and skins on gerrit to use extension registration | |
| In Progress | Universal_Omega | T152865 Convert SocialProfile to use extension registration | ||
| · · · |
Event Timeline
Change 329027 had a related patch set uploaded (by SamanthaNguyen):
[WIP] Convert to newer extension registration
Change 329027 abandoned by SamanthaNguyen:
[WIP] Convert to newer extension registration
Reason:
Will replace and write a new patch this week.
Change 336551 had a related patch set uploaded (by SamanthaNguyen):
Convert to newer extension registration
So splitting it in multiple extension.json files requires registrating each one (since each one can't be linked to the main extension.json (HT @Legoktm!) ); this task will have to be marked as stalled until it's decided whether or not we want to have multiple files or merge all of these extension registration files into one.
Per the notes on https://www.mediawiki.org/wiki/Version_lifecycle, MediaWiki 1.23's support will be ended in May 2017, which will be in 4ish months; then 1.27+ support will be forced. PHP entry points will still be supported just because there's so many, but we'll want to start considering this ticket and keeping it in mind since generally being up to date is usually good.
Change 336551 abandoned by SamanthaNguyen:
Convert to newer extension registration
Reason:
see I017e5c3779fc5cc33a84694a513442a3259accbd
Change 374060 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/extensions/SocialProfile@master] [DNM] Use and convert to newer extension registration
Change 381707 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/extensions/SocialProfile@master] Convert UserWelcome to use extension registration
Change 381707 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Convert UserWelcome to use extension registration
Change 374060 abandoned by SamanthaNguyen:
[DNM] Use and convert to newer extension registration
Reason:
This was like the big third attempt at this, but now this is finally getting some faster progress after the decision was made to split into smaller patches. All patches for helping this progress will be under https://gerrit.wikimedia.org/r/#/q/topic:convert-socialprofile-extreg
\o/
Change 381933 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/extensions/SocialProfile@master] Convert UserActivity to use extension registration
Change 381933 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Convert UserActivity to use extension registration
Change 392340 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/extensions/SocialProfile@master] Convert UserRelationship to use extension registration
Change 392361 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/extensions/SocialProfile@master] Convert SystemGifts to use extension registration
Change 392453 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/extensions/SocialProfile@master] Convert UserBoard to use extension registration
Change 392526 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/extensions/SocialProfile@master] Convert UserStats to use extension registration
Change 392693 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/extensions/SocialProfile@master] Convert UserGifts to use extension registration
Change 392726 had a related patch set uploaded (by SamanthaNguyen; owner: SamanthaNguyen):
[mediawiki/extensions/SocialProfile@master] [DNM] Convert UserProfile to use extension registration
Change 392361 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Convert SystemGifts to use extension registration
Change 392453 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Convert UserBoard to use extension registration
Change 392340 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Convert UserRelationship to use extension registration
Change 392526 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Convert UserStats to use extension registration
Change 392693 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Convert UserGifts to use extension registration
@SamanthaNguyen nice work so far! In the future I'd recommend just building a stack of patches (just make individual commits on top of each other), because you based all of the patches individually on master, they all conflicted with each other, and I had to manually rebase each of them to turn them into a stack.
Getting rid of stalled status since progress is happening :)
@Legoktm: Thanks for the advice and for rebasing them, I'll make sure to keep this in mind for the future :)
Change 392726 abandoned by SamanthaNguyen:
[DNM] Convert UserProfile to use extension registration
Reason:
Currently not working on any social tool extensions.
Change 571060 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/SocialProfile@master] Convert UserProfile to use extension registration
Change 571060 abandoned by Zoranzoki21:
Convert UserProfile to use extension registration
Reason:
According to the discussion on IRC, I forgot to abandon this...
Change 657651 had a related patch set uploaded (by Universal Omega; owner: Universal Omega):
[mediawiki/extensions/SocialProfile@master] [SocialProfile]: Convert to ExtensionRegistry
With my above patch it finished the conversion to ExtensionRegistry completely. Tested it and it works 100% with just one wfLoadExtension( 'SocialProfile' ); now. It is now ready for review.
Noting that if this is not done by the time MW 1.41 releases, then compatibly with scripts such as mergeMessageFileList.php will break as extension registration is now required.
You are more than welcome to participate in development and to assist in getting this issue fixed!
If memory serves me correctly (of course I didn't write this down on the patchset in gerrit...) the issue with the most recent patchset was that certain (most? all of them?) hooks were not getting registered properly; one obvious example of this would be all of the Echo-related preferences originating from SocialProfile (e.g. "notify me on leveling up" etc.) being absent from the relevant Special:Preferences tab. That's quite the showstopper bug, given that as per social tools' MW compatibility policy, compatibility is only guaranteed with the latest LTS release of MediaWiki (currently 1.39).
When your development resources are basically some paperclips, chewing gum and shoelaces, it's not possible just to throw money/developers/both at this or any other issue, in fact. (I'd love that, of course, but we hardly live in a perfect world...)
Basically, I hear you and I agree that this is an important thing, but judging by mw:Version lifecycle, we're about a year away from the next LTS release, which looks like it'd be 1.43 in November 2024. If this isn't fixed by then, then it's about time to panic and come up with some sort of disgusting hack if fixing this properly isn't something that works, but I'm hoping that before that, someone has the time and capabilities to fix up @Universal_Omega's patch. It seems like we're so very close with that patch, but still sadly too far away from being able to merge it.