Gerrit doesn't display committed images
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Niedzielski
	Dec 13 2016, 4:33 PM

Description

Gerrit used to display images in uploaded patches. This no longer seems to be the case:

https://gerrit.wikimedia.org/r/#/c/325819/5/app/screenshots-ref/org.wikipedia.descriptions.DescriptionEditViewTest.testFocus-480dp-en-ltr-font1.0x-dark-saving.png,unified

Related Objects
Search...

Status	Assigned	Task
Resolved	Paladox	T153085 Gerrit doesn't display committed images
Resolved	• demon	T156120 Update gerrit to 2.14.6
Open	None	T184086 Add prometheus exporter to Gerrit
Resolved	• demon	T184116 Setup gitiles for use with gerrit as a repo viewer

Event Timeline

• Niedzielski created this task.Dec 13 2016, 4:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2016, 4:33 PM

Hi see https://bugs.chromium.org/p/gerrit/issues/detail?id=3822 according to that the fix is released, but I haven't found a patch yet.

Paladox added a project: Upstream.Dec 13 2016, 5:38 PM

Aklapper added a project: Regression.Dec 13 2016, 7:42 PM

Actually it was reported for polygerrit, so I filled the report here https://bugs.chromium.org/p/gerrit/issues/detail?id=5197 for gwt and gerrit 2.13+

Paladox moved this task from Backlog to Reported Upstream on the Upstream board.Dec 23 2016, 2:59 PM

Polygerrit will be exposed in gerrit 2.14. You will be able to view images in diffs again in polygerrit :)

In T153085#3076300, @Paladox wrote:

Polygerrit will be exposed in gerrit 2.14. You will be able to view images in diffs again in polygerrit :)

That's not a solution since Polygerrit is still unusable.

Yes but upstream are not accepting any usability improvements for gwt, though you can submit a patch to see though.

In T153085#3076360, @Paladox wrote:

Yes but upstream are not accepting any usability improvements for gwt, though you can submit a patch to see though.

That's just stupid. Polygerrit isn't even finished, so upstream should absolutely fix this regression.

• Niedzielski mentioned this in T107588: EPIC: Detect and prevent UI regressions.May 17 2017, 5:28 PM

Paladox added a parent task: T156120: Update gerrit to 2.14.6.Jun 1 2017, 9:26 PM

In T153085#3076361, @demon wrote:

In T153085#3076360, @Paladox wrote:

Yes but upstream are not accepting any usability improvements for gwt, though you can submit a patch to see though.

That's just stupid. Polygerrit isn't even finished, so upstream should absolutely fix this regression.