Page MenuHomePhabricator
Create Task
Maniphest T153472

Can't open VisualEditor with &uselang=qqx
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Click https://en.wikipedia.org/w/index.php?title=User:Whatamidoing_(WMF)/sandbox&veaction=edit&uselang=qqx
  2. Did VisualEditor open for you?
  3. Me neither.
  4. Be sad.
  5. Pester someone to find out what that string's name is.

Details

SubjectRepoBranchLines +/-
MWSaveDialogAction: Don't break on strange accesskey messagesmediawiki/extensions/VisualEditormaster+8 -4
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Dec 16 2016, 4:47 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 16 2016, 4:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF added a project: VisualEditor-MediaWiki.Dec 16 2016, 4:50 PM
Jdforrester-WMF subscribed.

Need to add uselang/useskin to the whitelist of params we don't freak out about? (I could have sworn this used to work.)

Jdforrester-WMF triaged this task as Medium priority.Dec 16 2016, 4:50 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
• Elitre awarded a token.Dec 16 2016, 5:16 PM
• Whatamidoing-WMF added a comment.Dec 16 2016, 5:44 PM

It worked a week or two ago in visual mode, but I haven't tried it since enabling the Beta Feature for the 2017 wikitext editor.

• AlexMonk-WMF subscribed.Dec 17 2016, 1:47 AM
In T153472#2881530, @Jdforrester-WMF wrote:

Need to add uselang/useskin to the whitelist of params we don't freak out about?

I don't think we have one. We do have a list of parameters to freak out about, but uselang is not among them.

• AlexMonk-WMF added a comment.Dec 17 2016, 1:52 AM

This is in console:
Uncaught Error: Incomplete trigger
ve.ui.TriggerRegistry.register @ ve.ui.TriggerRegistry.js?c7b3f:59
(anonymous function) @ ve.ui.MWSaveDialogAction.js?81b5a:94
(anonymous function) @ ve.ui.MWSaveDialogAction.js?81b5a:103

• AlexMonk-WMF claimed this task.Dec 17 2016, 1:59 AM
gerritbot subscribed.Dec 17 2016, 2:02 AM

Change 327892 had a related patch set uploaded (by Alex Monk):
Don't break everything if we end up with strange accesskey messages

https://gerrit.wikimedia.org/r/327892

gerritbot added a project: Patch-For-Review.Dec 17 2016, 2:02 AM
matmarex renamed this task from Can't open VisualEditor with &uselang=xx to Can't open VisualEditor with &uselang=qqx.Jan 3 2017, 7:41 PM
matmarex merged a task: T154477: Running VisualEditor with ?uselang=qqx produces a JavaScript error: "Incomplete trigger".
matmarex added a subscriber: Amire80.
gerritbot added a comment.Jan 3 2017, 7:52 PM

Change 327892 merged by jenkins-bot:
MWSaveDialogAction: Don't break on strange accesskey messages

https://gerrit.wikimedia.org/r/327892

Jdforrester-WMF closed this task as Resolved.Jan 3 2017, 7:54 PM
Jdforrester-WMF edited projects, added MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)); removed Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
matmarex mentioned this in T193207: "?uselang=qqx" throws exceptions with VisualEditor.Dec 19 2018, 7:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL