See eg. https://commons.wikimedia.org/wiki/File:5-1-15-_White_House_Press_Briefing.webm
Added to Job queue [INVALID] ago
Started [INVALID] ago. comma
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| wfMessage: use Message::params() to handle all the message parameters | mediawiki/core | master | +40 -8 |
Related Objects
Related Objects
Event Timeline
Comment Actions
With a few evals on a vagrant instance, this seems quite related to T152603: Invalid parameter for message "api-help-permissions-granted-to"
Comment Actions
Apparently the patch for the above task fixed the usage of wfMessage( 'timedmedia-in-job-queue' )->params( Message::listParam( [ '1 second' ], 'comma' ) ), but not wfMessage( 'timedmedia-in-job-queue', Message::listParam( [ '1 second' ], 'comma' ) ), is this intended?
Comment Actions
@Anomie what's the standard way of how this is handled? Relevant code paths:
https://github.com/wikimedia/mediawiki-extensions-TimedMediaHandler/blob/963a02bbefb2cd41464db6c93f00034d3fa3fe80/TimedMediaHandler_body.php#L283
https://github.com/wikimedia/mediawiki-extensions-TimedMediaHandler/blob/36a496fce0ceff59e24565488a05e1d65952a9a9/TranscodeStatusTable.php#L237
Comment Actions
Change 328366 had a related patch set uploaded (by Zhuyifei1999):
wfMessage: use Message::params() to handle all the message parameters
Comment Actions
Looks like wfMessage() has the same bug as in T152603: Invalid parameter for message "api-help-permissions-granted-to".
The easiest fix would be to change wfMessage( $key, ... ) to be the same as ( new Message( $key ) )->params( ... ) instead of trying to duplicate the handling that ->params() already does in order to call new Message( $key, $params ).
Edit: Ha, you beat me to that realization.
Comment Actions
Change 328366 merged by jenkins-bot:
wfMessage: use Message::params() to handle all the message parameters
Comment Actions
This will be deployed to Wikimedia wikis the week of January 2nd, there are no deployments until then due to holidays. I don't think it's a major issue, so it can wait.