the "sortable" URL parameter is reversed in Special:MessageGroupStats
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Amire80
	Dec 30 2016, 7:05 AM

Description

It looks like the sortable pseudo-parameter in the Special:MessageGroupStats URL is set incorrectly when clicking a table header cell. When I click on "Completion" to sort from 100% to 0%, it shows it correctly, but it sets #sortable:3=asc, so when I open the same URL in another window, it sorts from 0% to 100%. I remember that it used to work correctly until recently, so it must be a regression (albeit not a disastrous one).

Details

	Subject	Repo	Branch	Lines +/-
	Fix "sortable" URL parameter in MessageGroupStats and LanguageStats	mediawiki/extensions/Translate	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMW878314d7db26: Follow-up Ia16e19985: Fix table sort arrow direction

Event Timeline

Amire80 created this task.Dec 30 2016, 7:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 30 2016, 7:05 AM

The sorting code url thing has been unchanged at least since 2013. So either it is not a regression or the regression is in MediaWiki core. Could be 878314d7db26bc8c75594d3fcb73b7c1d3abbd3f.

Looks easy to fix though.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 30 2016, 7:21 AM

Nemo_bis subscribed.Dec 30 2016, 7:23 AM

In T154311#2907015, @Nikerabbit wrote:

The sorting code url thing has been unchanged at least since 2013. So either it is not a regression

Yes, I noticed this with git blame, too.

MtDu claimed this task.Jan 17 2017, 10:44 PM

Nemo_bis triaged this task as Medium priority.Jan 18 2017, 6:17 AM

@MtDu are you still planning to work on this?

In T154311#3009606, @Nikerabbit wrote:

@MtDu are you still planning to work on this?

I am resetting the assignee of this task because there have been no signs of progress lately (please correct me if I'm wrong).
Resetting the assignee avoids the impression that somebody is already working on fixing this task and it also allows anybody else to potentially work towards fixing this task. Please claim this task again when you plan to fix this task (via 'Assign / Claim' in the 'Actions' dropdown menu) - it would be very welcome! :) Thanks!

Omidfi claimed this task.Sep 30 2017, 7:31 AM

Change 381521 had a related patch set uploaded (by Omidfi; owner: Omidfi):
[mediawiki/extensions/Translate@master] Fix "sortable" URL parameter is reversed in MessageGroupStats

https://gerrit.wikimedia.org/r/381521

gerritbot added a project: Patch-For-Review.Sep 30 2017, 7:35 AM

Change 381521 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix "sortable" URL parameter in MessageGroupStats and LanguageStats

https://gerrit.wikimedia.org/r/381521

Nikerabbit closed this task as Resolved.Oct 2 2017, 2:23 PM

Nikerabbit removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)).Oct 3 2017, 12:02 AM