Page MenuHomePhabricator
Create Task
Maniphest T154498

Remove remaining ContentHandler deprecated functions and hooks
Closed, ResolvedPublic
Actions

Description

So, extensions have all been cleaned up, there's just T147924 that needs addressing before removing the rest of the ContentHandler functions and hooks from core

A couple have mostly been removed, just need some followup documentation cleanup

Hooks:

  • ArticleAfterFetchContent (Still mentioned in hooks.txt, code removed, but not in RELEASE-NOTES or HISTORY)
  • ArticleInsertComplete
  • ArticleSave
  • ArticleSaveComplete
  • ArticleViewCustom (Still mentioned in hooks.txt)
  • EditFilterMerged
  • EditPageGetPreviewText
  • TitleIsCssOrJsPage
  • TitleIsWikitextPage

Functions:

  • Article::getContent()
  • Article::doEdit() / WikiPage::doEdit()
  • Revision::getText()

The rest of the hooks and function on T145728 should be marked as removed on the mediawiki.org Hook manual pages

Details

SubjectRepoBranchLines +/-
Removed deprecated function 'Article::getContent()'mediawiki/coremaster+1 -18
Added release notes for 'ContentHandler::runLegacyHooks' removalmediawiki/coremaster+1 -0
Removed deprecated ContentHandler hooks.mediawiki/coremaster+23 -182
Remove deprecated function Article::doEdit() and WikiPage::doEdit()mediawiki/coremaster+1 -127
Revision::getText() was removedmediawiki/coremaster+2 -63
Article::getContent() was removedmediawiki/coremaster+1 -18
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Jan 3 2017, 5:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 3 2017, 5:28 PM
Reedy added a subtask: T147924: Identify/Cleanup ContentHandler deprecated calls (and hook subscribers) in Wikitech specific extensions branches.Jan 3 2017, 5:29 PM
Reedy updated the task description. (Show Details)Jan 3 2017, 9:53 PM
Reedy updated the task description. (Show Details)
Reedy updated the task description. (Show Details)Jan 3 2017, 9:57 PM
SamanthaNguyen moved this task from Unsorted to Needs removal on the Technical-Debt board.Jan 3 2017, 10:01 PM
Aklapper added a comment.Jan 4 2017, 5:54 PM

For GCI this task needs clarification, actual pointers to docs (how to deprecate etc), clarified expectations (patches? wiki page edits? both?)...

Aklapper moved this task from Proposed tasks to Missing mentors on the Google-Code-In-2016 board.Jan 4 2017, 7:26 PM

According to Reedy hardblocked on T147924 hence moving on workboard

gerritbot subscribed.Jan 7 2017, 10:38 AM

Change 331118 had a related patch set uploaded (by Filip):
Removed deprecated function 'Article::getContent()'

https://gerrit.wikimedia.org/r/331118

gerritbot added a project: Patch-For-Review.Jan 7 2017, 10:39 AM
Filip closed subtask T147924: Identify/Cleanup ContentHandler deprecated calls (and hook subscribers) in Wikitech specific extensions branches as Resolved.Jan 10 2017, 7:13 PM
Filip mentioned this in T145728: Clean up ContentHandler deprecated functions and hooks.Jan 15 2017, 11:07 AM
Filip claimed this task.Jan 15 2017, 1:21 PM
Filip added a subscriber: MtDu.

@MtDu: WIll clean up functions, I'll do hooks

daniel added a project: User-Daniel.Jan 15 2017, 5:36 PM
gerritbot added a comment.Jan 15 2017, 6:50 PM

Change 332150 had a related patch set uploaded (by Filip):
Removed deprecated ContentHandler hooks.

https://gerrit.wikimedia.org/r/332150

Filip removed Filip as the assignee of this task.Jan 15 2017, 9:08 PM
Filip subscribed.

@Reedy - I tought we removed all of these usages in these MW tasks. Can you join IRC?

Filip claimed this task.Jan 15 2017, 9:08 PM
Reedy mentioned this in T154672: ArticleAfterFetchContent and ArticleAfterFetchContentObject hooks... one is deprecated... the other's not..Jan 16 2017, 11:02 PM
Reedy added a parent task: T154672: ArticleAfterFetchContent and ArticleAfterFetchContentObject hooks... one is deprecated... the other's not..
Reedy added a comment.Jan 16 2017, 11:08 PM
In T154498#2941747, @FilipGCI wrote:

@Reedy - I tought we removed all of these usages in these MW tasks. Can you join IRC?

We probably did. I'm not 100% sure, as my clones on my laptop aren't upto date. AFAIK, when we did the old branches, that was all that was left?

Reedy removed a project: Google-Code-In-2016.Jan 16 2017, 11:09 PM
Filip added a comment.Jan 18 2017, 9:21 PM

@MtDu: Patch got merged - Can you take care of remaining functions?

gerritbot added a comment.Jan 18 2017, 9:31 PM

Change 332150 merged by jenkins-bot:
Removed deprecated ContentHandler hooks.

https://gerrit.wikimedia.org/r/332150

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release-notes.Jan 18 2017, 10:00 PM
gerritbot added a comment.Jan 18 2017, 10:18 PM

Change 329336 had a related patch set uploaded (by Reedy):
Remove deprecated function Article::doEdit()

https://gerrit.wikimedia.org/r/329336

MtDu updated the task description. (Show Details)Jan 18 2017, 11:16 PM

@FilipGCI @Reedy
I just updated documentation for all the hooks.
@Reedy
Could you check on the other functions and give the final axe? Does any documentation need to be updated there?

gerritbot added a comment.Jan 19 2017, 1:49 AM

Change 332931 had a related patch set uploaded (by Reedy):
Article::getContent() was removed

https://gerrit.wikimedia.org/r/332931

gerritbot added a comment.Jan 19 2017, 1:58 AM

Change 332933 had a related patch set uploaded (by Reedy):
Revision::getText() was removed

https://gerrit.wikimedia.org/r/332933

gerritbot added a comment.Jan 19 2017, 2:30 AM

Change 332931 merged by jenkins-bot:
Article::getContent() was removed

https://gerrit.wikimedia.org/r/332931

gerritbot added a comment.Jan 19 2017, 2:31 AM

Change 332933 merged by jenkins-bot:
Revision::getText() was removed

https://gerrit.wikimedia.org/r/332933

Reedy updated the task description. (Show Details)Jan 19 2017, 2:40 AM
Jdforrester-WMF removed a project: Patch-For-Review.Jan 19 2017, 3:13 AM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF subscribed.

Is this now Resolved?

gerritbot added a comment.Jan 19 2017, 3:14 AM

Change 329336 merged by jenkins-bot:
Remove deprecated function Article::doEdit() and WikiPage::doEdit()

https://gerrit.wikimedia.org/r/329336

Reedy closed this task as Resolved.Jan 19 2017, 3:17 AM
Jdforrester-WMF added a comment.Jan 19 2017, 3:18 AM

Excellent work!

Filip added a comment.Jan 19 2017, 10:56 AM

@Reedy: @MtDu: Thanks!

gerritbot added a comment.Jan 20 2017, 7:52 PM

Change 333292 had a related patch set uploaded (by Filip):
Added release notes for 'ContentHandler::runLegacyHooks'.

https://gerrit.wikimedia.org/r/333292

gerritbot added a project: Patch-For-Review.Jan 20 2017, 7:52 PM
gerritbot added a comment.Jan 20 2017, 8:13 PM

Change 333292 merged by jenkins-bot:
Added release notes for 'ContentHandler::runLegacyHooks' removal

https://gerrit.wikimedia.org/r/333292

gerritbot added a comment.Feb 8 2017, 2:44 AM

Change 331118 abandoned by Reedy:
Removed deprecated function 'Article::getContent()'

https://gerrit.wikimedia.org/r/331118

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL