wbsearchentities should match foreign entity IDs.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	daniel
	Feb 9 2017, 2:22 PM

Description

wbsearchentities currently has special handling for the case where the search term is an entity ID, and the respective entity exists. This code can be found in EntitySearchHelper::getExactMatchForEntityId(). It currently relies on EntityTitleLookup and Title::exists, which will fail for foreign IDs. It should be changed to use EntityLookup::hasEntity, which will work for foreign IDs.

Details

	Subject	Repo	Branch	Lines +/-
	EntitySearchHelper can find entities in foreign repositories	mediawiki/extensions/Wikibase	master	+136 -77

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open		None	T109579 [Epic] Give more sister projects access to Wikidata
Open		None	T187900 There is no way to reference a specific quote on Wikiquote
Stalled		None	T71753 [Story] Wikibase / Wikidata support on Wikiquote
Resolved		Lydia_Pintscher	T146637 Wikidata 2016 Q4 goals
Resolved		Lydia_Pintscher	T150179 Wikidata 2017 Q1 goals
Resolved		Lydia_Pintscher	T76007 [Epic] add ability to link/refer to foreign items and properties (federation)
Resolved		WMDE-leszek	T153793 DispatchingServiceFactory must provide a (Dispatching)TermSearchInteractor
Resolved		• Aleksey_WMDE	T157687 wbsearchentities should match foreign entity IDs.

Event Timeline

daniel created this task.Feb 9 2017, 2:22 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptFeb 9 2017, 2:22 PM

WMDE-leszek merged a task: T157667: wbsearchentity should allow searching for foreign entities using ID.Feb 10 2017, 8:51 AM

WMDE-leszek added subscribers: hoo, Lydia_Pintscher.

• Aleksey_WMDE updated the task description. (Show Details)Feb 10 2017, 11:51 AM

• Aleksey_WMDE renamed this task from wbentitysearch should match foreign entity IDs. to wbsearchentities should match foreign entity IDs..Feb 10 2017, 12:44 PM

Change 337013 had a related patch set uploaded (by Aleksey Bekh-Ivanov (WMDE)):
EntitySearchHelper can find entities in foreign repositories

https://gerrit.wikimedia.org/r/337013

gerritbot added a project: Patch-For-Review.Feb 10 2017, 2:08 PM

WMDE-leszek reassigned this task from WMDE-leszek to • Aleksey_WMDE.Feb 10 2017, 2:11 PM

WMDE-leszek moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.Feb 13 2017, 10:23 AM

Change 337013 merged by jenkins-bot:
EntitySearchHelper can find entities in foreign repositories

https://gerrit.wikimedia.org/r/337013

WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Feb 14 2017, 7:58 AM

WMDE-leszek closed this task as Resolved.Feb 15 2017, 10:43 AM