Page MenuHomePhabricator
Create Task
Maniphest T161010

Implement NOJS SpecialPage based on mock
Closed, ResolvedPublic
Actions

Assigned To
Addshore
Authored By
Addshore
Mar 21 2017, 5:57 PM
Tags
Referenced Files
F6882044: pasted_file
Mar 23 2017, 11:36 AM
F6880275: pasted_file
Mar 23 2017, 9:43 AM
F6880207: pasted_file
Mar 23 2017, 9:35 AM
F6866722: pasted_file
Mar 22 2017, 8:32 PM
F6861348: pasted_file
Mar 22 2017, 6:13 PM
Subscribers
Addshore
Aklapper
Andrew-WMDE
Bmueller
Fastily
gerritbot
Jan_Dittrich
View All 10 Subscribers

Description

Create a NOJS version of the special page based on the mock in T156795.

This should allow editing of the latest version of the content as well as the title without using JS.

Details

SubjectRepoBranchLines +/-
Add edit buttons to headers on special pagemediawiki/extensions/FileImportermaster+37 -4
Add parsed page text to special pagemediawiki/extensions/FileImportermaster+138 -14
Add an edit summary box to the import pagemediawiki/extensions/FileImportermaster+38 -4
Style special page to look like mockmediawiki/extensions/FileImportermaster+266 -163
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Mar 21 2017, 5:57 PM
gerritbot added a comment.Mar 22 2017, 6:12 PM

Change 344177 had a related patch set uploaded (by Addshore):
[mediawiki/extensions/FileImporter@master] Style special page to look like mock

https://gerrit.wikimedia.org/r/344177

gerritbot added a project: Patch-For-Review.Mar 22 2017, 6:12 PM
Addshore added a comment.Mar 22 2017, 6:13 PM

Current version of the page (as in PS1) looks as follows:

pasted_file (833×1 px, 390 KB)

Addshore claimed this task.Mar 22 2017, 6:13 PM
Addshore added a project: User-Addshore.
Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.
Addshore moved this task from Proposed to Sprint ready on the WMDE-TechWish board.
gerritbot added a comment.Mar 22 2017, 8:31 PM

Change 344203 had a related patch set uploaded (by Addshore):
[mediawiki/extensions/FileImporter@master] Add an edit summary box to the import page

https://gerrit.wikimedia.org/r/344203

Addshore added a comment.Mar 22 2017, 8:32 PM

With the edit summary box in change 344203:

pasted_file (955×1 px, 300 KB)

gerritbot added a comment.Mar 23 2017, 9:34 AM

Change 344330 had a related patch set uploaded (by Addshore):
[mediawiki/extensions/FileImporter@master] Add parsed page text to special page

https://gerrit.wikimedia.org/r/344330

Addshore added a comment.Mar 23 2017, 9:35 AM

With the parsed text a current screenshot can be seen below:

pasted_file (936×1 px, 218 KB)

gerritbot added a comment.Mar 23 2017, 9:43 AM

Change 344215 had a related patch set uploaded (by Addshore):
[mediawiki/extensions/FileImporter@master] Add edit buttons to headers on special page

https://gerrit.wikimedia.org/r/344215

Addshore added a comment.Mar 23 2017, 9:43 AM

With edit buttons:

pasted_file (939×751 px, 201 KB)

Addshore moved this task from Back Burner 🏛️ to Active 🚁 on the User-Addshore board.Mar 23 2017, 9:44 AM
Addshore moved this task from Sprint ready to Currently in sprint on the WMDE-TechWish board.
Jan_Dittrich added a comment.Mar 23 2017, 11:33 AM

Thanks for sharing the mocks. As far as I am concerned the styleguide’s (and my) suggestion is only having one of the white-text-on-color buttons on one page. So the edit buttons should be the inverted blue-on-white form (here as "ButtonWidget (progressive)‎"

Addshore added a comment.Mar 23 2017, 11:36 AM
In T161010#3124649, @Jan_Dittrich wrote:

Thanks for sharing the mocks. As far as I am concerned the styleguide’s (and my) suggestion is only having one of the white-text-on-color buttons on one page. So the edit buttons should be the inverted blue-on-white form (here as "ButtonWidget (progressive)‎"

Altered in PS4 of https://gerrit.wikimedia.org/r/344215

pasted_file (408×1 px, 129 KB)

gerritbot added a comment.Apr 5 2017, 12:12 PM

Change 344177 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Style special page to look like mock

https://gerrit.wikimedia.org/r/344177

gerritbot added a comment.Apr 5 2017, 12:14 PM

Change 344203 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add an edit summary box to the import page

https://gerrit.wikimedia.org/r/344203

Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.Apr 5 2017, 12:28 PM
Addshore moved this task from Currently in sprint to Done on the WMDE-TechWish board.
gerritbot added a comment.Apr 5 2017, 12:50 PM

Change 344330 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add parsed page text to special page

https://gerrit.wikimedia.org/r/344330

gerritbot added a comment.Apr 5 2017, 2:18 PM

Change 344215 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Add edit buttons to headers on special page

https://gerrit.wikimedia.org/r/344215

Lea_WMDE moved this task from Incoming to Move files to Commons on the TCB-Team (now WMDE-TechWish) board.Apr 7 2017, 5:23 PM
Addshore moved this task from Done to Demoed on the WMDE-TechWish board.May 9 2017, 2:59 PM
Tobi_WMDE_SW closed this task as Resolved.May 9 2017, 3:02 PM
Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 12:00 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL