Page MenuHomePhabricator

More pixel pushing on footer
Closed, ResolvedPublic

Event Timeline

Mhurd renamed this task from Pixel pushing on footer to More pixel pushing on footer.Apr 29 2017, 1:21 AM
This comment was removed by cmadeo.

@Mhurd This looks good although I noticed a tiny bit of strange behavior that isn't a big deal but might be of interest.

Tap on the TOC in an article, jump down to the 'read more' section
Scroll up
Scroll down to the bottom of the page again

You'll notice that there is slightly less padding below the legal text than there was on initial load after using the TOC link.

Testing criteria

  • Load an article such as "enwiki > Lake Superior"
  • Scroll to bottom of article
  • Should see "About this article" menu, "Read more" and a Wikipedia footer at the very bottom
  • Ensure tapping things does what it should (i.e. selecting article from read more should load that article, if you save such an article the read more save button should reflect this, menu item taps should load their respective interfaces)

Animation of testing steps can be found here.

ABorbaWMF subscribed.

Tested on iPhone 7+ with iOS 10.3.2, iPhone 5s with iOS 10.2, and iPad Mini 2 Retina on 10.2.1 on App version 5.5.0 (1142)

All looks good.