The latest vagrant upgrade also included this change which breaks certain assumptions we had made. More information about the change can be found in T37247.
Most of this will likely be fixed by not storing the utterances in the html but for the no-js fallback we need to ensure things still work.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add variable for content wrapper element | mediawiki/extensions/Wikispeech | master | +50 -36 |
The content from the ParseAfterTidy hook is today assumed to be equivalent to mw-content-text. Need to investigate at what point mw-parser-output (which contains mw-content-text) is added. Ideally the solution should be able to deal with both the case where the new div is present and when it isn't.
A seemingly simple solution would be to change the selector when evaluating the XPath expression. This could be broken out as a config variable and hopefully won't change that often.
Change 358587 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Add variable for content wrapper element
Change 358587 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Add variable for content wrapper element
Mentioned in SAL (#wikimedia-cloud) [2017-06-16T13:53:18Z] <Sebastian-WMSE> Deploy latest from Git master: a58b224 (T164822)