Fix alignment constraint check notification headline and close button
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jan_Dittrich
	May 9 2017, 12:39 PM

Description

Currently headline and close button look like

It should look like

Details

	Subject	Repo	Branch	Lines +/-
	Add margin to popup close button	mediawiki/extensions/WikibaseQualityConstraints	master	+1 -0
	Remove padding and margin from top of heading	mediawiki/extensions/WikibaseQualityConstraints	master	+5 -1

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Jan_Dittrich	T164352 UI Design for Constraint Checks/Violations
Resolved	Lucas_Werkmeister_WMDE	T164829 Fix alignment constraint check notification headline and close button
		· · ·

Event Timeline

Jan_Dittrich created this task.May 9 2017, 12:39 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMay 9 2017, 12:39 PM

Lucas_Werkmeister_WMDE renamed this task from Fix Alignment Chonstraing check notification headline and close button to Fix alignment constraint check notification headline and close button .May 9 2017, 12:44 PM

I’m not sure exactly what you mean. I can remove the padding-top and margin-top from the “Potential issues” headline (but not the “single value” headline, right?), but what’s wrong with the close button?

Lucas_Werkmeister_WMDE claimed this task.May 9 2017, 2:10 PM

Lucas_Werkmeister_WMDE added a subscriber: LucasWerkmeister.

Lucas_Werkmeister_WMDE removed a subscriber: LucasWerkmeister.

I suppose this shows it better:

before

maybe after

Is this better? I’ve removed the padding+margin from the h4 itself, the rest is OO.ui margin on the popup label.

Change 352857 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove padding and margin from top of heading

https://gerrit.wikimedia.org/r/352857

gerritbot added a project: Patch-For-Review.May 9 2017, 3:57 PM

Change 353017 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add margin to popup close button

https://gerrit.wikimedia.org/r/353017

Screenshot with change 353017:

Change 352857 abandoned by Lucas Werkmeister (WMDE):
Remove padding and margin from top of heading

Reason:
Superseded by I08e1fe23473d5a0966f542031664dd7424f9bb1c.

https://gerrit.wikimedia.org/r/352857

Change 353017 abandoned by Lucas Werkmeister (WMDE):
Add margin to popup close button