[betalabs-regression] Highlighting is not preserved for saved filters
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	May 15 2017, 10:42 PM

Description

In betalabs, on RC page select filters and add some highlighting to them. e.g. Page edits (red) and Registered (orange)

https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?damaging=&goodfaith=&hideliu=0&hideanons=1&userExpLevel=&hidemyself=0&hidebyothers=0&hidebots=0&hidehumans=0&hideminor=0&hidemajor=0&hidelastrevision=0&hidepreviousrevisions=0&hidepageedits=0&hidenewpages=1&hidecategorization=1&hideWikibase=1&hidelog=1&watchlist=&highlight=1&damaging__likelygood_color&damaging__maybebad_color&damaging__likelybad_color&damaging__verylikelybad_color&goodfaith__likelygood_color&goodfaith__maybebad_color&goodfaith__likelybad_color&goodfaith__verylikelybad_color&registration__hideliu_color=c4&registration__hideanons_color&userExpLevel__newcomer_color&userExpLevel__learner_color&userExpLevel__experienced_color&authorship__hidemyself_color&authorship__hidebyothers_color&automated__hidebots_color&automated__hidehumans_color&significance__hideminor_color&significance__hidemajor_color&lastRevision__hidelastrevision_color&lastRevision__hidepreviousrevisions_color&changeType__hidepageedits_color=c5&changeType__hidenewpages_color&changeType__hidecategorization_color&changeType__hideWikibase_color&changeType__hidelog_color&watchlist__watched_color&watchlist__watchednew_color&watchlist__notwatched_color

Save the filter. Re-load the page - the filters are correctly preserved (the url will be as above).

Load the saved filter from 'Quick links' - the highlighting is gone. The url

https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges?damaging=&goodfaith=&hideliu=0&hideanons=1&userExpLevel=&hidemyself=0&hidebyothers=0&hidebots=0&hidehumans=0&hideminor=0&hidemajor=0&hidelastrevision=0&hidepreviousrevisions=0&hidepageedits=0&hidenewpages=1&hidecategorization=1&hideWikibase=1&hidelog=1&watchlist=&highlight&damaging__likelygood_color&damaging__maybebad_color&damaging__likelybad_color&damaging__verylikelybad_color&goodfaith__likelygood_color&goodfaith__maybebad_color&goodfaith__likelybad_color&goodfaith__verylikelybad_color&registration__hideliu_color=c4&registration__hideanons_color&userExpLevel__newcomer_color&userExpLevel__learner_color&userExpLevel__experienced_color&authorship__hidemyself_color&authorship__hidebyothers_color&automated__hidebots_color&automated__hidehumans_color&significance__hideminor_color&significance__hidemajor_color&lastRevision__hidelastrevision_color&lastRevision__hidepreviousrevisions_color&changeType__hidepageedits_color=c5&changeType__hidenewpages_color&changeType__hidecategorization_color&changeType__hideWikibase_color&changeType__hidelog_color&watchlist__watched_color&watchlist__watchednew_color&watchlist__notwatched_color

With the above query displayed, click (just click) on 'Highlight results' button. The correct highlighting will be back.

The same happens when after saving a filter, a user navigates away from the page and then return and load the saved filters - the highlighting is not preserved.

Details

	Subject	Repo	Branch	Lines +/-
	RCFilters UI: Actually backwards-compat instead of overriding false	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Mooeypoo	T164128 Allow users to save their filter selections for later reuse
Resolved	Mooeypoo	T165437 [betalabs-regression] Highlighting is not preserved for saved filters
		· · ·

Event Timeline

Etonkovidova created this task.May 15 2017, 10:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2017, 10:42 PM

Etonkovidova added a parent task: T164128: Allow users to save their filter selections for later reuse.May 17 2017, 12:14 AM

Etonkovidova mentioned this in T164128: Allow users to save their filter selections for later reuse.

There was a typo in the code that was supposed to preserve settings from older entries. Oy.

QA -- Please note that this won't fix already-saved queries, it will only work on new ones.

Change 354077 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters UI: Actually backwards-compat instead of overriding false

https://gerrit.wikimedia.org/r/354077

gerritbot added a project: Patch-For-Review.May 17 2017, 12:39 AM

Mooeypoo claimed this task.May 17 2017, 12:39 AM

Mooeypoo moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.

Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 17 2017, 8:56 AM

Change 354077 merged by jenkins-bot:
[mediawiki/core@master] RCFilters UI: Actually backwards-compat instead of overriding false

https://gerrit.wikimedia.org/r/354077

ReleaseTaggerBot added a project: MW-1.30-release-notes.May 17 2017, 10:00 AM