Page MenuHomePhabricator
Create Task
Maniphest T166436

GlobalUserrights is in multiple states of broken
Closed, ResolvedPublic
Actions

Description

This extension is incompatible with 1.29+, and is in several states of broken.

Problems

  • Several function declarations are no longer compatible
  • Special:GlobalUserRights throws errors left and right about undefined indices. This has to do with Special:GlobalUserRights failing to show the user rights because the internals of Special:Userrights have been changed
  • Special:GlobalUserRights is incompatible with expiring group membership
  • The SQL declaration of global_user_groups.sql is not compatible with SQLite

Details

SubjectRepoBranchLines +/-
Major rewrite of GlobalUserrights to unbreak it for 1.29mediawiki/extensions/GlobalUserrightsmaster+827 -253
Fix the viewing of global user rightsmediawiki/extensions/GlobalUserrightsmaster+52 -24
Fix the incompatible function declarationsmediawiki/extensions/GlobalUserrightsmaster+17 -7
Customize query in gerrit

Event Timeline

Mainframe98 created this task.May 27 2017, 4:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2017, 4:32 PM
gerritbot subscribed.May 27 2017, 4:37 PM

Change 355880 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/extensions/GlobalUserrights@master] Fix the incompatible function declarations

https://gerrit.wikimedia.org/r/355880

gerritbot added a project: Patch-For-Review.May 27 2017, 4:37 PM
Mainframe98 updated the task description. (Show Details)May 27 2017, 4:56 PM
gerritbot added a comment.May 27 2017, 6:39 PM

Change 355884 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/extensions/GlobalUserrights@master] Fix the viewing of global user rights

https://gerrit.wikimedia.org/r/355884

gerritbot added a comment.May 28 2017, 8:27 AM

Change 355880 abandoned by Mainframe98:
Fix the incompatible function declarations

Reason:
Moving to a single rewrite patch

https://gerrit.wikimedia.org/r/355880

gerritbot added a comment.May 28 2017, 8:27 AM

Change 355884 abandoned by Mainframe98:
Fix the viewing of global user rights

Reason:
Moving to a single rewrite patch

https://gerrit.wikimedia.org/r/355884

Mainframe98 updated the task description. (Show Details)May 28 2017, 8:29 AM
Mainframe98 updated the task description. (Show Details)May 28 2017, 9:31 AM
gerritbot added a comment.May 28 2017, 6:24 PM

Change 355906 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/extensions/GlobalUserrights@master] Major rewrite of GlobalUserrights to unbreak it for 1.29

https://gerrit.wikimedia.org/r/355906

gerritbot added a comment.Jul 15 2017, 11:33 AM

Change 355906 merged by jenkins-bot:
[mediawiki/extensions/GlobalUserrights@master] Major rewrite of GlobalUserrights to unbreak it for 1.29

https://gerrit.wikimedia.org/r/355906

Mainframe98 updated the task description. (Show Details)Jul 15 2017, 11:33 AM
Mainframe98 closed this task as Resolved.Jul 15 2017, 11:52 AM
Mainframe98 triaged this task as Medium priority.
Mainframe98 added a subscriber: ashley.
Peachey88 edited projects, added MediaWiki-extensions-GlobalUserrights; removed MediaWiki-extensions-Other.Fri, Apr 26, 10:37 PM
Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 11:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL