[EPIC] Talk about and improve our frontend code architecture
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 2 2017, 8:36 PM

Description

We haven't reviewed our frontend code architecture in a long time. There are many pending conversations to be had and there is not much clarity about how things are organised. Let's talk about this, uncover the issues and improve things.

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Jdlrobson	T162936 Improve developer happiness in reading web maintained extensions
Open		None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Resolved		Jdlrobson	T127268 Dismantle ResourceLoader's "targets" system
Resolved		Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved		Jdlrobson	T195478 [EPIC] Speed up unit test execution and increase code coverage
Resolved		Jdlrobson	T195482 [EPIC] Review and refactor MobileFrontend components used by Minerva
Resolved		Jdlrobson	T166905 [EPIC] Talk about and improve our frontend code architecture
Declined		None	T130551 Refactor mobile references code
Duplicate		Jdlrobson	T133015 Extract ReferencesController class from mobile.references/references.js
Resolved		Jdlrobson	T138764 Spike: Do a code review session on Skin.js
Resolved		Jdlrobson	T156186 MFA: MobileFrontend should not have a global event emitter
Duplicate		None	T104008 Have a consistent way of doing Views within Views
Resolved		pmiazga	T94086 [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates
Resolved		Jdlrobson	T97188 Mustache templates in core do not support partials (client side)
Declined		None	T143847 Spike [4hrs]: Identify problematic Hogan templates when run as Mustache
Resolved		Jdlrobson	T149909 [EPIC] Proposal: abandon use of template partials in MobileFrontend for components within components e.g. Button, Icon and Anchor classes
Resolved		Jdlrobson	T139798 It should be easier to create new overlays
Declined		None	T209647 MFA: Allow our View's to support easy adding of children
Resolved		• Niedzielski	T202746 Enable babel transpiling in MobileFrontend
Duplicate		Reedy	T205129 Upgrade Hogan.js
Resolved		• Niedzielski	T205128 Bundle Hogan.js
Resolved		Jdlrobson	T219838 Inline Hogan templates in mobile.startup
Resolved		Jdlrobson	T219839 Bump mediawiki core Mustache version from 1.0.0 to 3.0.1
Duplicate		None	T219845 Swap Hogan for Mustache
Resolved		pmiazga	T219846 Remove "mediawiki.template.muhogan" from RelatedArticles
Resolved		ovasileva	T220159 Inline templates for mobile editor
Resolved		ovasileva	T220619 Inline remaining templates
Resolved		ovasileva	T220620 Switch Hogan for Mustache
Resolved		Jdlrobson	T167699 [EPIC] Enable JS error reporting in the mobile website
Resolved		Jdlrobson	T203814 Turn on MinervaErrorLogSamplingRate (Schema:WebClientError)
Resolved		None	T203815 [Bug] Beta cluster events not logged
Resolved		• nray	T205582 It should be possible to count errors via statsv in production
Resolved		Jdlrobson	T206702 Enable client side error counting on Minerva production (wikipedia only)
Declined		None	T144402 Extract MobileFrontend UI components to an external well documented library
Resolved		Jdlrobson	T144936 [Spike 2hrs]: Thoughts around librarizing MobileFrontend UI components?
Resolved		phuedx	T155799 mobile.pagelist JS code should be part of mobile.startup
Resolved		Jdlrobson	T155801 Merge mobile.toast into mobile.startup
Resolved		Jdlrobson	T155802 [EPIC] Build entire mobile.startup module using webpack bundler
Duplicate	Spike	None	T156188 [Spike] Evaluate whether JavaScript RL modules without side effects loaded on startup should be bundled into a single resource
Resolved		Jdrewniak	T153473 [Spike, 8hrs] How do we organize and manage our ResourceLoader modules?
Declined		None	T167713 [EPIC] MinervaNeue's starter modules should be grouped by page not feature
Resolved		Jdlrobson	T173454 Lazy loading code should be skin agnostic
Declined		None	T190699 Repackage Minerva's JavaScript code with webpack
Resolved		• Jhernandez	T156333 Technical: Use bundler to generate Popups JavaScript code
Resolved		Jdrewniak	T199452 Introduce webpack config/node-qunit and port ModuleLoader
Resolved		pmiazga	T202742 [subtask] Add bundlesize tests
Resolved		Jdrewniak	T203100 Continue webpack + test transition of mobile.startup
Resolved		Jdlrobson	T202026 Report client-side JavaScript errors in MobileFrontend practically
Resolved		Jdrewniak	T206169 Complete webpack migration of mobile.startup
Declined		None	T140205 Remove all id CSS selectors in MobileFrontend
Declined		None	T172454 mw.template, mw.user and mw.msg should be wrapped by local methods in View.js
Duplicate		None	T172455 mobile.startup/user should be passed in as a parameter to all our View code
Duplicate	Spike	None	T160128 MFA: Spike [8hr] Review CSS code conventions and improve to minimise chance of UI regressions
Declined		None	T173534 MFA: Add TopicTitleList component
Resolved		• Jhernandez	T173539 Abandon use of globals in MobileFrontend classes

Event Timeline

Jdlrobson created this task.Jun 2 2017, 8:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 2 2017, 8:36 PM

Jdlrobson renamed this task from [EPIC] Talk about and improve our frontend code to [EPIC] Talk about and improve our frontend code architecture.Jun 2 2017, 8:36 PM

Jdlrobson added subtasks: T130551: Refactor mobile references code, T138764: Spike: Do a code review session on Skin.js, T153473: [Spike, 8hrs] How do we organize and manage our ResourceLoader modules?.

Jdlrobson updated the task description. (Show Details)Jun 2 2017, 8:39 PM

Jdlrobson added a subtask: T139798: It should be easier to create new overlays.

Jdlrobson added a subtask: T156186: MFA: MobileFrontend should not have a global event emitter.Jun 2 2017, 8:44 PM

Jdlrobson added a subtask: T104008: Have a consistent way of doing Views within Views.Jun 2 2017, 8:50 PM

^ Per http://doodle.com/poll/88r2cm6tz649vvgk

Jdlrobson added a subtask: T94086: [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates.Jun 12 2017, 3:53 PM

Some notes from our first session: https://etherpad.wikimedia.org/p/readingwebfrontendcode

Jdlrobson added a subtask: T167699: [EPIC] Enable JS error reporting in the mobile website.Jun 12 2017, 5:30 PM

Jdlrobson added a subtask: T144402: Extract MobileFrontend UI components to an external well documented library.Jun 15 2017, 9:14 PM

Jdlrobson added a subtask: T149909: [EPIC] Proposal: abandon use of template partials in MobileFrontend for components within components e.g. Button, Icon and Anchor classes .

Jdlrobson added a subtask: T140205: Remove all id CSS selectors in MobileFrontend.

Jdlrobson moved this task from Needs Prioritization to Epics/Goals on the Web-Team-Backlog board.Jul 3 2017, 10:11 PM

Jdlrobson created subtask T172454: mw.template, mw.user and mw.msg should be wrapped by local methods in View.js.Aug 3 2017, 10:31 PM

Jdlrobson created subtask T172455: mobile.startup/user should be passed in as a parameter to all our View code.Aug 3 2017, 10:35 PM

Jdlrobson added a subtask: T160128: MFA: Spike [8hr] Review CSS code conventions and improve to minimise chance of UI regressions.Aug 8 2017, 2:19 PM

Jdlrobson created subtask T173534: MFA: Add TopicTitleList component.Aug 17 2017, 7:00 PM

Jdlrobson created subtask T173539: Abandon use of globals in MobileFrontend classes.Aug 17 2017, 8:09 PM

Jdlrobson closed subtask T138764: Spike: Do a code review session on Skin.js as Resolved.Sep 6 2017, 6:40 PM

The web team did several sessions where we talked about our code.
Next step is to think about ways of going about change. A new umbrella project MobileFrontend (MobileFrontend and MinervaNeue architecture) has been setup to capture this.