Page MenuHomePhabricator
Create Task
Maniphest T170223

Remove 'browser default' as an option for the 'editfont' user preference option
Closed, ResolvedPublic
Actions

Description

Some browsers have different default textarea fonts than others, so there currently is an option for users to simply use whatever that is in lieu of anything specific.

This causes problems for things which normalise fonts or define their own font stacks (such as OOjs UI and various skins), as it becomes no longer possible to maintain consistent fonts throughout the interface when one random part is explicitly not using the usual fonts. If users want a particular font (such as whatever is equivalent to their usual browser), they should just set their preference to that in general (if they want sans serif, they should just set it to that).

The current options become these classes:

  • mw-editfont-default
  • mw-editfont-monospace
  • mw-editfont-sans-serif
  • mw-editfont-serif

Note: default is not just an option, but is currently was before August 2017 the default setting for the 'editfont' preference.

Details

SubjectRepoBranchLines +/-
Remove 'Browser default' editfont optionmediawiki/coremaster+0 -10
Remove reference to editfont-defaultmediawiki/extensions/VisualEditormaster+0 -1
Remove reference to editfont-defaultmediawiki/extensions/CodeMirrormaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Isarra created this task.Jul 11 2017, 1:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2017, 1:11 AM
Isarra updated the task description. (Show Details)Jul 12 2017, 3:58 PM
Isarra removed a project: OOUI.
matmarex mentioned this in T171201: Make 'monospace' the default font for the wikitext editor.Jul 20 2017, 6:05 PM
matmarex subscribed.
Esanders added a subtask: T171201: Make 'monospace' the default font for the wikitext editor.Jul 25 2017, 6:21 PM
matmarex unsubscribed.Jul 25 2017, 10:22 PM
• demon subscribed.Aug 2 2017, 5:41 AM

I'm curious about usage stats on this preference generally, at least across large.dblist.

Jdforrester-WMF closed subtask T171201: Make 'monospace' the default font for the wikitext editor as Resolved.Aug 21 2017, 5:25 PM
Jdforrester-WMF triaged this task as Low priority.Aug 21 2017, 5:28 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a comment.Aug 21 2017, 11:20 PM
In T170223#3492019, @demon wrote:

I'm curious about usage stats on this preference generally, at least across large.dblist.

As until wmf.15 rolls out this is the default value, it's all but a few thousand accounts. Specifically, for enwiki:

mysql:research@analytics-store.eqiad.wmnet [enwiki]> SELECT up_property, up_value, COUNT(up_value) FROM user_properties WHERE up_property="editfont" GROUP BY up_value LIMIT 10;
+-------------+------------+-----------------+
| up_property | up_value   | COUNT(up_value) |
+-------------+------------+-----------------+
| editfont    | monospace  |            2822 |
| editfont    | sans-serif |            3514 |
| editfont    | serif      |            1107 |
+-------------+------------+-----------------+
3 rows in set (45.60 sec)
mysql:research@analytics-store.eqiad.wmnet [dewiki]> SELECT up_property, up_value, COUNT(up_value) FROM user_properties WHERE up_property="editfont" GROUP BY up_value LIMIT 10;
+-------------+------------+-----------------+
| up_property | up_value   | COUNT(up_value) |
+-------------+------------+-----------------+
| editfont    | monospace  |             366 |
| editfont    | sans-serif |             201 |
| editfont    | serif      |             126 |
+-------------+------------+-----------------+
3 rows in set (3.60 sec)
mysql:research@analytics-store.eqiad.wmnet [frwiki]> SELECT up_property, up_value, COUNT(up_value) FROM user_properties WHERE up_property="editfont" GROUP BY up_value LIMIT 10;
+-------------+------------+-----------------+
| up_property | up_value   | COUNT(up_value) |
+-------------+------------+-----------------+
| editfont    | monospace  |             170 |
| editfont    | sans-serif |             120 |
| editfont    | serif      |              77 |
+-------------+------------+-----------------+
3 rows in set (2.28 sec)
mysql:research@analytics-store.eqiad.wmnet [eswiki]> SELECT up_property, up_value, COUNT(up_value) FROM user_properties WHERE up_property="editfont" GROUP BY up_value LIMIT 10;
+-------------+------------+-----------------+
| up_property | up_value   | COUNT(up_value) |
+-------------+------------+-----------------+
| editfont    | monospace  |             204 |
| editfont    | sans-serif |             194 |
| editfont    | serif      |             109 |
+-------------+------------+-----------------+
3 rows in set (1.98 sec)

Honestly, with these numbers we might as well just kill the preference entirely, given the cost to every user of each preference.

gerritbot subscribed.Aug 25 2017, 5:36 PM

Change 373932 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Remove 'Browser default' editfont option

https://gerrit.wikimedia.org/r/373932

Restricted Application added a subscriber: jeblad. · View Herald TranscriptAug 25 2017, 5:36 PM
gerritbot added a project: Patch-For-Review.Aug 25 2017, 5:36 PM
gerritbot added a comment.Aug 25 2017, 5:46 PM

Change 373934 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeMirror@master] Remove reference to editfont-default

https://gerrit.wikimedia.org/r/373934

gerritbot added a comment.Aug 25 2017, 5:46 PM

Change 373935 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Remove reference to editfont-default

https://gerrit.wikimedia.org/r/373935

jeblad unsubscribed.Aug 25 2017, 9:34 PM
Esanders subscribed.Aug 29 2017, 3:37 PM

Yes, let's, before people starting using it!

Esanders added a comment.Sep 26 2017, 12:57 PM

Ping

Jdforrester-WMF added a comment.Sep 29 2017, 6:03 PM

Added to Tech/News 41 (so will go out on 9 October 2017); merge after the cut on 3 October.

Jdforrester-WMF closed this task as Resolved.Oct 3 2017, 6:37 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Oct 3 2017, 6:46 PM

Change 373932 merged by jenkins-bot:
[mediawiki/core@master] Remove 'Browser default' editfont option

https://gerrit.wikimedia.org/r/373932

gerritbot added a comment.Oct 3 2017, 6:48 PM

Change 373935 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Remove reference to editfont-default

https://gerrit.wikimedia.org/r/373935

gerritbot added a comment.Oct 3 2017, 6:48 PM

Change 373934 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Remove reference to editfont-default

https://gerrit.wikimedia.org/r/373934

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 3 2017, 7:00 PM
Liuxinyu970226 added a project: User-notice.Oct 5 2017, 3:18 AM
Liuxinyu970226 moved this task from To Triage to Announce in next Tech/News on the User-notice board.
Johan moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Oct 5 2017, 7:55 AM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Oct 12 2017, 5:51 PM
RandomDSdevel awarded a token.Oct 16 2017, 9:53 PM
Esanders mentioned this in T182320: Fix textarea editor's edit font size.Dec 7 2017, 1:09 PM
Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL