Page MenuHomePhabricator
Create Task
Maniphest T170330

Replace Flow DI (pimple) with MediaWikiServices
Open, Needs TriagePublic
Actions

Description

Instead of using its own DI system, Flow should migrate to MediaWikiServices.

Details

SubjectRepoBranchLines +/-
container.php: move `deferred_queue` to ServiceWiring.phpmediawiki/extensions/Flowmaster+7 -1
Move formatter.revision.factory and some formatters to ServiceWiring.phpmediawiki/extensions/Flowmaster+118 -50
Move templating and related to ServiceWiring.phpmediawiki/extensions/Flowmaster+69 -41
container.php: move `formatter.revision.factory` to ServiceWiring.phpmediawiki/extensions/Flowmaster+16 -9
container.php: move 11 formatters to ServiceWiring.phpmediawiki/extensions/Flowmaster+119 -42
container.php: move `templating` to ServiceWiring.phpmediawiki/extensions/Flowmaster+30 -22
container.php: move some services to ServiceWiring.phpmediawiki/extensions/Flowmaster+41 -15
container.php: move `url_generator` and `storage.workflow.mapper` to ServiceWiring.phpmediawiki/extensions/Flowmaster+19 -7
container.php: merge `storage.manager_list` entry into `storage`mediawiki/extensions/Flowmaster+8 -6
container.php: merge `storage.post_summary.listeners.username` into only usermediawiki/extensions/Flowmaster+9 -11
Add a new StorageManager servicemediawiki/extensions/Flowmaster+301 -151
Add a ListenerFactory servicemediawiki/extensions/Flowmaster+160 -41
container.php: merge more single-use entriesmediawiki/extensions/Flowmaster+59 -77
container.php: merge some single use mapper entriesmediawiki/extensions/Flowmaster+14 -21
container.php: merge some single use backend entriesmediawiki/extensions/Flowmaster+26 -37
container.php: merge some single use mapper entriesmediawiki/extensions/Flowmaster+14 -21
container.php: merge some single use backend entriesmediawiki/extensions/Flowmaster+26 -36
container.php: merge more single use index entriesmediawiki/extensions/Flowmaster+32 -43
container.php: merge more single-use entriesmediawiki/extensions/Flowmaster+66 -94
container.php: merge some single use index entriesmediawiki/extensions/Flowmaster+23 -39
container.php: merge single use listeners entriesmediawiki/extensions/Flowmaster+64 -62
container.php: merge single use indexes entriesmediawiki/extensions/Flowmaster+30 -57
Move repository.tree and a few others to ServiceWiring.phpmediawiki/extensions/Flowmaster+42 -20
Move FlowUser and FlowPermissions to ServiceWiring.phpmediawiki/extensions/Flowmaster+20 -6
Move the next few services to ServiceWiring.phpmediawiki/extensions/Flowmaster+31 -15
Add ServiceWiring.php and move first servicesmediawiki/extensions/Flowmaster+41 -4
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Jul 11 2017, 8:36 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 11 2017, 8:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Catrope mentioned this in T167928: Improve structured discussion features for the communities that use them, based on user feedback and prioritising technical debt.Jul 11 2017, 8:40 PM
Catrope moved this task from Untriaged to Flow Holding Area on the Collaboration-Team-Triage board.Aug 1 2017, 6:16 PM
Catrope moved this task from Backlog to Medium Structured Discussions on the StructuredDiscussions board.
Aklapper removed a project: Collaboration-Team-Triage.Oct 12 2019, 4:11 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 12 2019, 4:11 AM
Reedy subscribed.Dec 22 2020, 9:55 PM

Pimple is now closed for changes. No new features will be added and no cosmetic changes will be accepted either. The only accepted changes are compatiblity with newer PHP versions and security issue fixes.

https://github.com/silexphp/Pimple/commit/855b0196f58541b312d947205b628aab1296603b

Jdforrester-WMF subscribed.Dec 22 2020, 9:56 PM

Upstream (pimple) have announced they're no longer accepting patches (except for security patches and PHP version support bumps), so this would be nice to get done sooner or later. Any volunteers? :-)

Jdforrester-WMF added a project: Dependency injection.Dec 22 2020, 10:43 PM
DannyS712 added a project: User-DannyS712.Dec 22 2020, 11:49 PM
DannyS712 subscribed.
In T170330#6709249, @Jdforrester-WMF wrote:

Upstream (pimple) have announced they're no longer accepting patches (except for security patches and PHP version support bumps), so this would be nice to get done sooner or later. Any volunteers? :-)

I should have time to investigate this soon

Jdforrester-WMF added a comment.Dec 22 2020, 11:52 PM
In T170330#6709421, @DannyS712 wrote:
In T170330#6709249, @Jdforrester-WMF wrote:

Upstream (pimple) have announced they're no longer accepting patches (except for security patches and PHP version support bumps), so this would be nice to get done sooner or later. Any volunteers? :-)

I should have time to investigate this soon

That'd be brill. Thanks!

DannyS712 added a comment.Dec 23 2020, 2:34 AM
In T170330#6709433, @Jdforrester-WMF wrote:

That'd be brill. Thanks!

sorry to disappoint - I started looking into it, and its a whole lot harder than I thought. I'm happy to review patches for this, but won't be fixing it myself

DannyS712 removed a project: User-DannyS712.Feb 16 2021, 6:08 PM
gerritbot added a comment.Mar 29 2021, 12:41 AM

Change 675302 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/extensions/Flow@master] Start cleaning up use of container/pimple

https://gerrit.wikimedia.org/r/675302

gerritbot added a project: Patch-For-Review.Mar 29 2021, 12:41 AM
DannyS712 added a comment.Mar 29 2021, 12:56 AM

Took another look, might be easier to do in multiple steps

gerritbot added a comment.Mar 29 2021, 1:24 AM

Change 675303 had a related patch set uploaded (by DannyS712; author: DannyS712):
[mediawiki/extensions/Flow@master] Add ServiceWiring.php and move first service

https://gerrit.wikimedia.org/r/675303

gerritbot added a comment.Apr 2 2021, 12:30 AM

Change 675303 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Add ServiceWiring.php and move first services

https://gerrit.wikimedia.org/r/675303

gerritbot added a comment.Apr 2 2021, 12:46 AM

Change 676360 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Move the next few services to ServiceWiring.php

https://gerrit.wikimedia.org/r/676360

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.38; 2021-04-06).Apr 2 2021, 1:00 AM
Jdforrester-WMF added a parent task: T150350: Port Flow to new core dependency injection container.Apr 2 2021, 10:36 PM
gerritbot added a comment.Apr 2 2021, 11:03 PM

Change 676360 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Move the next few services to ServiceWiring.php

https://gerrit.wikimedia.org/r/676360

gerritbot added a comment.Apr 3 2021, 8:51 PM

Change 676525 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Move FlowUser and FlowPermissions to ServiceWiring.php

https://gerrit.wikimedia.org/r/676525

gerritbot added a comment.Apr 7 2021, 12:14 AM

Change 676525 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Move FlowUser and FlowPermissions to ServiceWiring.php

https://gerrit.wikimedia.org/r/676525

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 7 2021, 1:00 AM
gerritbot added a comment.Apr 7 2021, 4:36 PM

Change 677399 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Move repository.tree and a few others to ServiceWiring.php

https://gerrit.wikimedia.org/r/677399

gerritbot added a comment.Apr 8 2021, 3:27 AM

Change 677399 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Move repository.tree and a few others to ServiceWiring.php

https://gerrit.wikimedia.org/r/677399

gerritbot added a comment.Apr 12 2021, 1:49 AM

Change 678415 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Move templating and related to ServiceWiring.php

https://gerrit.wikimedia.org/r/678415

gerritbot added a comment.Apr 12 2021, 2:55 AM

Change 678416 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Move formatter.revision.factory and some formatters to ServiceWiring.php

https://gerrit.wikimedia.org/r/678416

gerritbot added a comment.Apr 12 2021, 3:59 PM

Change 678421 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge single use indexes entries

https://gerrit.wikimedia.org/r/678421

gerritbot added a comment.Apr 12 2021, 9:21 PM

Change 678648 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge single use listeners entries

https://gerrit.wikimedia.org/r/678648

gerritbot added a comment.Apr 12 2021, 9:46 PM

Change 678421 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge single use indexes entries

https://gerrit.wikimedia.org/r/678421

gerritbot added a comment.Apr 12 2021, 9:59 PM

Change 678649 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge some single use indexes entries

https://gerrit.wikimedia.org/r/678649

gerritbot added a comment.Apr 13 2021, 5:34 PM

Change 678701 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge more single use index entries

https://gerrit.wikimedia.org/r/678701

gerritbot added a comment.Apr 13 2021, 5:48 PM

Change 678702 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge some single use backend entries

https://gerrit.wikimedia.org/r/678702

gerritbot added a comment.Apr 13 2021, 6:00 PM

Change 678703 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge some single use mapper entries

https://gerrit.wikimedia.org/r/678703

gerritbot added a comment.Apr 13 2021, 9:44 PM

Change 678648 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge single use listeners entries

https://gerrit.wikimedia.org/r/678648

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.3; 2021-04-27); removed MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 13 2021, 10:00 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:56 PM
gerritbot added a comment.Apr 16 2021, 4:22 PM

Change 678649 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge some single use index entries

https://gerrit.wikimedia.org/r/678649

Lens0021 subscribed.May 25 2021, 12:22 PM
gerritbot added a comment.Jun 28 2021, 3:50 PM

Change 678701 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge more single use index entries

https://gerrit.wikimedia.org/r/678701

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.12; 2021-06-28); removed MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Jun 28 2021, 4:00 PM
gerritbot added a comment.Jun 28 2021, 10:44 PM

Change 701724 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge some single use backend entries

https://gerrit.wikimedia.org/r/701724

gerritbot added a comment.Jun 28 2021, 10:45 PM

Change 678702 abandoned by DannyS712:

[mediawiki/extensions/Flow@master] container.php: merge some single use backend entries

Reason:

my git isn't letting me rebase this properly, so abandoning and redoing at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/ /701724

https://gerrit.wikimedia.org/r/678702

gerritbot added a comment.Jun 29 2021, 2:58 AM

Change 702009 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge some single use mapper entries

https://gerrit.wikimedia.org/r/702009

gerritbot added a comment.Jun 29 2021, 2:59 AM

Change 678703 abandoned by DannyS712:

[mediawiki/extensions/Flow@master] container.php: merge some single use mapper entries

Reason:

my git isn't letting me rebase this properly, so abandoning and redoing at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/ /702009

https://gerrit.wikimedia.org/r/678703

gerritbot added a comment.Jul 1 2021, 3:25 PM

Change 701724 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge some single use backend entries

https://gerrit.wikimedia.org/r/701724

gerritbot added a comment.Jul 1 2021, 3:25 PM

Change 702009 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge some single use mapper entries

https://gerrit.wikimedia.org/r/702009

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.14; 2021-07-12); removed MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jul 1 2021, 4:00 PM
gerritbot added a comment.Jul 1 2021, 11:34 PM

Change 702725 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge more single-use entries

https://gerrit.wikimedia.org/r/702725

gerritbot added a comment.Jul 2 2021, 9:55 AM

Change 702725 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge more single-use entries

https://gerrit.wikimedia.org/r/702725

gerritbot added a comment.Jul 7 2021, 12:25 AM

Change 703423 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Add a new StorageManager service

https://gerrit.wikimedia.org/r/703423

gerritbot added a comment.Jul 7 2021, 12:45 AM

Change 703424 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge storage.post_summary.listeners.username

https://gerrit.wikimedia.org/r/703424

gerritbot added a comment.May 6 2023, 8:25 PM

Change 703424 abandoned by DannyS712:

[mediawiki/extensions/Flow@master] Add a ListenerFactory service

Reason:

https://gerrit.wikimedia.org/r/703424

gerritbot added a comment.May 6 2023, 8:26 PM

Change 703423 abandoned by DannyS712:

[mediawiki/extensions/Flow@master] Add a new StorageManager service

Reason:

https://gerrit.wikimedia.org/r/703423

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Oct 29 2023, 6:41 PM
Umherirrender mentioned this in T351888: Flow integration tests block GrowthExperiments merges with an unexpected ContainerDisabledException.Nov 26 2023, 1:44 PM
Umherirrender mentioned this in T356704: PageTriage CI broken (PHPUnit: There was 1 error: HooksTest::testOnPageUndelete: Container disabled).Feb 20 2024, 9:27 PM
gerritbot added a comment.Wed, May 22, 4:46 AM

Change #1034608 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge `storage.manager_list` entry into `storage`

https://gerrit.wikimedia.org/r/1034608

gerritbot added a project: Patch-For-Review.Wed, May 22, 4:46 AM
Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptWed, May 22, 4:46 AM
gerritbot added a comment.Wed, May 22, 4:59 AM

Change #1034609 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: merge `storage.post_summary.listeners.username` into only user

https://gerrit.wikimedia.org/r/1034609

gerritbot added a comment.Wed, May 22, 5:13 AM

Change #1034611 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move some services to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034611

gerritbot added a comment.Wed, May 22, 5:48 AM

Change #1034619 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move `url_generator` and `storage.workflow.mapper` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034619

gerritbot added a comment.Wed, May 22, 5:55 AM

Change #1034620 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move `templating` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034620

gerritbot added a comment.Wed, May 22, 2:28 PM

Change #1034608 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge `storage.manager_list` entry into `storage`

https://gerrit.wikimedia.org/r/1034608

gerritbot added a comment.Wed, May 22, 2:28 PM

Change #1034609 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: merge `storage.post_summary.listeners.username` into only user

https://gerrit.wikimedia.org/r/1034609

gerritbot added a comment.Wed, May 22, 2:28 PM

Change #1034611 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move some services to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034611

gerritbot added a comment.Wed, May 22, 2:28 PM

Change #1034619 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move `url_generator` and `storage.workflow.mapper` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034619

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).Wed, May 22, 3:00 PM
gerritbot added a comment.Wed, May 22, 3:35 PM

Change #1034986 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move `formatter.revision.factory` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034986

gerritbot added a comment.Wed, May 22, 3:52 PM

Change #1034987 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move 10 formatters to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034987

gerritbot added a comment.Wed, May 22, 4:29 PM

Change #1034988 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] container.php: move `deferred_queue` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034988

gerritbot added a comment.Wed, May 22, 5:34 PM

Change #1034620 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move `templating` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034620

gerritbot added a comment.Wed, May 22, 5:35 PM

Change #1034986 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move `formatter.revision.factory` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034986

gerritbot added a comment.Wed, May 22, 5:43 PM

Change #1034987 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move 11 formatters to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034987

gerritbot added a comment.Wed, May 22, 5:43 PM

Change #1034988 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] container.php: move `deferred_queue` to ServiceWiring.php

https://gerrit.wikimedia.org/r/1034988

gerritbot added a comment.Wed, May 22, 11:20 PM

Change #678415 abandoned by DannyS712:

[mediawiki/extensions/Flow@master] Move templating and related to ServiceWiring.php

Reason:

since this has been done in various other patches

https://gerrit.wikimedia.org/r/678415

gerritbot added a comment.Wed, May 22, 11:21 PM

Change #678416 abandoned by DannyS712:

[mediawiki/extensions/Flow@master] Move formatter.revision.factory and some formatters to ServiceWiring.php

Reason:

since I sent this patch all have since been done in other patches

https://gerrit.wikimedia.org/r/678416

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL