Page MenuHomePhabricator

Deleted and non-existent lexemes should be indicated as such
Closed, ResolvedPublic

Description

Problem:
Links to deleted Lexemes in statement are not handled the same way as links to deleted items in statements.

Example:

Screenshots/mockups:

BDD
GIVEN
AND
WHEN
AND
THEN
AND

Acceptance criteria:

Open questions:

  • Is there a way we can do this for Forms without shooting ourselves in the foot?

Event Timeline

I am not seeing any deleted and non-existent lexemes being used there. Can you clarify? Maybe add a screenshot? Thanks!

For example if you click "card" and "bard" in Rhymes statement, you will find both do not exist.

Lydia_Pintscher lowered the priority of this task from High to Low.Sep 2 2018, 3:39 PM

@Greta_Doci_WMDE can you produce a screenshot for how this looks with links to a deleted item in a statement?

I'm not Greta but here's a screenshot:

link-to-deleted-item.png (143×938 px, 8 KB)
The ID is displayed as unlinked black text followed by "(Deleted item)" in grey italics. You can usually find examples on this report.

Links to deleted senses have the same problem, e.g. on L123-S4, the link to L123-S5 is a regular blue link.

Thank you NIkki.

Links to deleted senses have the same problem, e.g. on L123-S4, the link to L123-S5 is a regular blue link.

+forms. It happens the same thing with forms. But with forms it is written "deleted form" after refresh, just like with items.

form.PNG (396×1 px, 12 KB)

Also, when you add a new sense/form the counting starts from the one you have deleted. Like for example, you delete the L123-S5, and add a new one, its will be L123-S6.

Change 679697 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/extensions/WikibaseLexeme@master] Show a message instead of fatal when the lexeme doesn't exist

https://gerrit.wikimedia.org/r/679697

Change 679697 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Show a message instead of fatal when the lexeme doesn't exist

https://gerrit.wikimedia.org/r/679697