Page MenuHomePhabricator
Create Task
Maniphest T173408

Set up a new logo on zh-classical.m.wikipedia (mobile version)
Closed, ResolvedPublic
Actions

Description

Here is:

Thank you very much.

Details

SubjectRepoBranchLines +/-
Set up a new logo on zh-classical.m.wikipediaoperations/mediawiki-configmaster+6 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

vjudge404 created this task.Aug 16 2017, 10:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2017, 10:19 AM
LNDDYL subscribed.Aug 16 2017, 1:55 PM
Urbanecm subscribed.Aug 24 2017, 9:21 PM

Does anybody know how to process this?

Urbanecm added a comment.Aug 24 2017, 9:22 PM

Is this $wgMobileFrontendLogo?

Urbanecm triaged this task as Low priority.Aug 24 2017, 9:22 PM
Urbanecm moved this task from Backlog to Config - to process on the Wikimedia-Site-requests board.
vjudge404 added a comment.Aug 24 2017, 11:31 PM

Yes. It's a bad idea to do a CSS override. (https://zh-classical.m.wikipedia.org/wiki/特殊:手機版差異/287906...287972)

TheresNoTime subscribed.Aug 25 2017, 9:02 AM
TheresNoTime claimed this task.EditedAug 25 2017, 9:09 AM
TheresNoTime added a project: User-TheresNoTime.

It's set from $wgMinervaCustomLogos (InitialiseSettings.php) and requires

'zh-classical' => [
    'copyright' => '[static path to png]',
    'copyright-width' => 80,
    'copyright-height' => 18,
 ],

I'll get this done over the weekend

TheresNoTime mentioned this in T174192: Upload wikipedia-wordmark-zh-c.svg to /static/images/mobile/copyright/.Aug 25 2017, 6:38 PM
TheresNoTime created subtask T174192: Upload wikipedia-wordmark-zh-c.svg to /static/images/mobile/copyright/.
gerritbot subscribed.Aug 25 2017, 7:16 PM

Change 373956 had a related patch set uploaded (by Samtar; owner: Samtar):
[operations/mediawiki-config@master] Set up a new logo on zh-classical.m.wikipedia

https://gerrit.wikimedia.org/r/373956

gerritbot added a project: Patch-For-Review.Aug 25 2017, 7:16 PM
Urbanecm closed subtask T174192: Upload wikipedia-wordmark-zh-c.svg to /static/images/mobile/copyright/ as Invalid.Aug 25 2017, 8:00 PM
gerritbot added a comment.Aug 25 2017, 8:01 PM

Change 373956 abandoned by Samtar:
Set up a new logo on zh-classical.m.wikipedia

Reason:
Ic1868eb468111d38d98aa95b6887c1232999e8d9

https://gerrit.wikimedia.org/r/373956

TheresNoTime moved this task from Config - to process to To deploy on the Wikimedia-Site-requests board.Aug 26 2017, 5:45 AM

After some gnashing of teeth, this is set for deployment Monday, August 28 18:00–19:00 UTC

TheresNoTime added a comment.Aug 28 2017, 5:55 PM

@vjudge404 pending deployment in a couple of minutes, could you remove the CSS override? I can test this has worked without the override though, so no rush :)

TheresNoTime closed this task as Resolved.Aug 28 2017, 6:25 PM

Deployed, and tested (inspected element, found reference to new logo). Please remove the CSS override and re-open this task if there's any issues

vjudge404 added a comment.Aug 28 2017, 11:09 PM

The CSS override has been removed. Thanks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL