What "general styleguide" do you have in mind that this is trying to ape? These changes don't look very much like the WikimediaUI design (which is what OOUI implements for Vector and Minerva users), and in general it's a really bad idea to try to duplicate styles ad hoc rather than actual using the UI library.

Changing the experience for established editors is always very concerning, which is why we've not made any changes here to date.

If you want a wikitext editor which implements the WikimediaUI design, the wikitext mode of the visual editor is designed to provide exactly this. Eventually I expect that to be made the default editor for all users (except those who opt out).

What "general styleguide" do you have in mind that this is trying to ape? These changes don't look very much like the WikimediaUI design (which is what OOUI implements for Vector and Minerva users), and in general it's a really bad idea to try to duplicate styles ad hoc rather than actual using the UI library.

https://wikimedia.github.io/WikimediaUI-Style-Guide/visual-style_colors.html

Changing the experience for established editors is always very concerning, which is why we've not made any changes here to date.

Im not sure that this update will change the user experisence.

If you want a wikitext editor which implements the WikimediaUI design, the wikitext mode of the visual editor is designed to provide exactly this. Eventually I expect that to be made the default editor for all users (except those who opt out).

Yes, I know about wikieditor 2017, but it is unconfortable for me :) And I think the all Wikimedia WikiEditors must be matched with general Style Guide.

@Iniquity As much as I understand (and in some ways would support) this cause, we are currently focussing our work on the new Wikitext Editor to bring an overall better experience to our contributors. There is not enough capacity to work on nor for the needed broader communication to the communities for this change right now.

@Volker_E ok:) Thanks for the answer, but I hope this issue will be fixed in future:)

Some of this has been tackled in T179411 / https://gerrit.wikimedia.org/r/#/c/387602/

@Ladsgroup While I would probably leave out the toolbar/textarea amendments due to lack of time communicating for it, background-color on .wikiEditor-ui-toolbar .booklet .index .current is still #fafafaif you want to push another patch.

Change 387664 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikiEditor@master] More alignment with WikimediaUI color style

https://gerrit.wikimedia.org/r/387664

@Volker_E Done :)

Change 387664 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] More alignment with WikimediaUI color style

https://gerrit.wikimedia.org/r/387664

Uh... I was hoping that we would be gray colored :)

T191031: Use OOUI icons in WikiEditor is related.

I don’t think anybody will object to dropping the gradient, tho (is not a part of the Wikimedia visual language).

Can this be closed or are there still things we want to change ?

There's only two of the suggested changes left:

• Add background-color: #eaecf0 to .wikiEditor-ui-toolbar (currently #f8f9fa)
• Add box-shadow: inset 1px 1px 0px 0px rgba(0,0,0,0.5) to <textarea>

I'm not sure either of these are actually needed to match current styles

@Pcoombe The inset box-shadow proposed originally in the task description wasn't aligned to our UI widgets, specifically textarea, hence removed from description.

Resolved as is with current state of UI

In T174119#6126257, @Volker_E wrote:

@Pcoombe The inset box-shadow proposed originally in the task description wasn't aligned to our UI widgets, specifically textarea, hence removed from description.

Yes, I added a shadow to provide more similarity to the old design. It is not needed if we follow the style guide. Thank you! :)