hat-web-tool/projects: listing incorrect number of users on some projects (not listening to ug_expiry)
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	MarcoAurelio
	Sep 24 2017, 2:54 PM

Description

I guess something's wrong with the SQL queries because, for example, it lists astwiki with 1 user in the 'checkuser' group, which at this moment ain't true (the same for several others).

Details

	Subject	Repo	Branch	Lines +/-
	Update MySQL DB connection to use analytics.db.svc.eqiad.wmflabs	labs/tools/stewardbots	master	+2 -2

Customize query in gerrit

Revisions and Commits

rTSTW tool-stewardbots
	rTSTW261fda1c5855 Update MySQL DB connection to use analytics.db.svc.eqiad.wmflabs

Related Objects

Mentioned In: T156545: Outdated MySQL handling for hat-web-tool@stewardbots
T176754: Regularly purge expired temporary userrights from DB tables
Mentioned Here: T156545: Outdated MySQL handling for hat-web-tool@stewardbots

Event Timeline

MarcoAurelio created this task.Sep 24 2017, 2:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2017, 2:54 PM

Is:

$db_server = mysql_connect("metawiki.labsdb", $loginData['user'], $loginData['password']);

metawiki.labsdb still a valid DB name?

MarcoAurelio moved this task from General to UI on the stewardbots board.Sep 24 2017, 3:46 PM

@Steinsplitter Is this related to T156545 somehow?

In T176578#3630279, @MarcoAurelio wrote:

@Steinsplitter Is this related to T156545 somehow?

No, But on the old replicas a few tables seems to be gone.

@bd808 Something that can be fixed with what was announced at Blog Post: New Wiki Replica servers ready for use?

Change 380748 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[labs/tools/stewardbots@master] Update MySQL DB connection to use analytics.db.svc.eqiad.wmflabs

https://gerrit.wikimedia.org/r/380748

Change 380748 merged by jenkins-bot:
[labs/tools/stewardbots@master] Update MySQL DB connection to use analytics.db.svc.eqiad.wmflabs

https://gerrit.wikimedia.org/r/380748

https://github.com/wikimedia/labs-tools-stewardbots/commit/261fda1c58556c21e479ca6dab1a7a4abdc09672 didn't break the tool (that's a step forward), but it's still displaying incorrect data. For example, search for projects with 1 CheckUser and you'll see that in most of them, that's not true. Either the MySQL query is broken or badly formatted, so it give us wrong results.

I've updated the hosts to the new ones, and after consulting with a DBA, found a problem with temporary userrights, so I'll report that in a separate bug.

Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptSep 26 2017, 2:31 PM

MarcoAurelio moved this task from unsorted/backlog to cabinet on the User-MarcoAurelio board.Sep 26 2017, 2:31 PM

MarcoAurelio removed a project: Patch-For-Review.

MarcoAurelio mentioned this in T176754: Regularly purge expired temporary userrights from DB tables.Sep 26 2017, 2:37 PM

https://phabricator.wikimedia.org/diffusion/TSTW/browse/master/hat-web-tool/projects.php does not take into count ug_expiry from user_groups, so it's potentially listing a lot of outdated data.

MarcoAurelio renamed this task from hat-web-tool/projects: listing incorrect number of users on some projects to hat-web-tool/projects: listing incorrect number of users on some projects (not listening to ug_expiry).Sep 26 2017, 3:19 PM

MarcoAurelio removed MarcoAurelio as the assignee of this task.

MarcoAurelio added a parent task: T156545: Outdated MySQL handling for hat-web-tool@stewardbots.

MarcoAurelio removed a project: User-MarcoAurelio.

MarcoAurelio mentioned this in T156545: Outdated MySQL handling for hat-web-tool@stewardbots.Sep 28 2017, 11:09 AM

MarcoAurelio removed a parent task: T156545: Outdated MySQL handling for hat-web-tool@stewardbots.

MarcoAurelio merged a task: T156545: Outdated MySQL handling for hat-web-tool@stewardbots.

MarcoAurelio added a commit: rTSTW261fda1c5855: Update MySQL DB connection to use analytics.db.svc.eqiad.wmflabs.Sep 28 2017, 11:12 AM