Performance review of RCFilters feature
Closed, ResolvedPublic
Actions

Description

Following T176250, and in general, we should make sure a performance review is done for RCFilters at some point.

Three main workflows come to mind:

Page load of Special:RecentChanges (with and without filters).
Initialisation of the RCFilters feature (when enabled).
Interaction with the feature.

For each of these:

Avoid FOUC.
RAIL-compliant (work loads in small chunks, allowing quick response to user input, timely ajax loads and/or progressive load expectation to users, any animations being smooth, etc.).

Details

Subject	Repo	Branch	Lines +/-
Remove perf tracking code that was moved to WikimediaEvents in Ib300af5c	mediawiki/core	wmf/1.31.0-wmf.2	+0 -12
Move RCFilters performance logging to WikimediaEvents and also log performance for old UI	mediawiki/extensions/WikimediaEvents	wmf/1.31.0-wmf.2	+41 -2
Remove perf tracking code that was moved to WikimediaEvents in Ib300af5c	mediawiki/core	master	+0 -12
Move RCFilters performance logging to WikimediaEvents and also log performance for old UI	mediawiki/extensions/WikimediaEvents	master	+41 -2
RCFilters: Log performance data	mediawiki/core	wmf/1.31.0-wmf.1	+16 -6
RCFilters: Log performance data	mediawiki/core	wmf/1.30.0-wmf.19	+16 -6
RCFilters: Log performance data	mediawiki/core	master	+16 -6
RCFilters: Cache ChangesListSpecialPage::buildChangeTagList()	mediawiki/core	master	+49 -38

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• DannyH	T171977 Annual Plan 2017-2018, Audiences 5: Increase current editor retention and engagement
Resolved	• DannyH	T171981 Annual Plan 2017-2018, Audiences 5, Goal 2: Give better ways to monitor contributions
Resolved	• jmatazzoni	T157642 Graduate New Filters UX out of beta on Recent Changes on ALL wikis
Resolved	Krinkle	T176652 Performance review of RCFilters feature
Resolved	Catrope	T176250 Defer building new filters menu to speed up performance
Resolved	None	T173533 No longer block user from clicking results when page is loading.
Resolved	None	T166908 ChangesListSpecialPage backend: Respect saved query if no parameters
Resolved	Mooeypoo	T176380 Stop community links from opening then closing on Recent changes
Declined	Catrope	T176445 Systematically test load speeds of Watchlist and Recent Changes
Invalid	None	T178880 Slow load times on Recent Changes for Firefox
Resolved	None	T176456 ORES on Watchlist causes big slowdown—especially with 'Last revision' filter turned on
Resolved	Etonkovidova	T177440 Determine on which wikis ORES filters cause significant Watchlist slowdowns
Resolved	Ladsgroup	T175778 Index on oresc_probability, temporarily or permanently
Resolved	Ladsgroup	T200680 Run PurgeScoreCache.php on all wikis that have ORES enabled
Resolved	Catrope	T177107 Highlighting many changes at init time is very slow
Open	None	T176385 Improve New Filters performance by changing DB query based on highlights?
Open	None	T178042 Code hygiene/performance: Batch filter update operations when we update multiple items
Resolved	Etonkovidova	T199940 Flash of unstyled content and reflows in new watchlist filter

Event Timeline

Moving to External for now as I believe @Catrope is already doing some work in this area. Once completed, or if you need anything, let us know :)

Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.Sep 25 2017, 5:28 PM

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.

Change 380578 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters: Cache ChangesListSpecialPage::buildChangeTagList()

https://gerrit.wikimedia.org/r/380578

gerritbot added a project: Patch-For-Review.Sep 25 2017, 7:40 PM

Change 380655 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters: Log performance data

https://gerrit.wikimedia.org/r/380655

Change 380578 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Cache ChangesListSpecialPage::buildChangeTagList()

https://gerrit.wikimedia.org/r/380578

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Sep 26 2017, 2:00 AM

• jmatazzoni added subtasks: T176250: Defer building new filters menu to speed up performance, T176456: ORES on Watchlist causes big slowdown—especially with 'Last revision' filter turned on, T176445: Systematically test load speeds of Watchlist and Recent Changes, T175778: Index on oresc_probability, temporarily or permanently.Sep 26 2017, 3:48 AM

• jmatazzoni added a subtask: T166908: ChangesListSpecialPage backend: Respect saved query if no parameters.

I've checked possible Gadgets that may interfere with the RC filters. According to the list of the most used gadgets, none of them are used on RCs.

Change 380655 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Log performance data

https://gerrit.wikimedia.org/r/380655

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)); removed MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Sep 26 2017, 6:01 PM

Change 380801 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@wmf/1.31.0-wmf.1] RCFilters: Log performance data

https://gerrit.wikimedia.org/r/380801

Change 380802 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@wmf/1.30.0-wmf.19] RCFilters: Log performance data

https://gerrit.wikimedia.org/r/380802

Change 380802 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.19] RCFilters: Log performance data

https://gerrit.wikimedia.org/r/380802

Change 380801 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.1] RCFilters: Log performance data

https://gerrit.wikimedia.org/r/380801

Mentioned in SAL (#wikimedia-operations) [2017-09-26T23:19:09Z] <thcipriani@tin> Synchronized php-1.31.0-wmf.1/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js: SWAT: [[gerrit:380801|RCFilters: Log performance data]] T176652 (duration: 00m 51s)

Mentioned in SAL (#wikimedia-operations) [2017-09-26T23:20:34Z] <thcipriani@tin> Synchronized php-1.30.0-wmf.19/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js: SWAT: [[gerrit:380802|RCFilters: Log performance data]] T176652 (duration: 00m 48s)

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)); removed MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)).Sep 27 2017, 12:01 AM

Change 381148 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/WikimediaEvents@master] Move RCFilters performance logging to WikimediaEvents and also log performance for old UI

https://gerrit.wikimedia.org/r/381148

Change 381149 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] Remove perf tracking code that was moved to WikimediaEvents in Ib300af5c

https://gerrit.wikimedia.org/r/381149

Etonkovidova closed subtask T176250: Defer building new filters menu to speed up performance as Resolved.Sep 29 2017, 12:38 AM

Catrope created subtask T177107: Highlighting many changes at init time is very slow.Sep 29 2017, 6:54 PM

Trizek-WMF mentioned this in T164489: Announce and follow up with communities about the New Filters for Recent changes by default deployment.Oct 2 2017, 1:11 PM

• Mattflaschen-WMF added a subtask: T176385: Improve New Filters performance by changing DB query based on highlights?.Oct 3 2017, 5:38 PM

Change 381148 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Move RCFilters performance logging to WikimediaEvents and also log performance for old UI

https://gerrit.wikimedia.org/r/381148

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)); removed MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Oct 4 2017, 9:00 PM

Change 381149 merged by jenkins-bot:
[mediawiki/core@master] Remove perf tracking code that was moved to WikimediaEvents in Ib300af5c

https://gerrit.wikimedia.org/r/381149

Change 382327 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/WikimediaEvents@wmf/1.31.0-wmf.2] Move RCFilters performance logging to WikimediaEvents and also log performance for old UI

https://gerrit.wikimedia.org/r/382327

Change 382328 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@wmf/1.31.0-wmf.2] Remove perf tracking code that was moved to WikimediaEvents in Ib300af5c

https://gerrit.wikimedia.org/r/382328

Change 382327 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.31.0-wmf.2] Move RCFilters performance logging to WikimediaEvents and also log performance for old UI

https://gerrit.wikimedia.org/r/382327

Change 382328 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.2] Remove perf tracking code that was moved to WikimediaEvents in Ib300af5c

https://gerrit.wikimedia.org/r/382328

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)); removed MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).Oct 5 2017, 12:01 AM

Mentioned in SAL (#wikimedia-operations) [2017-10-05T00:04:33Z] <catrope@tin> Synchronized php-1.31.0-wmf.2/extensions/WikimediaEvents/modules/ext.wikimediaEvents.recentChangesClicks.js: T176652 (duration: 00m 50s)

Mentioned in SAL (#wikimedia-operations) [2017-10-05T00:06:21Z] <catrope@tin> Synchronized php-1.31.0-wmf.2/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js: T176652 (duration: 00m 49s)