Page MenuHomePhabricator
Create Task
Maniphest T180605

Argument 1 passed to Wikibase\HistoryEntityAction::__construct() must be an instance of Article, WikiPage given in /srv/mediawiki/php-1.31.0-wmf.8/extensions/Wikidata/extensions/Wikibase/repo/includes/Content/ItemHandler.php on line 118
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

While trying to view history pages when testing mwf.8 of the Wikidata build extension on mwdebug1002.

Example: https://test.wikidata.org/w/index.php?title=Q37279&action=history

[{exception_id}] {exception_url} ErrorException from line 118 of /srv/mediawiki/php-1.31.0-wmf.8/extensions/Wikidata/extensions/Wikibase/repo/includes/Content/ItemHandler.php: PHP Error: Argument 1 passed to Wikibase\HistoryEntityAction::__construct() m

Catchable fatal error: Argument 1 passed to Wikibase\HistoryEntityAction::__construct() must be an instance of Article, WikiPage given in /srv/mediawiki/php-1.31.0-wmf.8/extensions/Wikidata/extensions/Wikibase/repo/includes/Content/ItemHandler.php on line
#0 /srv/mediawiki/php-1.31.0-wmf.8/extensions/Wikidata/extensions/Wikibase/repo/includes/Actions/HistoryEntityAction.php(46): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.31.0-wmf.8/extensions/Wikidata/extensions/Wikibase/repo/includes/Content/ItemHandler.php(118): Wikibase\HistoryEntityAction->__construct(WikiPage, RequestContext, Wikibase\Repo\Content\EntityContentFactory, Wikibase\Lib\Store\LanguageFallbackLabelDescriptionLookup)
#2 /srv/mediawiki/php-1.31.0-wmf.8/includes/actions/Action.php(107): Closure$Wikibase\Repo\Content\ItemHandler::getActionOverrides(WikiPage, RequestContext)
#3 /srv/mediawiki/php-1.31.0-wmf.8/includes/actions/Action.php(154): Action::factory(string, WikiPage, RequestContext)
#4 /srv/mediawiki/php-1.31.0-wmf.8/includes/MediaWiki.php(155): Action::getActionName(RequestContext)
#5 /srv/mediawiki/php-1.31.0-wmf.8/includes/MediaWiki.php(768): MediaWiki->getAction()
#6 /srv/mediawiki/php-1.31.0-wmf.8/includes/MediaWiki.php(523): MediaWiki->main()
#7 /srv/mediawiki/php-1.31.0-wmf.8/index.php(43): MediaWiki->run()
#8 /srv/mediawiki/w/index.php(3): include(string)
#9 {main}

Details

SubjectRepoBranchLines +/-
Action override callbacks must still accept WikiPage for now.mediawiki/extensions/Wikibasewmf/1.31.0-wmf.8+89 -15
Action override callbacks must still accept WikiPage for now.mediawiki/extensions/Wikibasemaster+89 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Nov 15 2017, 3:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2017, 3:25 PM
Addshore updated the task description. (Show Details)Nov 15 2017, 3:28 PM
Addshore added a project: Beta-Cluster-reproducible.

Reproducible on beta

Addshore added a parent task: T180539: wmf.8 still on old Wikidata branch.Nov 15 2017, 3:29 PM
Addshore added a project: Wikimedia-production-error.
Lucas_Werkmeister_WMDE added subscribers: WMDE-leszek, daniel, thiemowmde, Lucas_Werkmeister_WMDE.Nov 15 2017, 3:34 PM

https://gerrit.wikimedia.org/r/#/c/389958/ looks like it might be a fix for this, cc @thiemowmde @daniel @WMDE-leszek

Lucas_Werkmeister_WMDE added a comment.Nov 15 2017, 3:37 PM

Hm, perhaps not, AFAICT it will just move the type error a bit.

Addshore triaged this task as High priority.Nov 15 2017, 3:54 PM
daniel added a comment.Nov 15 2017, 4:04 PM

Caused by https://gerrit.wikimedia.org/r/#/c/387788/ which I wrote in preparation for https://gerrit.wikimedia.org/r/#/c/387685/

Addshore mentioned this in T180539: wmf.8 still on old Wikidata branch.Nov 15 2017, 4:05 PM
Addshore assigned this task to daniel.Nov 15 2017, 4:10 PM
Lucas_Werkmeister_WMDE added a comment.Nov 15 2017, 4:11 PM

Core’s Action::getActionName calls the factory function with a WikiPage, apparently:

$action = self::factory( $actionName, $context->getWikiPage(), $context );
gerritbot subscribed.Nov 15 2017, 4:38 PM

Change 391577 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@master] Action override callbacks must still accept WikiPage for now.

https://gerrit.wikimedia.org/r/391577

gerritbot added a project: Patch-For-Review.Nov 15 2017, 4:38 PM
gerritbot added a comment.Nov 15 2017, 5:26 PM

Change 391588 had a related patch set uploaded (by Addshore; owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.8] Action override callbacks must still accept WikiPage for now.

https://gerrit.wikimedia.org/r/391588

gerritbot added a comment.Nov 15 2017, 5:29 PM

Change 391577 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Action override callbacks must still accept WikiPage for now.

https://gerrit.wikimedia.org/r/391577

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 15 2017, 6:00 PM
Addshore closed this task as Resolved.Nov 15 2017, 7:05 PM
gerritbot added a comment.Nov 16 2017, 10:21 AM

Change 391588 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.31.0-wmf.8] Action override callbacks must still accept WikiPage for now.

https://gerrit.wikimedia.org/r/391588

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)); removed MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 16 2017, 11:00 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL