Page MenuHomePhabricator
Create Task
Maniphest T182104

Track entities to consider when checking whether cached constraint check result is valid
Closed, ResolvedPublic
Actions

Description

A CheckResult should hold a list of entity IDs which, when those entities are edited, should invalidate that check result. This set includes the current entity implicitly, but the “inverse”, “symmetric” and “target requires claim” checkers also add the target entity.

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Implicitly track property of constraintmediawiki/extensions/WikibaseQualityConstraintsmaster+8 -0
Implicitly track current entitymediawiki/extensions/WikibaseQualityConstraintsmaster+12 -0
Track target entity of inverse/symmetric/target checkersmediawiki/extensions/WikibaseQualityConstraintsmaster+53 -3
Track entity IDs in CachingMetadatamediawiki/extensions/WikibaseQualityConstraintsmaster+28 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Dec 5 2017, 3:20 PM
Lucas_Werkmeister_WMDE mentioned this in T182106: Read constraint check results from cache and check freshness.Dec 5 2017, 3:23 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to In Progress on the Wikidata-Sprint-2017-12-06 board.Dec 6 2017, 1:18 PM
Lucas_Werkmeister_WMDE moved this task from incoming to in progress on the Wikidata board.
Lucas_Werkmeister_WMDE moved this task from Backlog to DOING on the Wikibase-Quality board.
Lucas_Werkmeister_WMDE added a comment.Dec 6 2017, 6:25 PM

Actually, I suppose logically this belongs inside the CachingMetadata, doesn’t it?

gerritbot subscribed.Dec 7 2017, 5:16 PM

Change 396060 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Track entity IDs in CachingMetadata

https://gerrit.wikimedia.org/r/396060

gerritbot added a project: Patch-For-Review.Dec 7 2017, 5:16 PM

Change 396062 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Track target entity of inverse/symmetric/target checkers

https://gerrit.wikimedia.org/r/396062

gerritbot added a comment.Dec 7 2017, 5:16 PM

Change 396063 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Implicitly track current entity

https://gerrit.wikimedia.org/r/396063

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 7 2017, 5:17 PM
Lucas_Werkmeister_WMDE moved this task from In Progress to Review on the Wikidata-Sprint-2017-12-06 board.Dec 7 2017, 5:50 PM
gerritbot added a comment.Dec 8 2017, 11:31 AM

Change 396320 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Implicitly track property of constraint

https://gerrit.wikimedia.org/r/396320

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 8 2017, 11:32 AM
gerritbot added a comment.Dec 8 2017, 1:13 PM

Change 396060 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Track entity IDs in CachingMetadata

https://gerrit.wikimedia.org/r/396060

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 8 2017, 1:18 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Dec 8 2017, 2:00 PM
gerritbot added a comment.Dec 11 2017, 10:17 AM

Change 396062 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Track target entity of inverse/symmetric/target checkers

https://gerrit.wikimedia.org/r/396062

• Jonas closed this task as Resolved.Dec 11 2017, 12:51 PM
• Jonas updated the task description. (Show Details)
• Jonas moved this task from Review to Done on the Wikidata-Sprint-2017-12-06 board.
gerritbot added a comment.Dec 11 2017, 12:53 PM

Change 396063 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Implicitly track current entity

https://gerrit.wikimedia.org/r/396063

gerritbot added a comment.Dec 11 2017, 12:58 PM

Change 396320 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Implicitly track property of constraint

https://gerrit.wikimedia.org/r/396320

Lucas_Werkmeister_WMDE mentioned this in T182992: Update 'cached' information when getting constraint check results from cache.Dec 15 2017, 3:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL