During review of I2fb05b9117 (or perhaps I1433ea7e32, not sure), Jonas pointed out that it’s a bit strange to see words like “cache” pop up in CheckingResultsBuilder, which shouldn’t know anything about caching. After some discussion, we agreed on some changes we wanted to make – we wanted to do the necessary refactorings in a pair session, but didn’t find the time. In short, what’s currently called CachingMetadata should be split up, and all associated classes renamed to remove the “cache” from the name; and there could also be a ConstraintReport class, which would be a list of CheckResults plus their merged metadata, and perhaps DelegatingConstraintChecker would be changed to return that and renamed to something like ConstraintReportBuilder (though I don’t think we reached an agreement on this). See the subtasks for details.
Description
Description
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T182697 WikibaseQualityConstraints refactorings | |||
Resolved | Lucas_Werkmeister_WMDE | T183255 Split up CachingMetadata | |||
Open | None | T183256 Rename value+metadata wrappers to remove “cache” | |||
Resolved | Lucas_Werkmeister_WMDE | T183257 Introduce ConstraintReport class |
Event Timeline
Comment Actions
Hm, I kind of like “attachment(s)” as nomenclature for the “metadata”. But that doesn’t yield an obvious name for things like CachedBool. (Perhaps BoxedBool?)
Comment Actions
Change 398888 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Split up CachingMetadata