Page MenuHomePhabricator
Create Task
Maniphest T183927

Add parameter to only get violations from wbcheckconstraints (days: 1)
Closed, ResolvedPublic
Actions

Description

To reduce the size of wbcheckconstraints action API responses requested by the checkConstraints gadget, we’d like to add some parameter so that only the results which the gadget will actually display are returned: warnings, violations, and bad parameters. (This would be disabled by default, otherwise it’d be a breaking change.)

Once we move towards storing the constraint check results in the database (T179849: Cache all constraint check results per-entity; for T180582: List of all constraint violations), we can also consider whether we only want to store those partial results in the database (see T179849#3762879 and T179849#3767372). This would mean that API requests without this parameter set would not benefit from the cache, so we should definitely track how many requests use the parameter, to inform our decision later.

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Fix status parameter documentationmediawiki/extensions/WikibaseQualityConstraintsmaster+1 -1
Add status parameter to gadget’s API requestsmediawiki/extensions/WikibaseQualityConstraintsmaster+6 -3
Add status parameter to CheckConstraintsmediawiki/extensions/WikibaseQualityConstraintsmaster+83 -17
Add $statuses parameter to ResultsBuilder::getResultsmediawiki/extensions/WikibaseQualityConstraintsmaster+292 -38
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jan 2 2018, 4:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 2 2018, 4:45 PM
Lucas_Werkmeister_WMDE added a parent task: T173695: Enable constraint checks by default for users.Jan 2 2018, 5:08 PM
Lucas_Werkmeister_WMDE merged a task: T184159: Do not return compliance in constraint reports.Jan 4 2018, 11:27 AM
Lucas_Werkmeister_WMDE added subscribers: Ladsgroup, Lydia_Pintscher.
Lucas_Werkmeister_WMDE triaged this task as High priority.Jan 11 2018, 5:45 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-01-03.

It looks like this might be required before we can start with caching. So let’s add a status parameter right now, default value *, but make the gadget only request violation, warning and bad-parameters results, and only cache those. Then, announce a breaking change that we’ll change the default from * to those three statuses, so that all requests with the default value benefit from caching.

Lucas_Werkmeister_WMDE moved this task from Backlog to In Progress on the Wikidata-Sprint-2018-01-03 board.Jan 11 2018, 5:58 PM
gerritbot subscribed.Jan 12 2018, 5:48 PM

Change 403966 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add $statuses parameter to ResultsBuilder::getResults

https://gerrit.wikimedia.org/r/403966

gerritbot added a project: Patch-For-Review.Jan 12 2018, 5:48 PM

Change 403967 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add status parameter to CheckConstraints

https://gerrit.wikimedia.org/r/403967

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 12 2018, 5:50 PM
Lucas_Werkmeister_WMDE moved this task from In Progress to Review on the Wikidata-Sprint-2018-01-03 board.
Lucas_Werkmeister_WMDE added a parent task: T184812: Enable constraint result caching on Wikidata.Jan 12 2018, 5:56 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 12 2018, 6:34 PM
gerritbot added a comment.Jan 15 2018, 4:47 PM

Change 403966 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add $statuses parameter to ResultsBuilder::getResults

https://gerrit.wikimedia.org/r/403966

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 15 2018, 5:00 PM
Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2018-01-03 board.Jan 15 2018, 5:14 PM
gerritbot added a comment.Jan 15 2018, 5:16 PM

Change 403967 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add status parameter to CheckConstraints

https://gerrit.wikimedia.org/r/403967

Lucas_Werkmeister_WMDE mentioned this in T184937: Change wbcheckconstraints’ status parameter’s default value to cacheable value.Jan 15 2018, 5:17 PM
WMDE-leszek renamed this task from Add parameter to only get violations from wbcheckconstraints to Add parameter to only get violations from wbcheckconstraints (days: 1).Jan 15 2018, 5:23 PM
gerritbot added a comment.Jan 15 2018, 5:26 PM

Change 404322 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add status parameter to gadget’s API requests

https://gerrit.wikimedia.org/r/404322

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 15 2018, 5:26 PM
Lucas_Werkmeister_WMDE moved this task from Done to Review on the Wikidata-Sprint-2018-01-03 board.
Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2018-01-03 board.Jan 15 2018, 5:47 PM
gerritbot added a comment.Jan 15 2018, 5:52 PM

Change 404322 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add status parameter to gadget’s API requests

https://gerrit.wikimedia.org/r/404322

gerritbot added a comment.Jan 15 2018, 6:15 PM

Change 404326 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix status parameter documentation

https://gerrit.wikimedia.org/r/404326

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 15 2018, 6:15 PM
Lucas_Werkmeister_WMDE moved this task from Done to Review on the Wikidata-Sprint-2018-01-03 board.
Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 16 2018, 11:00 AM
Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2018-01-03 board.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
gerritbot added a comment.Jan 16 2018, 11:05 AM

Change 404326 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Fix status parameter documentation

https://gerrit.wikimedia.org/r/404326

Lucas_Werkmeister_WMDE closed subtask T185104: status parameter removes too many results as Invalid.Jan 17 2018, 2:48 PM
Lucas_Werkmeister_WMDE closed subtask T184937: Change wbcheckconstraints’ status parameter’s default value to cacheable value as Resolved.Feb 26 2018, 8:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL