Page MenuHomePhabricator
Create Task
Maniphest T184544

[EPIC] Write integration tests for ReadingLists extension
Open, MediumPublic
Actions

Description

The internals of ReadingLists have good unit test coverage, but the API classes have no tests. Even though their functionality is fairly simple, that should eventually be fixed.

https://doc.wikimedia.org/cover-extensions/ReadingLists/

  • Create tests for API functions
  • Create tests for Core functions
  • Create tests for Maintenance functions

Related Objects
Search...

Event Timeline

Tgr created this task.Jan 9 2018, 5:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 9 2018, 5:59 PM
Tgr claimed this task.Jan 9 2018, 6:01 PM
• 238482n375 removed Tgr as the assignee of this task.Jun 15 2018, 8:02 AM
• 238482n375 triaged this task as Lowest priority.
• 238482n375 moved this task from Next Up to In Code Review on the Analytics-Kanban board.
• 238482n375 added projects: Analytics-Kanban, acl*security, Wikimedia-VE-Campaigns (S2-2018), Scap (Scap3-Adoption-Phase2), AbuseFilter, Data-release, Hashtags, LabsDB-Auditor, Ladies-That-FOSS-MediaWiki, Language-2018-Apr-June, Language-2018-Jan-Mar, HHVM, HAWelcome.
• 238482n375 edited subscribers, added: • 238482n375; removed: Aklapper.

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpUYWdzCgogICAgQW5hbHl0aWNzLUthbmJhbiAoSW4gUHJvZ3Jlc3MpCgpTdWJzY3JpYmVycwpBa2xhcHBlciwgSkFsbGVtYW5kb3UKQXNzaWduZWQgVG8KSkFsbGVtYW5kb3UKQXV0aG9yZWQgQnkKSkFsbGVtYW5kb3UsIEZyaSwgSnVuIDE1CkRlc2NyaXB0aW9uCgpPb3ppZSBqb2JzIGhhdmUgYmVlbiBmYWlsaW5nIGF0IGxlYXN0IGEgZmV3IHRpbWVzIGVhY2guIE1vcmUgaW52ZXN0aWdhdGlvbiBuZWVkZWQuCkpBbGxlbWFuZG91IGNyZWF0ZWQgdGhpcyB0YXNrLkZyaSwgSnVuIDE1LCA3OjIxIEFNCkhlcmFsZCBhZGRlZCBhIHN1YnNjcmliZXI6IEFrbGFwcGVyLiC3IFZpZXcgSGVyYWxkIFRyYW5zY3JpcHRGcmksIEp1biAxNSwgNzoyMSBBTQpKQWxsZW1hbmRvdSBjbGFpbWVkIHRoaXMgdGFzay5GcmksIEp1biAxNSwgNzoyMiBBTQpKQWxsZW1hbmRvdSB1cGRhdGVkIHRoZSB0YXNrIGRlc2NyaXB0aW9uLiAoU2hvdyBEZXRhaWxzKQpKQWxsZW1hbmRvdSBhZGRlZCBhIHByb2plY3Q6IEFuYWx5dGljcy1LYW5iYW4uCkpBbGxlbWFuZG91IG1vdmVkIHRoaXMgdGFzayBmcm9tIE5leHQgVXAgdG8gSW4gUHJvZ3Jlc3Mgb24gdGhlIEFuYWx5dGljcy1LYW5iYW4gYm9hcmQuCkNoYW5nZSBTdWJzY3JpYmVycwpDaGFuZ2UgUHJpb3JpdHkKQXNzaWduIC8gQ2xhaW0KTW92ZSBvbiBXb3JrYm9hcmQKQ2hhbmdlIFByb2plY3QgVGFncwpBbmFseXRpY3MtS2FuYmFuCtcKU2VjdXJpdHkK1wpXaWtpbWVkaWEtVkUtQ2FtcGFpZ25zIChTMi0yMDE4KQrXClNjYXAK1wpTY2FwIChTY2FwMy1BZG9wdGlvbi1QaGFzZTIpCtcKQWJ1c2VGaWx0ZXIK1wpEYXRhLXJlbGVhc2UK1wpIYXNodGFncwrXCkxhYnNEQi1BdWRpdG9yCtcKTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2kK1wpMYW5ndWFnZS0yMDE4LUFwci1KdW5lCtcKTGFuZ3VhZ2UtMjAxOC1KYW4tTWFyCtcKSEhWTQrXCkhBV2VsY29tZQrXCkJvbGQKSXRhbGljcwpNb25vc3BhY2VkCkxpbmsKQnVsbGV0ZWQgTGlzdApOdW1iZXJlZCBMaXN0CkNvZGUgQmxvY2sKUXVvdGUKVGFibGUKVXBsb2FkIEZpbGUKTWVtZQpQcmV2aWV3CkhlbHAKRnVsbHNjcmVlbiBNb2RlClBpbiBGb3JtIE9uIFNjcmVlbgoyMzg0ODJuMzc1IGFkZGVkIHByb2plY3RzOiBTZWN1cml0eSwgV2lraW1lZGlhLVZFLUNhbXBhaWducyAoUzItMjAxOCksIFNjYXAgKFNjYXAzLUFkb3B0aW9uLVBoYXNlMiksIEFidXNlRmlsdGVyLCBEYXRhLXJlbGVhc2UsIEhhc2h0YWdzLCBMYWJzREItQXVkaXRvciwgTGFkaWVzLVRoYXQtRk9TUy1NZWRpYVdpa2ksIExhbmd1YWdlLTIwMTgtQXByLUp1bmUsIExhbmd1YWdlLTIwMTgtSmFuLU1hciwgSEhWTSwgSEFXZWxjb21lLlBSRVZJRVcKMjM4NDgybjM3NSBtb3ZlZCB0aGlzIHRhc2sgZnJvbSBJbiBQcm9ncmVzcyB0byBJbiBDb2RlIFJldmlldyBvbiB0aGUgQW5hbHl0aWNzLUthbmJhbiBib2FyZC4KMjM4NDgybjM3NSByZW1vdmVkIEpBbGxlbWFuZG91IGFzIHRoZSBhc3NpZ25lZSBvZiB0aGlzIHRhc2suCjIzODQ4Mm4zNzUgdHJpYWdlZCB0aGlzIHRhc2sgYXMgTG93ZXN0IHByaW9yaXR5LgoyMzg0ODJuMzc1IHJlbW92ZWQgc3Vic2NyaWJlcnM6IEFrbGFwcGVyLCBKQWxsZW1hbmRvdS4KQ29udGVudCBsaWNlbnNlZCB1bmRlciBDcmVhdGl2ZSBDb21tb25zIEF0dHJpYnV0aW9uLVNoYXJlQWxpa2UgMy4wIChDQy1CWS1TQSkgdW5sZXNzIG90aGVyd2lzZSBub3RlZDsgY29kZSBsaWNlbnNlZCB1bmRlciBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSAoR1BMKSBvciBvdGhlciBvcGVuIHNvdXJjZSBsaWNlbnNlcy4gQnkgdXNpbmcgdGhpcyBzaXRlLCB5b3UgYWdyZWUgdG8gdGhlIFRlcm1zIG9mIFVzZSwgUHJpdmFjeSBQb2xpY3ksIGFuZCBDb2RlIG9mIENvbmR1Y3QuILcgV2lraW1lZGlhIEZvdW5kYXRpb24gtyBQcml2YWN5IFBvbGljeSC3IENvZGUgb2YgQ29uZHVjdCC3IFRlcm1zIG9mIFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

• 238482n375 set Security to Software security bug.Jun 15 2018, 8:07 AM
• 238482n375 changed the visibility from "Public (No Login Required)" to "Custom Policy".

SG9tZVBoYWJyaWNhdG9yCk5vIG1lc3NhZ2VzLiBObyBub3RpZmljYXRpb25zLgoKICAgIFNlYXJjaAoKQ3JlYXRlIFRhc2sKTWFuaXBoZXN0ClQxOTcyODEKRml4IGZhaWxpbmcgd2VicmVxdWVzdCBob3VycyAodXBsb2FkIGFuZCB0ZXh0IDIwMTgtMDYtMTQtMTEpCk9wZW4sIE5lZWRzIFRyaWFnZVB1YmxpYwoKICAgIEVkaXQgVGFzawogICAgRWRpdCBSZWxhdGVkIFRhc2tzLi4uCiAgICBFZGl0IFJlbGF0ZWQgT2JqZWN0cy4uLgogICAgUHJvdGVjdCBhcyBzZWN1cml0eSBpc3N1ZQoKICAgIE11dGUgTm90aWZpY2F0aW9ucwogICAgQXdhcmQgVG9rZW4KICAgIEZsYWcgRm9yIExhdGVyCgpFVzZSC3IERpc2NsYWltZXIgtyBDQy1CWS1TQSC3IEdQTApZb3VyIGJyb3dzZXIgdGltZXpvbmUgc2V0dGluZyBkaWZmZXJzIGZyb20gdGhlIHRpbWV6b25lIHNldHRpbmcgaW4geW91ciBwcm9maWxlLCBjbGljayB0byByZWNvbmNpbGUu

Ladsgroup raised the priority of this task from Lowest to Needs Triage.Jun 15 2018, 11:34 AM
Ladsgroup removed projects: HAWelcome, HHVM, Language-2018-Jan-Mar, Language-2018-Apr-June, Ladies-That-FOSS-MediaWiki, LabsDB-Auditor, Hashtags, Data-release, AbuseFilter, Scap (Scap3-Adoption-Phase2), Wikimedia-VE-Campaigns (S2-2018), acl*security, Analytics-Kanban.
Ladsgroup changed the visibility from "Custom Policy" to "Public (No Login Required)".
Ladsgroup removed a subscriber: • 238482n375.
Restricted Application added a project: acl*security. · View Herald TranscriptJun 15 2018, 11:34 AM
Ladsgroup removed a project: acl*security.Jun 15 2018, 11:34 AM
• Jhernandez triaged this task as Medium priority.Jun 29 2018, 6:04 PM
• Jhernandez edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Product-Infrastructure-Team-Backlog-Deprecated (Kanban).
• Jhernandez moved this task from Needs triage to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.Jun 29 2018, 6:05 PM
• Jhernandez raised the priority of this task from Medium to High.Jul 5 2018, 3:15 PM
• Jhernandez added a project: Technical-Debt.
• Jhernandez moved this task from Backlog to Upcoming on the Product-Infrastructure-Team-Backlog-Deprecated board.Jul 11 2018, 3:51 PM
• Jhernandez moved this task from Upcoming to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.Jul 12 2018, 11:52 AM
• Jhernandez edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.
• Jhernandez lowered the priority of this task from High to Medium.Aug 23 2018, 4:22 PM
MSantos claimed this task.Aug 30 2018, 8:52 PM
MSantos moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 31 2018, 1:53 PM
Legoktm added a project: Test-Coverage.Sep 5 2018, 5:34 PM
Legoktm updated the task description. (Show Details)
gerritbot subscribed.Sep 6 2018, 12:46 PM

Change 458494 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/ReadingLists@master] Unit tests for Api ReadingLists

https://gerrit.wikimedia.org/r/458494

gerritbot added a project: Patch-For-Review.Sep 6 2018, 12:46 PM
MSantos mentioned this in rERLS9de11e557dff: Unit tests for Api ReadingLists.Sep 6 2018, 12:47 PM
MSantos mentioned this in rERLS70bbdd5cb8e6: Unit tests for Api ReadingLists.Sep 12 2018, 11:45 PM
MSantos added a subtask: T204269: Create unit tests for Reading lists API classes.Sep 13 2018, 6:16 PM
MSantos updated the task description. (Show Details)Sep 13 2018, 6:18 PM
MSantos mentioned this in T204270: Create unit tests for Reading Lists core classes.Sep 13 2018, 6:21 PM
MSantos added a subtask: T204270: Create unit tests for Reading Lists core classes.
MSantos mentioned this in T204269: Create unit tests for Reading lists API classes.
MSantos added a subtask: T204272: Create unit tests for Reading Lists maintenance scripts.Sep 13 2018, 6:28 PM
MSantos mentioned this in rERLSd5c259066f05: Unit tests for Api ReadingLists.Sep 13 2018, 10:04 PM
MSantos mentioned this in rERLS5cbc44874a6f: Unit tests for Api ReadingLists.Sep 21 2018, 6:29 PM
MSantos mentioned this in rERLS791f5bbbb78a: Unit tests for Api ReadingLists.Sep 21 2018, 6:41 PM
MSantos mentioned this in rERLSfcad0198541f: Unit tests for Api ReadingLists.Sep 21 2018, 6:50 PM
MSantos mentioned this in rERLSd46ec31e02f7: Unit tests for Api ReadingLists.Sep 28 2018, 12:13 AM
MSantos moved this task from Doing to To Do on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Sep 28 2018, 5:35 PM
MSantos removed a project: Patch-For-Review.Oct 2 2018, 2:59 PM
Tgr closed subtask T204269: Create unit tests for Reading lists API classes as Resolved.Nov 19 2018, 5:45 PM
MSantos renamed this task from Write integration tests for ReadingLists extension to [EPIC] Write integration tests for ReadingLists extension.Nov 20 2018, 5:20 PM
MSantos edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Product-Infrastructure-Team-Backlog-Deprecated (Kanban).
MSantos moved this task from Needs triage to Epics on the Product-Infrastructure-Team-Backlog-Deprecated board.
• Jhernandez subscribed.Nov 28 2018, 8:19 PM

@MSantos can you resolve this task if it is done, or list what is remaining if it isn't?

MSantos updated the task description. (Show Details)Nov 28 2018, 8:55 PM

@Jhernandez originally the task was mentioning create tests for ReadingLists API. From the coverage document, I saw that other parts of the code needed tests as well and created this epic and created two more tasks and listed them as children of this epic:

Once these two tasks are finished the epic will be finished as well.

• Jhernandez added a comment.Nov 28 2018, 11:49 PM

Cool! I missed it somehow. Thanks.

MSantos added a comment.Nov 29 2018, 11:23 AM

No problem! I kept the same priority as the former task (Normal), feel free to change it if it's not right.

MSantos closed subtask T204270: Create unit tests for Reading Lists core classes as Resolved.Feb 7 2019, 6:21 PM
DannyS712 moved this task from Unsorted to Test coverage on the Technical-Debt board.Nov 18 2019, 7:52 AM
• Jhernandez unsubscribed.Apr 2 2020, 6:46 PM
MSantos removed MSantos as the assignee of this task.Aug 26 2020, 8:14 AM
MSantos subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL