Add language to cache key for check results
Closed, ResolvedPublic
Actions

Description

Quick-and-dirty solution for T185688: Constraint check results are cached independent of language. I’m confident we can get this done in time for the next MediaWiki train (February 7th), so we can hopefully enable caching shortly after that.

Details

	Subject	Repo	Branch	Lines +/-
	Include user language in cache key	mediawiki/extensions/WikibaseQualityConstraints	master	+110 -7

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lucas_Werkmeister_WMDE	T173695 Enable constraint checks by default for users
Open	None	T103228 Improve performance of constraint check
Resolved	Lydia_Pintscher	T179839 Cache constraint check results
Resolved	Lydia_Pintscher	T179849 Cache all constraint check results per-entity
Resolved	Lucas_Werkmeister_WMDE	T181060 Cache constraint check results per-entity in ObjectCache (L) (days: 2)
Resolved	Lucas_Werkmeister_WMDE	T184812 Enable constraint result caching on Wikidata
Resolved	Lucas_Werkmeister_WMDE	T185688 Constraint check results are cached independent of language
Resolved	Lucas_Werkmeister_WMDE	T185689 Add language to cache key for check results

Event Timeline

Lucas_Werkmeister_WMDE triaged this task as Medium priority.Jan 25 2018, 12:36 PM

Lucas_Werkmeister_WMDE created this task.

Lucas_Werkmeister_WMDE moved this task from incoming to consider for next sprint on the Wikidata board.

Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-01-17.Jan 25 2018, 3:21 PM

Lucas_Werkmeister_WMDE moved this task from Backlog to In Progress on the Wikidata-Sprint-2018-01-17 board.

Lucas_Werkmeister_WMDE moved this task from consider for next sprint to in progress on the Wikidata board.

Change 406179 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Include user language in cache key

https://gerrit.wikimedia.org/r/406179

gerritbot added a project: Patch-For-Review.Jan 25 2018, 5:25 PM

Lucas_Werkmeister_WMDE moved this task from In Progress to Review on the Wikidata-Sprint-2018-01-17 board.Jan 25 2018, 5:29 PM

Change 406179 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Include user language in cache key

https://gerrit.wikimedia.org/r/406179

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 26 2018, 9:00 AM

Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 26 2018, 10:59 AM

Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2018-01-17 board.

Lucas_Werkmeister_WMDE mentioned this in T184812: Enable constraint result caching on Wikidata.Feb 23 2018, 1:42 PM

Lucas_Werkmeister_WMDE mentioned this in T185688: Constraint check results are cached independent of language.Mar 27 2018, 10:43 AM