[Config] Disable Page Previews EventLogging instrumentation
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• Tbayer
	Jan 30 2018, 12:41 AM

Description

In T181493, it had been envisaged to disable the latest experiment eight days after enabling it. This had to be postponed because of the Hive refinement issues that were discovered (T182000) and the holidays, but by now we should have a sufficient amount of non-corrupted data collected.

The process should be the same as last time: T178500: Stop sending data for Page Previews enwiki and dewiki A/B test (again); a configuration only change.

Developer notes

Per T178500#3728898, we'd prefer not to disable the feature for those logged-in users who currently have it enabled via their preferences. We'll keep the anonymous enabled rates the same but turn off event logging:

$wgPopupsEventLogging = false;

Testing / acceptance criteria

A logged in user can enable page previews.
No events are logged.

Details

	Subject	Repo	Branch	Lines +/-
	Disable Page Previews EventLogging instrumentation	operations/mediawiki-config	master	+0 -3

Customize query in gerrit

Related Objects

Mentioned In: T182314: Analyze results of enwiki and dewiki page previews a/b test
Mentioned Here: T182314: Analyze results of enwiki and dewiki page previews a/b test
T178500: Stop sending data for Page Previews enwiki and dewiki A/B test (again)
T181493: Enable Page Previews EventLogging instrumentation
T182000: Popups timestamp field contains multiple types

Event Timeline

• Tbayer created this task.Jan 30 2018, 12:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2018, 12:41 AM

Ping @ovasileva for prio

From discussion in grooming with @Tbayer

We have enough data, so it is up to us when to disable. Next week would be good, for example.

pmiazga set the point value for this task to 1.Jan 30 2018, 5:19 PM

Setting PopupsEventLogging to false seems to be what's needed

Jdlrobson added a project: Wikimedia-Site-requests.Jan 30 2018, 5:20 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.

@ovasileva: The FTEs identified this task as being ready to work on in the next iteration.

ovasileva triaged this task as Medium priority.Feb 1 2018, 4:25 PM

Jdlrobson updated the task description. (Show Details)Feb 1 2018, 10:32 PM

phuedx updated the task description. (Show Details)Feb 2 2018, 1:48 PM

MuhammadShuaib moved this task from Backlog to Working on on the Wikimedia-Site-requests board.Feb 4 2018, 12:13 PM

MuhammadShuaib moved this task from Backlog to Working on on the Wikimedia-Site-requests board.

• Niedzielski renamed this task from Disable Page Previews EventLogging instrumentation to [Config] Disable Page Previews EventLogging instrumentation.Feb 9 2018, 1:39 PM

• Niedzielski updated the task description. (Show Details)

@ovasileva Shouldn't this be in the sprint?

We can pull it in now, I was waiting to confirm that we didn't have a bug in T182314: Analyze results of enwiki and dewiki page previews a/b test, but it's looking like we're fairly confident

ovasileva moved this task from Upcoming to 2017-18 Q3 on the Web-Team-Backlog board.Feb 13 2018, 3:42 PM

• Tbayer mentioned this in T182314: Analyze results of enwiki and dewiki page previews a/b test.Feb 15 2018, 6:01 AM

ovasileva moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Feb 15 2018, 6:13 PM

pmiazga claimed this task.Feb 20 2018, 7:50 PM

Change 412996 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[operations/mediawiki-config@master] Disable Page Previews EventLogging instrumentation

https://gerrit.wikimedia.org/r/412996

gerritbot added a project: Patch-For-Review.Feb 20 2018, 8:10 PM

pmiazga moved this task from Needs Design Review to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Feb 20 2018, 8:10 PM

Change 412996 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable Page Previews EventLogging instrumentation

https://gerrit.wikimedia.org/r/412996

Mentioned in SAL (#wikimedia-operations) [2018-02-21T15:03:59Z] <zfilipin@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:412996|Disable Page Previews EventLogging instrumentation (T185973)]] (duration: 01m 13s)

pmiazga removed pmiazga as the assignee of this task.Feb 21 2018, 3:09 PM

pmiazga moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.

pmiazga removed a project: Patch-For-Review.

pmiazga subscribed.

Deployed to production. @phuedx, @Tbayer can you signoff?

https://grafana.wikimedia.org/dashboard/db/eventlogging-schema?orgId=1&var-schema=Popups&from=1519225439000&to=now LGTM 👍

[Config] Disable Page Previews EventLogging instrumentationClosed, ResolvedPublic1 Estimated Story PointsActions