Use the correct formatter when visualizing the lexical category difference in the lexeme diff
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WMDE-leszek
	Mar 14 2018, 1:09 PM

Description

Initial pointers:

Diff visualizing code is to be find around the following methods:

LexemeDiffVisualizer::visualizeEntityDiff
LexemeDiff::getLexicalCategoryDiff
LexemeDiff::lexicalCategory

The "correct" formatter seems to be the one that WikibaseRepo::getEntityIdHtmlLinkFormatterFactory returns

Details

	Subject	Repo	Branch	Lines +/-
	Format lexical category items in the lexeme diff	mediawiki/extensions/WikibaseLexeme	master	+507 -11

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T189187 Label not shown for lexical category and/or language edit diff of a Lexeme
		Resolved		WMDE-leszek	T189678 Use the correct formatter when visualizing the lexical category difference in the lexeme diff

Event Timeline

WMDE-leszek triaged this task as Medium priority.Mar 14 2018, 1:09 PM

WMDE-leszek created this task.

WMDE-leszek updated the task description. (Show Details)

WMDE-leszek mentioned this in T189679: Use the correct formatter when visualizing the language difference in the lexeme diff.Mar 14 2018, 1:12 PM

Lydia_Pintscher moved this task from incoming to other stuff on the Wikidata Lexicographical data board.Mar 15 2018, 11:45 AM

WMDE-leszek claimed this task.Mar 15 2018, 3:54 PM

WMDE-leszek moved this task from To Do to Doing on the Wikidata-Turtles-18.03.14 board.

Change 419819 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] [WIP] Format lexical category items in the lexeme diff

https://gerrit.wikimedia.org/r/419819

gerritbot added a project: Patch-For-Review.Mar 15 2018, 6:30 PM

WMDE-leszek mentioned this in rEWLE4f047d8419dc: [WIP] Format lexical category items in the lexeme diff.Mar 15 2018, 6:32 PM

WMDE-leszek mentioned this in rEWLEd861764cc151: [WIP] Format lexical category items in the lexeme diff.Mar 16 2018, 3:59 PM

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Mar 18 2018, 3:36 PM

WMDE-leszek mentioned this in rEWLEe34d87316b66: [WIP] Format lexical category items in the lexeme diff.Mar 19 2018, 4:44 PM

WMDE-leszek mentioned this in rEWLE0d16eccce6f7: [WIP] Format lexical category items in the lexeme diff.Mar 19 2018, 4:49 PM

WMDE-leszek mentioned this in rEWLEa890526310b6: Format lexical category items in the lexeme diff.Mar 19 2018, 6:14 PM

WMDE-leszek moved this task from Doing to Peer Review on the Wikidata-Turtles-18.03.14 board.Mar 19 2018, 6:28 PM

Addshore mentioned this in rEWLE61b05fc6bfa2: Format lexical category items in the lexeme diff.Mar 21 2018, 9:49 AM

Addshore mentioned this in rEWLEf0fbc314501f: Format lexical category items in the lexeme diff.Mar 21 2018, 11:04 AM

Addshore mentioned this in rEWLE06102eab1d8b: Format lexical category items in the lexeme diff.Mar 21 2018, 11:32 AM

Jakob_WMDE mentioned this in rEWLEa88074d4f709: Format lexical category items in the lexeme diff.Mar 21 2018, 1:07 PM

Jakob_WMDE mentioned this in rEWLEcd713f282f33: Format lexical category items in the lexeme diff.Mar 21 2018, 2:15 PM

• Pablo-WMDE mentioned this in rEWLEbc64d48a800e: Format lexical category items in the lexeme diff.Mar 21 2018, 3:15 PM

• Pablo-WMDE mentioned this in rEWLE9006e0d492cd: Format lexical category items in the lexeme diff.Mar 21 2018, 4:48 PM

Addshore mentioned this in rEWLE214317aef833: Format lexical category items in the lexeme diff.Mar 22 2018, 9:06 AM

Addshore mentioned this in rEWLE3ccdbafc651f: Format lexical category items in the lexeme diff.Mar 22 2018, 9:19 AM

• Pablo-WMDE mentioned this in rEWLE264365f01cce: Format lexical category items in the lexeme diff.Mar 22 2018, 9:45 AM

Jakob_WMDE mentioned this in rEWLE49967c2c99fd: Format lexical category items in the lexeme diff.Mar 22 2018, 11:05 AM

Change 419819 had a related patch set uploaded (by Jakob; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseLexeme@master] Format lexical category items in the lexeme diff

https://gerrit.wikimedia.org/r/419819

Jakob_WMDE mentioned this in rEWLE6fd5bae4ebd8: Format lexical category items in the lexeme diff.Mar 22 2018, 11:08 AM

Change 419819 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Format lexical category items in the lexeme diff

https://gerrit.wikimedia.org/r/419819

Jakob_WMDE moved this task from Peer Review to Done on the Wikidata-Turtles-18.03.14 board.Mar 26 2018, 11:13 AM

Jakob_WMDE closed this task as Resolved.Apr 3 2018, 10:02 AM