Page MenuHomePhabricator
Create Task
Maniphest T190921

Editing Lexeme: Hide GUI buttons w/o permission
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Do not initialize LexemeHeader widget when lexeme page is not editable.mediawiki/extensions/WikibaseLexememaster+181 -15
Introduce ViewFactoryFactory overridable by extensions.mediawiki/extensions/Wikibasemaster+146 -31
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pablo-WMDE triaged this task as Medium priority.Mar 28 2018, 11:21 AM
• Pablo-WMDE created this task.
• Pablo-WMDE removed the point value for this task.Mar 28 2018, 11:36 AM
Jakob_WMDE claimed this task.Apr 3 2018, 10:27 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Turtles-18.03.28 board.
Lydia_Pintscher moved this task from incoming to other stuff on the Wikidata Lexicographical data board.Apr 3 2018, 7:21 PM
gerritbot subscribed.Apr 4 2018, 10:46 AM

Change 423877 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Allow ReadModeViewFactory to be overridden by extensions.

https://gerrit.wikimedia.org/r/423877

gerritbot added a project: Patch-For-Review.Apr 4 2018, 10:46 AM
gerritbot added a comment.Apr 5 2018, 11:39 AM

Change 424275 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Do not initialize LexemeHeader widget when lexeme page is not editable.

https://gerrit.wikimedia.org/r/424275

Jakob_WMDE mentioned this in rEWLE494db727dad7: Do not initialize LexemeHeader widget when lexeme page is not editable..Apr 5 2018, 11:41 AM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Turtles-18.03.28 board.Apr 5 2018, 11:45 AM
WMDE-leszek moved this task from other stuff to Features/bugs for first release on the Wikidata Lexicographical data board.Apr 6 2018, 11:34 AM
WMDE-leszek moved this task from Features/bugs for first release to other stuff on the Wikidata Lexicographical data board.
gerritbot added a comment.Apr 6 2018, 2:50 PM

Change 423877 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce ViewFactoryFactory overridable by extensions.

https://gerrit.wikimedia.org/r/423877

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 6 2018, 3:01 PM
Jakob_WMDE mentioned this in rEWLE1b72516e5d23: Do not initialize LexemeHeader widget when lexeme page is not editable..Apr 6 2018, 3:25 PM
gerritbot added a comment.Apr 6 2018, 4:02 PM

Change 424275 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Do not initialize LexemeHeader widget when lexeme page is not editable.

https://gerrit.wikimedia.org/r/424275

WMDE-leszek moved this task from Peer Review to Test (Product Review) on the Wikidata-Turtles-18.03.28 board.Apr 6 2018, 4:37 PM
Lydia_Pintscher added a comment.Apr 9 2018, 3:05 PM

@Jakob_WMDE can you help me test this?

Lydia_Pintscher closed this task as Resolved.Apr 9 2018, 3:14 PM
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Turtles-18.03.28 board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL