Maniphest T191650

DropdownInputWidget (WikimediaUI theme) cuts off the bottom of characters
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Quiddity
	Apr 6 2018, 5:51 PM

Description

@Stryn reported that the bottom of some characters are cut off, e.g. g and [ and ] are most visibly affected in this screenshot. He's using Firefox 59.0.2 on Windows 10 with default font (Times New Roman).

I cannot reproduce this (on Firefox, Linux, with DejaVu Sans).

Details

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.29.4	mediawiki/core	master	+336 -58
	WikimediaUI theme: Tame cut-off letter issue	oojs/ui	master	+9 -8

Customize query in gerrit

Related Objects

Mentioned Here: T183534: AdvancedSearch placeholder text in IE slightly cut at the bottom

Event Timeline

Quiddity created this task.Apr 6 2018, 5:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2018, 5:51 PM

Stryn updated the task description. (Show Details)Apr 6 2018, 6:10 PM

When the page is not zoomed (100%)	When I zoom a little (110%) it shows correctly.

Rxy subscribed.Apr 6 2018, 8:25 PM

@Charlie_WMDE could reproduce it in the widget included in the AdvancedSearch extension ( Firefox Quantum 59.0.1 for Ubuntu)

Possibly also related: T183534: AdvancedSearch placeholder text in IE slightly cut at the bottom

line-height is explicitly set as for many other widgets. We could set it to normal, but that would result in probably a tad misaligned icons. Before doing this, I want to reproduce it myself. *Switches on an Windows 10 computer*

Volker_E triaged this task as Medium priority.May 28 2018, 10:00 PM

Volker_E triaged this task as Medium priority.

I've been able to reproduce this on Firefox/Windows 10.

Could this be fixed? It's annoying to see it every day in special:block....

Change 471902 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] WikimediaUI theme: Tame cut-off letter issue

https://gerrit.wikimedia.org/r/471902

gerritbot added a project: Patch-For-Review.Nov 6 2018, 2:19 AM

Screenshot with patch provided:

Volker_E renamed this task from OOUI\DropdownInputWidget cuts off the bottom of characters to DropdownInputWidget (WikimediaUI theme) cuts off the bottom of characters.Nov 6 2018, 2:28 AM

Volker_E moved this task from Backlog to Reviewing on the OOUI board.

Change 471902 merged by jenkins-bot:
[oojs/ui@master] WikimediaUI theme: Tame cut-off letter issue

https://gerrit.wikimedia.org/r/471902

Volker_E moved this task from Reviewing to OOUI-0.29.4 on the OOUI board.Nov 6 2018, 8:43 PM

Volker_E edited projects, added OOUI (OOUI-0.29.4); removed OOUI.

Volker_E closed this task as Resolved.Nov 7 2018, 12:31 AM

Volker_E claimed this task.

Volker_E removed a project: Patch-For-Review.

Volker_E removed a subscriber: gerritbot.

Change 472080 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.4

https://gerrit.wikimedia.org/r/472080

gerritbot added a project: Patch-For-Review.Nov 7 2018, 1:03 AM

Change 472080 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.4