Page MenuHomePhabricator
Create Task
Maniphest T194729

Allow Wikibase Entities to be stored in alternative slots [MCR]
Closed, ResolvedPublic
Actions

Description

With Multi-Content-Revisions, MediaWiki allows different kinds of content to be stored on the same page. To enable WikibaseMediaInfo to store MediaInfo entities on file description pages in an extra slot, alongside the wikitext description, Wikibase needs to be changed to use the new page update (T174038) and revision retrieval (T174024) interfaces.

In concrete terms, this means:

  1. Change WikiPageEntityStore to use the new storage facilities in core (RevisionStore and PageUpdater) instead of Revision.
    1. WikiPageEntityRevisionLookup::loadEntity should now use RevisionStore. loadEntityBlob() should no longer be needed, since RevisionStore supports cross-wiki revision loading. However, this has not bee tested in production, and may require a RevisionStoreFactory to be introduced.
    2. WikiPageEntityMetaDataLookup also needs to be changed to make use of the new DB schema (ideally avoiding any low level access or knowledge of the schema). In particular, selectRevisionInformationById() can no longer directly access the text table.
  2. Define and pass through configuration that specifies in which slot of which namespace a given entity type resides (instead of just specifying the namespace).

Details

Show related patches Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedJdforrester-WMFT194750 Deploy Structured Data on Commons baseline
ResolvedJdforrester-WMFT159708 Deploy WikibaseMediaInfo extension to production
ResolvedJdforrester-WMFT180981 Deploy WikibaseMediaInfo extension to beta
ResolvedCparleT200903 Have MediaInfo store its entities in an MCR slot on the associated file page
ResolvedAddshoreT194729 Allow Wikibase Entities to be stored in alternative slots [MCR]
ResolveddanielT174038 Initial implementation of MCR page update interface
ResolveddanielT198701 Create RevisionStoreFactory [MCR]
· · ·

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a project: Wikidata. · View Herald TranscriptMay 15 2018, 8:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
daniel mentioned this in T194730: Ensure that Wikibase data access to MediaInfo on file description pages works with MCR .May 15 2018, 8:43 AM
daniel added a parent task: T194750: Deploy Structured Data on Commons baseline .May 15 2018, 11:45 AM
CCicalese_WMF moved this task from Inbox to MCR-SDC File Caption Support - phase 2 on the Multi-Content-Revisions board.May 15 2018, 2:50 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2); removed Multi-Content-Revisions.
daniel added a subtask: T174038: Initial implementation of MCR page update interface.May 29 2018, 4:36 PM
daniel closed subtask T174038: Initial implementation of MCR page update interface as Resolved.Jun 14 2018, 1:39 PM
daniel reopened subtask T174038: Initial implementation of MCR page update interface as Open.Jun 19 2018, 1:36 PM
daniel closed subtask T174038: Initial implementation of MCR page update interface as Resolved.Jun 22 2018, 3:40 PM
daniel assigned this task to Addshore.Jun 26 2018, 3:22 PM
Restricted Application added a project: User-Addshore. · View Herald TranscriptJun 26 2018, 3:22 PM
gerritbot subscribed.Jun 27 2018, 9:06 AM

Change 442253 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] WIP DNM Use PageUpdater & RevisionStore in WikiPageEntityStore

https://gerrit.wikimedia.org/r/442253

gerritbot added a project: Patch-For-Review.Jun 27 2018, 9:06 AM
Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.Jun 27 2018, 11:33 AM
daniel added a comment.EditedJun 27 2018, 11:53 AM

Oh, this is missing the requirements for loading entities! I have updated the task description. I'm afraid the reading part needs more work.

daniel updated the task description. (Show Details)Jun 27 2018, 11:57 AM
gerritbot added a comment.Jun 27 2018, 12:17 PM

Change 442285 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] WIP Introduce RevisionStoreFactory

https://gerrit.wikimedia.org/r/442285

Ladsgroup moved this task from incoming to monitoring on the Wikidata board.Jun 28 2018, 3:38 PM
daniel mentioned this in T198467: Wikibase should handle old revisions with suppressed content gracefully..Jun 29 2018, 10:36 AM
gerritbot added a comment.Jun 29 2018, 2:42 PM

Change 442285 merged by jenkins-bot:
[mediawiki/core@master] Introduce RevisionStoreFactory & Tests

https://gerrit.wikimedia.org/r/442285

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 8:01 PM
• Vvjjkkii renamed this task from Allow Wikibase Entities to be stored in alternative slots [MCR] to 6xcaaaaaaa.Jul 1 2018, 1:09 AM
• Vvjjkkii removed Addshore as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: Addshore; removed: gerritbot, Aklapper.
daniel renamed this task from 6xcaaaaaaa to Allow Wikibase Entities to be stored in alternative slots [MCR].Jul 2 2018, 2:46 PM
daniel lowered the priority of this task from High to Medium.
daniel removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
daniel updated the task description. (Show Details)
Addshore added a comment.Jul 3 2018, 11:55 AM

I started work on this but now have no more time as I'll be working on Wikidata-Senses-Hike & Wikidata-Senses-Iteration1

I'll file some subtickets / tasks now regarding the state

Addshore added a comment.Jul 3 2018, 12:03 PM

The patch in Wikibase of https://gerrit.wikimedia.org/r/442253 is basically ready once T198701 is complete

Addshore moved this task from Back Burner 🏛️ to Watching 👀 on the User-Addshore board.Jul 3 2018, 12:04 PM
daniel moved this task from Backlog to In Progress on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.Jul 5 2018, 4:12 PM
CommunityTechBot renamed this task from Allow Wikibase Entities to be stored in alternative slots [MCR] to Allow Wikibase Entities to be stored in alternative slots [MCR].Jul 5 2018, 6:42 PM
CommunityTechBot assigned this task to Addshore.
CommunityTechBot raised the priority of this task from Medium to Needs Triage.
CommunityTechBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).
daniel moved this task from In Progress to Blocked on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.Jul 9 2018, 4:07 PM
daniel added a parent task: T159708: Deploy WikibaseMediaInfo extension to production.Jul 11 2018, 6:01 PM
daniel added a parent task: T180981: Deploy WikibaseMediaInfo extension to beta.
Jdforrester-WMF subscribed.Jul 19 2018, 3:27 PM
MarkTraceur added a subtask: T200903: Have MediaInfo store its entities in an MCR slot on the associated file page.Aug 1 2018, 1:48 PM
daniel added a comment.Aug 1 2018, 4:16 PM

The patches that are up for review at this point do not fully cover the necessary functionality. Most importantly, there is no code yet that allows different slots to be configured for storing certain types of entities.

gerritbot added a comment.Aug 2 2018, 5:37 PM

Change 450069 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@master] WIP MCR Allow alternative to be configured for entities

https://gerrit.wikimedia.org/r/450069

daniel closed subtask T198701: Create RevisionStoreFactory [MCR] as Resolved.Aug 2 2018, 5:50 PM
daniel moved this task from Blocked to Needs Review on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.
gerritbot added a comment.Aug 3 2018, 3:04 PM

Change 442253 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use PageUpdater & RevisionStore in Wikibase

https://gerrit.wikimedia.org/r/442253

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Aug 3 2018, 4:00 PM
daniel added a comment.Aug 5 2018, 6:53 PM

The change to WikiPageEntityRevisionLookup has been reverted, see T201194#4479699.

gerritbot added a comment.Aug 6 2018, 11:35 AM

Change 450541 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Wikibase@master] Use PageUpdater & RevisionStore in Wikibase

https://gerrit.wikimedia.org/r/450541

daniel mentioned this in T201194: Beta cluster: Call to undefined method WikitextContent::getEntity() in /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php on line 189.Aug 6 2018, 12:28 PM
daniel claimed this task.Aug 6 2018, 4:48 PM
Jdforrester-WMF removed a subtask: T200903: Have MediaInfo store its entities in an MCR slot on the associated file page.Aug 14 2018, 9:32 PM
Jdforrester-WMF added a parent task: T200903: Have MediaInfo store its entities in an MCR slot on the associated file page.
gerritbot added a comment.Aug 16 2018, 2:32 PM

Change 450541 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use PageUpdater & RevisionStore in Wikibase

https://gerrit.wikimedia.org/r/450541

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 16 2018, 3:00 PM
gerritbot added a comment.Aug 17 2018, 2:51 PM

Change 450069 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Allow alternative slots to be configured for entities

https://gerrit.wikimedia.org/r/450069

daniel closed this task as Resolved.Aug 20 2018, 10:03 AM
Addshore moved this task from Watching 👀 to Closing ✔️ on the User-Addshore board.Aug 20 2018, 3:17 PM
CCicalese_WMF moved this task from Needs Review to Blocked on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.Aug 20 2018, 4:28 PM
CCicalese_WMF moved this task from Blocked to Done on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.
CCicalese_WMF removed a project: Patch-For-Review.Aug 25 2018, 12:59 PM
gerritbot added a comment.Sep 21 2018, 11:10 AM

Change 461415 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] MCR: If a revision doesn't have our role, it doesn't have our entity

https://gerrit.wikimedia.org/r/461415

gerritbot added a project: Patch-For-Review.Sep 21 2018, 11:10 AM
gerritbot added a comment.Sep 21 2018, 12:31 PM

Change 461436 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] WIP Fix WikiPageEntityMetaDataLookup::getWhere for MCR

https://gerrit.wikimedia.org/r/461436

daniel reopened this task as Open.Sep 21 2018, 12:31 PM
daniel reassigned this task from daniel to Addshore.

Re-opening, since issues were found. To be concrete, entities can be stored in extra slots, but Wikibase gets confused when finding a page that exists, could have an entity in an auxiliary slot, but doesn't. Adam is working on it.

CCicalese_WMF moved this task from Done to In Progress on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.Sep 24 2018, 5:00 PM
gerritbot added a comment.Sep 25 2018, 12:18 PM

Change 461415 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] MCR: If a revision doesn't have our role, it doesn't have our entity

https://gerrit.wikimedia.org/r/461415

gerritbot added a comment.Sep 26 2018, 11:35 AM

Change 462929 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] MCR: Add SlotRoleStore to PerRepositoryServiceContainer

https://gerrit.wikimedia.org/r/462929

gerritbot added a comment.Sep 27 2018, 3:31 PM

Change 463290 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] MCR: Create & Use TypeDispatchingWikiPageEntityMetaDataAccessor

https://gerrit.wikimedia.org/r/463290

Jdforrester-WMF edited projects, added Structured Data Engineering; removed SDC General.Sep 27 2018, 10:12 PM
Jdforrester-WMF moved this task from To Do to Monitoring on the Structured Data Engineering board.Sep 27 2018, 10:12 PM
gerritbot added a comment.Sep 28 2018, 11:11 AM

Change 462929 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] MCR: Add SlotRoleStore to PerRepositoryServiceContainer

https://gerrit.wikimedia.org/r/462929

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)); removed MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Sep 28 2018, 12:00 PM
gerritbot added a comment.Sep 28 2018, 3:56 PM

Change 463290 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] MCR: Create & Use TypeDispatchingWikiPageEntityMetaDataAccessor

https://gerrit.wikimedia.org/r/463290

Addshore added a comment.Oct 1 2018, 9:02 AM

All of the patches are now up, the final one of the chain currently being https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/461967/

gerritbot added a comment.Oct 1 2018, 10:39 AM

Change 463724 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] WIP DNM MCR: Introduce PageTableEntityConditionGenerator

https://gerrit.wikimedia.org/r/463724

gerritbot added a comment.Oct 1 2018, 10:39 AM

Change 461967 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] MCR: Adjust how we work with EDIT_NEW/UPDATE for MCR

https://gerrit.wikimedia.org/r/461967

gerritbot added a comment.Oct 1 2018, 5:19 PM

Change 463798 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] WIP DNM MCR: Fix EntitySavingHelper for MCR

https://gerrit.wikimedia.org/r/463798

gerritbot added a comment.Oct 2 2018, 9:43 AM

Change 461436 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix WikiPageEntityMetaDataLookup::getWhere for MCR

https://gerrit.wikimedia.org/r/461436

gerritbot added a comment.Oct 2 2018, 10:33 AM

Change 461967 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] MCR: Adjust how we work with EDIT_NEW/UPDATE for MCR

https://gerrit.wikimedia.org/r/461967

gerritbot added a comment.Oct 9 2018, 1:05 PM

Change 463724 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] MCR: Introduce PageTableEntityQuery & Implementation

https://gerrit.wikimedia.org/r/463724

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)); removed MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Oct 9 2018, 2:00 PM
Jdforrester-WMF removed a project: Patch-For-Review.Oct 9 2018, 4:29 PM

Resolved?

Addshore closed this task as Resolved.Oct 29 2018, 5:16 PM
gerritbot added a comment.Nov 15 2018, 3:38 PM

Change 463798 abandoned by Addshore:
WIP DNM MCR: Fix EntitySavingHelper for MCR

https://gerrit.wikimedia.org/r/463798

greg added a project: Multimedia.Mar 7 2019, 10:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL