| Volker_E | |
| May 16 2018, 10:57 PM |
| F18506968: image.png | |
| May 24 2018, 12:19 PM |
| F18492826: image.png | |
| May 23 2018, 4:43 PM |
| F18492837: image.png | |
| May 23 2018, 4:43 PM |
| F18308345: image.png | |
| May 16 2018, 10:57 PM |
| F18308341: image.png | |
| May 16 2018, 10:57 PM |
| F18308348: image.png | |
| May 16 2018, 10:57 PM |
| F18308335: image.png | |
| May 16 2018, 10:57 PM |
| F18308343: image.png | |
| May 16 2018, 10:57 PM |
As of v0.27.0 the (keyboard) focus appearance of TabSelectWidget is a bit disruptive and not overly clear, distinguishly visible on OOUI-fied Special:Preferences T117781.
Let's put the focus on the TabOptionWidget instead:
| theme | before | after (proposed) |
| WikimediaUI |  |  |
| Apex |  |  |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| themes: Clarify and align focus on TabselectWidget's selected tab | oojs/ui | master | +33 -5 |
Change 433494 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] themes: Clarify and align focus on TabselectWidget's selected tab
Change 433494 merged by jenkins-bot:
[oojs/ui@master] themes: Clarify and align focus on TabselectWidget's selected tab
Final implementation:
It was not clear to me when I saw this that the item with the blue bar is focussed, rather than just selected. I would expect a "ring" or border around the entire item, like we do for everything else.
@matmarex That seemed to strong of a treatment in this case. Although I understand the sentiment when only looking at the static screenshot, I don't think it's a real issue when you look for the focus in movement (disconnected, but also in comparison to our inconsitencies on focus styles elsewhere, this seems like an improvement).
@matmarex I forget to mention an important differentiation in this widget regarding nteraction patterns: Users can't focus the other tabs without it being selected, so changing the focus and selection goes hand-in-hand and you've got the selected white background I'm WikimediaUI. If we offer in future for users to focus tabs and in a next step actively selecting them, we might need to reevaluate the focus appearance as well again.
