Page MenuHomePhabricator
Create Task
Maniphest T180538

Improve Special:Preferences UI/UX
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Jdforrester-WMF
Nov 14 2017, 11:04 PM
Tags
Referenced Files
F18170964: Hovering over select menu gives an disabled effect - doesn't invit users to change it.png
May 11 2018, 6:08 PM
F18169673: describe the empty text box with placeholder text, conveying format of offset.png
May 11 2018, 5:59 PM
F18170360: Screenshot from 2018-05-11 23-07-09.png
May 11 2018, 5:59 PM
F18170363: Screenshot from 2018-05-11 23-07-28.png
May 11 2018, 5:59 PM
F18170391: Screenshot from 2018-05-11 23-16-18.png
May 11 2018, 5:59 PM
F18169665: missing right border of highlight of select box, 'sample' link broken.png
May 11 2018, 5:59 PM
F18169656: What's the 'disabled' supposed to mean.png
May 11 2018, 5:59 PM
F18169686: name and values should be distinguished. names-don't change, values-change.png
May 11 2018, 5:59 PM
View All 22 Files
Subscribers
Akhilam513
Aklapper
Dvorapa
Esanders
gerritbot
Iniquity
Jdforrester-WMF
View All 21 Subscribers
Tokens
"Orange Medal" token, awarded by Krinkle.

Description

OOUIification

The following are blockers from product, design & technology point of view

Bugs
General issues
“User profile”
  • Layout of the read-only "basic information" section is poor (and the DOM is not good for screen readers).
“Appearance“

Other issues

These are not blockers to switching to OOUI, but should get done at some point.

General issues
“User profile”

T203727: Restructure and improve 'Basic information' section: not prioritized

“Appearance“
Non-JS issues
“Recent changes”
"Beta features"

T194531: Special:Preferences: For JS-requiring features, re-use the styling that Beta Features invented and show a red warning but only to non-JS users : not prioritized

"Special:GlobalPreferences"

Details

SubjectRepoBranchLines +/-
Special:Preference: Check for changes before enabling Save buttonmediawiki/coremaster+4 -6
Revert "Special:Preferences: Use OOjs UI" and follow-upsmediawiki/coremaster+216 -295
Revert "Special:Preferences: Use OOjs UI" and follow-upsmediawiki/corewmf/1.31.0-wmf.10+216 -295
mw.special.preferences: Make the "Basic information" section more compactmediawiki/coremaster+15 -0
Preferences: Improve visual appearance by “unboxing” sectionsmediawiki/coremaster+16 -5
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT64559 Redesign Special:Preferences (tracking)
ResolvedVolker_ET180538 Improve Special:Preferences UI/UX
ResolvedmatmarexT180643 Altering radios doesn't make “Save” action available
ResolvedJdforrester-WMFT180710 On the "Watchlist" preferences panel, don't show the user's watchlist token; instead just link to Special:ResetTokens
ResolvedNoneT181433 Widen / tweak the "Time zone" user preference to work in languages with longer labels
ResolvedmatmarexT181112 Sort skins by their ID and default position, not by their localised name
ResolvedVolker_ET194524 Special:Preferences: Describe the empty text box ("Other timezone") with some placeholder text
InvalidNoneT194532 Special:Preferences: What's '(disabled)' supposed to mean in "E-mail me when a page on my watchlist is changed (disabled)"
DeclinedNoneT194533 Special:Preferences: rename the field titled "Signature" to "Signature/Nickname"
ResolvedVolker_ET198959 Beta Features SVG `img` elements miss `alt` attribute
ResolvedVolker_ET199205 Beta Features `.mw-ui-feature-user-count` doesn't conform to WCAG level AA
ResolvedVolker_ET117781 Convert Special:Preferences to OOUI
ResolvedMooeypooT186842 Convert Special:GlobalPreferences to OOUI
ResolvedNoneT34811 Direct link to a setting in Special:Preferences
DuplicateNoneT204093 Move Preferences Email options to Notifications tab
ResolvedVolker_ET204861 Reconsider keyboard user navigation hint exposure
ResolvedVolker_ET205629 Tooltip icons looks misaligned when close to checkboxes in Special:Preferences
ResolvedEsandersT205866 Make save button more visible on Special:Preferences
ResolvedVolker_ET208837 There should be a difference between section header and bold text in preferences
OpenNoneT211204 Selecting an element using its id should highlight the element
OpenNoneT204111 Language widget on Special:Preferences is slow to load
· · ·

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdforrester-WMF closed subtask T203202: Beta features tab lead message in Special:Preferences doesn't play nicely with OOUI as Resolved.Sep 4 2018, 7:15 PM
matmarex added a comment.Sep 6 2018, 11:10 PM

I think these of the remaining tasks should be blockers to switching the default mode to OOUI:

Jdforrester-WMF updated the task description. (Show Details)Sep 7 2018, 12:19 AM
Esanders subscribed.EditedSep 7 2018, 9:46 AM

I noted earlier that changing a dropdown didn't enable the save button until I focused it again.

Update: This only happens if you blur the dropdown by clicking outside of the form.

Update²: Filed as T203825

matmarex added a subscriber: Mooeypoo.EditedSep 7 2018, 5:36 PM

@Jdforrester-WMF @matmarex @Volker_E @Mooeypoo @Esanders talked about the blockers here. Conclusions, as I understood them:

Volker_E updated the task description. (Show Details)Sep 7 2018, 5:42 PM
Volker_E added a subtask: T34811: Direct link to a setting in Special:Preferences.Sep 7 2018, 6:03 PM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)Sep 7 2018, 6:06 PM
Volker_E added a subtask: T203838: Lazy infuse OOUI widgets on Special:Preferences.Sep 7 2018, 7:06 PM
Volker_E updated the task description. (Show Details)
matmarex added a subtask: T203825: Save not enabled when changing dropdown in OOUI special:preferences.Sep 7 2018, 8:46 PM
matmarex closed subtask T203825: Save not enabled when changing dropdown in OOUI special:preferences as Resolved.
Volker_E updated the task description. (Show Details)Sep 8 2018, 12:03 AM
Volker_E added a project: Design.Sep 8 2018, 12:07 AM
Volker_E updated the task description. (Show Details)Sep 8 2018, 1:13 AM
Paladox subscribed.Sep 8 2018, 1:13 AM
Volker_E closed subtask T195986: FOUC in OOUIfied Special:Preferences as Resolved.Sep 11 2018, 8:51 PM
Esanders added a comment.Sep 11 2018, 8:54 PM

@Volker_E I think the blocking parts of T181844 are done.

Volker_E updated the task description. (Show Details)Sep 11 2018, 8:57 PM
Esanders added a comment.Sep 11 2018, 9:06 PM
In T180538#4567383, @matmarex wrote:
  • Changing a dropdown didn't enable the save button – blocker, task to be filed by @Esanders, @matmarex will work on it

Filed as T203825

  • Improve page load time by lazy-loading some widgets – blocker, task to be filed by ?????, @matmarex will work on it

Filed as T203838

Trizek-WMF added a subtask: T204093: Move Preferences Email options to Notifications tab.Sep 11 2018, 10:51 PM
Aklapper added a parent task: T64559: Redesign Special:Preferences (tracking).Sep 12 2018, 8:52 AM
Esanders closed subtask T203838: Lazy infuse OOUI widgets on Special:Preferences as Resolved.Sep 12 2018, 9:58 AM
Volker_E updated the task description. (Show Details)Sep 12 2018, 3:17 PM
matmarex closed subtask T181844: Adjust UI elements for number entry on Preferences tabs for Recent Changes and Watchlist as Resolved.Sep 12 2018, 10:17 PM
Volker_E updated the task description. (Show Details)Sep 12 2018, 10:19 PM
Volker_E updated the task description. (Show Details)Sep 12 2018, 10:46 PM
Volker_E mentioned this in T203992: Random italicized text under Reading preferences section on Special: Preferences > Appearance tab.Sep 13 2018, 8:03 PM
Dvorapa added a comment.EditedSep 18 2018, 10:53 AM

What about these:
T53941: Merge "Recent changes" and "Watchlist" preferences tabs
T65578: Move Echo's user preferences to "Notifications" core user preferences tab
T65580: Change "Date format" part of "Appearance" user preferences into a drop-down menu
T65987: Change "Basic information" section of Special:Preferences into "Account management"
T65577: Create a "Watching and notifications" tab in MediaWiki core
T68965: Have watchlist email setting in "Notifications" tab in Special:Preferences
T20524: Preferences: unify filter options of recent changes, new pages, watchlist, recent changes linked
Should we solve any of these together with this major change?

Volker_E added a comment.Sep 18 2018, 4:47 PM

@Dvorapa Thanks for pointing those out.
Apart from T65987#4594520 where I've commented just now, other ones are either possibly more complex refactorings and/or in need for further user testing and are not blockers for the important OOUI transformation task T117781. Nonetheless, work on subtasks here will continue, for example on T203727 or T203992.

Izno removed a subtask: T195986: FOUC in OOUIfied Special:Preferences.Sep 18 2018, 10:20 PM
Izno removed a subtask: T203838: Lazy infuse OOUI widgets on Special:Preferences.
Izno removed a subtask: T192769: Special:Preferences: OOUI tabs cause a FOUC because the PHP side doesn't hack in their HTML, unlike the non-OOUI tabs.Sep 18 2018, 10:34 PM
Izno removed a subtask: T203202: Beta features tab lead message in Special:Preferences doesn't play nicely with OOUI.
Izno removed a subtask: T203825: Save not enabled when changing dropdown in OOUI special:preferences.
Izno removed a subtask: T148030: OOUI indexed dialogs (IndexLayout) / tabbed navigation (TabPanelLayout) is not accessible.Sep 18 2018, 10:37 PM
Izno removed a subtask: T194535: Special:Preferences-OOUI: distinguish titles and the values .
Izno removed a subtask: T181698: Headings of sections on "Gadgets" tab on Special:Preferences display escaped HTML after OOUI conversion.
Izno removed a subtask: T180535: Don't duplicate fieldset elements in OOUI HTMLForm output.
Izno removed a subtask: T181733: MediaWiki:Gadgets-prefstext not wrapped in OOUI form in Special:Preferences.Sep 18 2018, 10:42 PM
Izno removed a subtask: T181430: Page Preview preference label newline causes odd display.
Izno removed a subtask: T181770: Apex theme: Too much vertical space between form fields (Special:Preferences/MonoBook).Sep 18 2018, 10:45 PM
Izno removed a subtask: T181844: Adjust UI elements for number entry on Preferences tabs for Recent Changes and Watchlist.
Izno removed a subtask: T180709: CirrusSearch "Completion suggester " feature inserts raw options into the Search preferences panel, so they look unlike all the others.Sep 18 2018, 10:49 PM
Izno removed a subtask: T181691: [Pre-wmf.11] Special:Preferences asks for leave confirmation even when no changes were made.
Izno removed a subtask: T198499: Visual grouping of preferences sections needs improvement.Sep 18 2018, 10:52 PM
Volker_E updated the task description. (Show Details)Sep 19 2018, 7:16 PM
xSavitar subscribed.Sep 21 2018, 4:56 PM
Jdforrester-WMF closed subtask T117781: Convert Special:Preferences to OOUI as Resolved.Sep 27 2018, 1:01 AM
Izno removed a subtask: T194525: Special:Preferences: Reduce the size of the <textarea>s shown for UsersMultiselectWidget when in non-JS mode.Sep 27 2018, 1:23 PM
Izno removed a subtask: T198875: `id="mw-htmlform-opt-out"` occuring twice in DOM.
matmarex closed subtask T186842: Convert Special:GlobalPreferences to OOUI as Resolved.Sep 27 2018, 1:52 PM
Trizek-WMF added a subtask: T205629: Tooltip icons looks misaligned when close to checkboxes in Special:Preferences.Sep 27 2018, 2:52 PM
Volker_E updated the task description. (Show Details)Sep 27 2018, 5:54 PM
Volker_E updated the task description. (Show Details)Sep 27 2018, 6:43 PM
Esanders mentioned this in T205866: Make save button more visible on Special:Preferences.Oct 1 2018, 1:51 PM
Esanders added a subtask: T205866: Make save button more visible on Special:Preferences.
Esanders updated the task description. (Show Details)Oct 1 2018, 1:58 PM
Volker_E closed subtask T204861: Reconsider keyboard user navigation hint exposure as Resolved.Nov 5 2018, 4:08 AM
Volker_E updated the task description. (Show Details)Nov 5 2018, 4:11 AM
Dvorapa added a subtask: T208834: More info question marks should be close to description, not close to checkboxes.Nov 6 2018, 9:12 AM
Dvorapa added a subtask: T208837: There should be a difference between section header and bold text in preferences.Nov 6 2018, 9:24 AM
Akhilam513 updated the task description. (Show Details)Nov 9 2018, 2:36 PM
Akhilam513 subscribed.Nov 9 2018, 3:00 PM
Jdforrester-WMF closed subtask T205629: Tooltip icons looks misaligned when close to checkboxes in Special:Preferences as Resolved.Nov 19 2018, 4:44 PM
Volker_E removed a subtask: T208834: More info question marks should be close to description, not close to checkboxes.Nov 19 2018, 7:28 PM
Volker_E removed a subtask: T181996: New Preferences headers may be unclickable when wrapped on Timeless skin.
Volker_E closed subtask T194533: Special:Preferences: rename the field titled "Signature" to "Signature/Nickname" as Declined.Nov 19 2018, 7:43 PM
Volker_E closed subtask T208837: There should be a difference between section header and bold text in preferences as Resolved.Nov 20 2018, 6:33 AM
• Prtksxna unsubscribed.Nov 21 2018, 8:19 AM
Jdforrester-WMF closed subtask T205866: Make save button more visible on Special:Preferences as Resolved.Nov 27 2018, 9:13 PM
Jdforrester-WMF updated the task description. (Show Details)
Volker_E removed a subtask: T194523: DropdownInputWidget: In non-JS, focus state border is missing on the right side and other interaction visual glitches.Nov 27 2018, 10:04 PM
Jdforrester-WMF closed subtask T194524: Special:Preferences: Describe the empty text box ("Other timezone") with some placeholder text as Resolved.Nov 30 2018, 8:59 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF updated the task description. (Show Details)
Izno added a subtask: T204111: Language widget on Special:Preferences is slow to load.Jun 1 2021, 5:23 PM
Volker_E removed a subtask: T203727: Restructure and improve 'Basic information' section.Jun 27 2021, 9:59 AM
Volker_E removed a subtask: T194531: Special:Preferences: For JS-requiring features, re-use the styling that Beta Features invented and show a red warning but only to non-JS users .
Volker_E mentioned this in T194531: Special:Preferences: For JS-requiring features, re-use the styling that Beta Features invented and show a red warning but only to non-JS users .Jun 27 2021, 10:03 AM
Volker_E updated the task description. (Show Details)Jun 27 2021, 10:06 AM
Volker_E updated the task description. (Show Details)Jun 27 2021, 10:18 AM
Volker_E closed this task as Resolved.EditedJun 27 2021, 10:23 AM
Volker_E claimed this task.
Volker_E added a subscriber: • Prtksxna.

Setting this task as resolved (with a slight delay). 🎉
The two nice-to-have tasks left from description were not prioritized ever since and are fine to remain untangled from scope of this task. Altogether we've successfully (as in no further tasks raised by peers and volunteers) tackled 33 tasks and merged many more patches. Thanks to everyone involved, especially @Jdforrester-WMF @matmarex @Esanders @Prtksxna for majority of code contributions and all commenters participating.

Volker_E mentioned this in T65583: Change MediaWiki core user preferences layout.Jun 27 2021, 11:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL