How to reproduce:
- Go to https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences (make sure you're logged in)
- Reload the page, don't change anything
- It should just reload but it asks for confirmation
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| InputWidget and subclasses: Remember original value when creating the widget | oojs/ui | master | +58 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core | |||
| Open | None | T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core | |||
| Open | None | T100161 Convert all of MediaWiki core to OOUI PHP (tracking) | |||
| Resolved | matmarex | T101480 Remove 'wgUseMediaWikiUIEverywhere' and code forks, always using the off/false path | |||
| Invalid | None | T101471 Convert core forms that use MW UI with wgUseMediaWikiUIEverywhere false to OOUI FormSpecialPage or explicit OOUI PHP | |||
| Open | None | T107037 Convert all MW core special pages to OOUI | |||
| Open | None | T64559 Redesign Special:Preferences (tracking) | |||
| Resolved | Volker_E | T180538 Improve Special:Preferences UI/UX | |||
| Resolved | Volker_E | T117781 Convert Special:Preferences to OOUI | |||
| Resolved | matmarex | T181691 [Pre-wmf.11] Special:Preferences asks for leave confirmation even when no changes were made |
Event Timeline
Comment Actions
Nope, you must have clicked somewhere (which triggers the code deciding you must have "changed" something). We found that as a pre-existing bug when converting over. Third item on T180538: Improve Special:Preferences UI/UX.
Comment Actions
You can easily see it in action on beta without clicking anywhere.
We found that as a pre-existing bug when converting over. Third item on T180538: Improve Special:Preferences UI/UX.
The issue is not present on en.wp or fr.wp, where the UX change hasn't been deployed yet.
Comment Actions
This looks to be a regression from https://gerrit.wikimedia.org/r/#/c/393352/ in the last OOUI release. So, good news, it's not going out to production this week, but bad news, it will be awkward to backport the fix.
Comment Actions
I can't. Maybe it's a browser-specific issue. In which browser(s) are you seeing it? I've tested in Firefox and Safari locally.
(I can still trigger the click-on-anything-and-it-decides-you've-changed issue, which I thought this was, but Bartosz says is a different task.)
Comment Actions
I'm seeing it with Chrome 62.
I can reproduce with Firefox 57 with slightly different steps (if it's of any use to whoever works on it)
- Land on Special:Preferences
- Scroll down with the mouse, pad, or down key
- Refresh the page and get the confirmation
Comment Actions
Change 406398 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] InputWidget and subclasses: Remember original value when creating the widget
Comment Actions
Change 406398 merged by jenkins-bot:
[oojs/ui@master] InputWidget and subclasses: Remember original value when creating the widget
Comment Actions
I verified that this fixes the issue with OOUI Special:Preferences (using the WIP patch at https://gerrit.wikimedia.org/r/#/c/398071/).