Page MenuHomePhabricator
Create Task
Maniphest T196062

EXT_DEPENDENCIES no more being injected on quibble jobs
Closed, ResolvedPublic
Actions

Description

With Wikibase and PropertySuggester cloned, Quibble installs mediawiki with:

install.php --with-extensions [..]

That injects the extensions in LocalSettings with wfLoadExtension(). install.php works fine but when running phpunit tests, the Wikibase autoloader does not seem to be registered:

$ tests/phpunit/phpunit.php --debug-tests --testsuite extensions 
Using PHP 7.0.27-0+deb9u1
PHP Fatal error:  Class 'Wikibase\Repo\Tests\Api\WikibaseApiTestCase' not found
 in /workspace/src/extensions/PropertySuggester/tests/phpunit/PropertySuggester/GetSuggestionsTest.php on line 24

The class is defined in Wikibase at:

extensions/Wikibase/repo/autoload.php
353 'Wikibase\\Repo\\Tests\\Api\\WikibaseApiTestCase' => __DIR__ . '/tests/phpunit/includes/Api/WikibaseApiTestCase.php',

Wikibase does not have an extension.json, its Wikibase.php lets one switch between client and repo setup based on $wgEnableWikibaseRepo or $wgEnableWikibaseClient being set.

Details

SubjectRepoBranchLines +/-
zuul: fix deps for Quibble jobsintegration/configmaster+10 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.May 31 2018, 11:06 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptMay 31 2018, 11:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
hashar added a parent task: T196013: Get Wikibase + dependencies to run with Quibble.May 31 2018, 11:07 AM
hashar mentioned this in T196013: Get Wikibase + dependencies to run with Quibble.
hashar added a comment.May 31 2018, 11:21 AM

Looking at quibble-composer-mysql-php70-docker job, the extension dependency Wikibase is no more injected for PropertySuggester. It was on May 30th at 19:20UTC.

gerritbot subscribed.May 31 2018, 11:36 AM

Change 436510 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] zuul: fix deps for Quibble jobs

https://gerrit.wikimedia.org/r/436510

gerritbot added a project: Patch-For-Review.May 31 2018, 11:36 AM
gerritbot added a comment.May 31 2018, 11:40 AM

Change 436510 merged by jenkins-bot:
[integration/config@master] zuul: fix deps for Quibble jobs

https://gerrit.wikimedia.org/r/436510

Stashbot subscribed.May 31 2018, 11:41 AM

Mentioned in SAL (#wikimedia-releng) [2018-05-31T11:41:50Z] <hashar> Fixed EXT_DEPENDENCIES no more being injected on quibble jobs T196062

hashar renamed this task from [PropertySuggester] PHP Fatal error: Class 'Wikibase\Repo\Tests\Api\WikibaseApiTestCase' not found in extensions/PropertySuggester/tests/phpunit/PropertySuggester/GetSuggestionsTest.php on line 24 to EXT_DEPENDENCIES no more being injected on quibble jobs.May 31 2018, 11:42 AM
hashar closed this task as Resolved.
hashar claimed this task.
• Vvjjkkii renamed this task from EXT_DEPENDENCIES no more being injected on quibble jobs to 5wbaaaaaaa.Jul 1 2018, 1:06 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed hashar as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
thcipriani assigned this task to hashar.Jul 1 2018, 7:35 PM
thcipriani updated the task description. (Show Details)
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptJul 1 2018, 7:35 PM
thcipriani renamed this task from 5wbaaaaaaa to EXT_DEPENDENCIES no more being injected on quibble jobs.Jul 1 2018, 7:35 PM
thcipriani closed this task as Resolved.
thcipriani removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, CheckUser.
thcipriani added subscribers: Aklapper, gerritbot.Jul 1 2018, 7:36 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.Jul 5 2018, 6:56 PM
CommunityTechBot removed a project: Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL