Maniphest T196159

Remove instrumentation for Schema:Print
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Split off from T181297 so that this won't be forgotten:

We should stop sending data for the Print schema (and possibly remove the instrumentation code entirely), once it is decided that no new data is needed (might be after some further deployments).

Developer notes

Code that triggers events lives in WikimediaEvents extension: https://github.com/wikimedia/mediawiki-extensions-WikimediaEvents/blob/master/modules/all/ext.wikimediaEvents.print.js

Disabling

Captured separately in T208454

Removing the feature

In order to remove the whole feature please remove the ext.wikimediaEvents.print.js file and deregister schema.Print and the wikimediaEvents.print module from extension.json ext.wikimediaEvents module.

Acceptance Criteria

Once code is removed, please add a note on the Schema:Print documentation page and also mark the schema as inactive. Just add status=inactive to schema definition

See https://meta.wikimedia.org/w/index.php?title=Schema_talk%3AMobileWebMainMenuClickTracking&type=revision&diff=19264159&oldid=19048492 on how it can be done.

SWAT https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaEvents/+/570623/ once the rEWMVba890a017fcb: Decommision Print schema gets to production

QA Results

AC	Status	Details
1	✅	T196159#5898185
2	✅	T196159#5898185
3	✅	T196159#5898185
4	✅	T196159#5898185
5	✅	T196159#5898185

Details

	Subject	Repo	Branch	Lines +/-
	Clean-up decommisioned Print schema configs	operations/mediawiki-config	master	+0 -8
	Decommision Print schema	mediawiki/extensions/WikimediaEvents	master	+1 -141

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	ovasileva	T181079 [GOAL] Provide an expanded reading experience by improving the ways that users can download articles of interest for later consumption
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Resolved	ovasileva	T163472 [EPIC] Provide a way to download articles in PDF on the mobile website
Resolved	ovasileva	T196159 Remove instrumentation for Schema:Print
Resolved	• Tbayer	T179915 Determine expected amount of usage of mobile print to PDF button per browser
Resolved	• Tbayer	T179914 Deploy print to PDF button for Chrome on Android
Resolved	ovasileva	T179529 [Spike] Can we detect browsers where the window.print function simply doesn't work?
Resolved	CKoerner_WMF	T180114 Notify community of upcoming PDF button deployment
Resolved	• Tbayer	T181297 Instrument print to PDF button

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

ovasileva triaged this task as Medium priority.Jun 5 2018, 9:11 AM

ovasileva added a subtask: T179915: Determine expected amount of usage of mobile print to PDF button per browser.

ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

• Niedzielski added a project: Proton.Jun 12 2018, 4:14 PM

• Niedzielski edited projects, added MediaWiki-extensions-WikimediaEvents; removed Proton.Jun 12 2018, 4:17 PM

Jdlrobson set the point value for this task to 2.Jun 12 2018, 4:19 PM

pmiazga updated the task description. (Show Details)Jun 12 2018, 7:21 PM

• Tbayer moved this task from Triage to Epics on the Product-Analytics board.Jun 21 2018, 8:08 PM

• Vvjjkkii renamed this task from Turn off Schema:Print (timing TBD) to gubaaaaaaa.Jul 1 2018, 1:06 AM

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value for this task.

CommunityTechBot renamed this task from gubaaaaaaa to Turn off Schema:Print (timing TBD).Jul 2 2018, 1:46 PM

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot set the point value for this task to 2.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

once it is decided that no new data is needed (might be after some further deployments).

Marking as stalled until this happens.

@Tbayer Product-Analytics talked about this during their Phab Review meeting and determined that it's a Tracking task for the purposes of their team board. Please reply if you feel otherwise. :)

• Niedzielski mentioned this in T179915: Determine expected amount of usage of mobile print to PDF button per browser.Oct 24 2018, 6:33 PM

I think this can now be done?!? Cc @HaeB

In T196159#4708067, @Jdlrobson wrote:

I think this can now be done?!? Cc @HaeB

See my earlier question at T179915#4692627 - I think so, going to close that task now.

• Tbayer closed subtask T179915: Determine expected amount of usage of mobile print to PDF button per browser as Resolved.Oct 31 2018, 4:29 PM

Jdlrobson renamed this task from Turn off Schema:Print (timing TBD) to Remove instrumentation for Schema:Print (timing TBD).Oct 31 2018, 6:27 PM

Jdlrobson mentioned this in T208454: Disable the Schema:Print data collection.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a parent task: T163472: [EPIC] Provide a way to download articles in PDF on the mobile website.

Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Nov 12 2018, 7:17 PM

Jdlrobson renamed this task from Remove instrumentation for Schema:Print (timing TBD) to Proton: Remove instrumentation for Schema:Print (timing TBD).Nov 15 2018, 7:04 PM

ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Nov 20 2018, 3:48 PM

ovasileva moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.

Let us know when we can remove this. We are shipping unused code to all mobile users and it would be great to remove it.

MBinder_WMF edited projects, added Web-Team-Backlog (Needs Product Owner Decisions); removed Web-Team-Backlog.Aug 7 2019, 4:56 PM

@ovasileva this code continues to be loaded on all pages (along with reading depth) without every getting run. Do we plan to remove this and ReadingDepth soon?

Jdlrobson moved this task from Product Owner Backlog to Needs Prioritization on the Web-Team-Backlog board.Dec 19 2019, 4:21 PM

We can go ahead and remove this.

ovasileva moved this task from Needs Analysis to Ready for Development on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Jan 15 2020, 6:11 PM

ovasileva renamed this task from Proton: Remove instrumentation for Schema:Print (timing TBD) to Remove instrumentation for Schema:Print (timing TBD).Jan 23 2020, 6:12 PM

ovasileva lowered the priority of this task from High to Medium.

polishdeveloper claimed this task.Jan 29 2020, 9:39 PM

polishdeveloper moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.

Jdlrobson renamed this task from Remove instrumentation for Schema:Print (timing TBD) to Remove instrumentation for Schema:Print.Jan 30 2020, 4:41 AM

ovasileva removed polishdeveloper as the assignee of this task.Feb 5 2020, 6:20 PM

ovasileva moved this task from Doing to Ready for Development on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.

ovasileva added a subscriber: polishdeveloper.

Change 570623 had a related patch set uploaded (by Pmiazga; owner: polishdeveloper):
[mediawiki/extensions/WikimediaEvents@master] Decommision Print schema

https://gerrit.wikimedia.org/r/570623

gerritbot added a project: Patch-For-Review.Feb 6 2020, 12:39 PM

polishdeveloper updated the task description. (Show Details)Feb 6 2020, 12:42 PM

Jdlrobson moved this task from Ready for Development to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Feb 6 2020, 12:44 PM

Change 570625 had a related patch set uploaded (by Polishdeveloper; owner: polishdeveloper):
[operations/mediawiki-config@master] Clean-up decommisioned Print schema configs

https://gerrit.wikimedia.org/r/570625

polishdeveloper updated the task description. (Show Details)Feb 6 2020, 12:49 PM

phuedx claimed this task.Feb 6 2020, 6:06 PM

Change 570623 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Decommision Print schema

https://gerrit.wikimedia.org/r/570623

Once code is removed, please add a note on the Schema:Print documentation page and also mark the schema as inactive. Just add status=inactive to schema definition

This was done some time ago by yours truly in https://meta.wikimedia.org/w/index.php?title=Schema_talk%3APrint&type=revision&diff=18715025&oldid=18575961.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 6 2020, 7:00 PM

@Edtadros: I'm not sure how to handle removal of code. If you'd like to talk about it for 10 minutes, then LMK. Would

Navigate to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page
Observe that there are no errors in the console

The above configuration change can be merged after rEWMVba890a017fcb: Decommision Print schema has been deployed to the Wikipedias (Monday, 17th February).

phuedx reassigned this task from phuedx to Edtadros.Feb 11 2020, 6:07 PM

phuedx subscribed.

@phuedx I will take you up on the offer to talk about it. I went to the URL you mentioned and saw no errors in the console.

@Edtadros: To confirm, I can verify that the code has been removed from the codebase. That removal will be deployed to all Wikipedias tomorrow (Thursday, 13th February).

@phuedx Can you confirm that the code has been removed in production as well please?

Also the Acceptance Criteria states:

Once code is removed, please add a note on the Schema:Print documentation page and also mark the schema as inactive. Just add status=inactive to schema definition
See https://meta.wikimedia.org/w/index.php?title=Schema_talk%3AMobileWebMainMenuClickTracking&type=revision&diff=19264159&oldid=19048492 on how it can be done.

This indicates to me that the Schema:Print documentation page should be listed on the Categories:Schemas (inactive) page in addition to having the schema status=inactive on the schema page. If this is the case I don't believe that either have been implemented.

Edtadros reassigned this task from Edtadros to phuedx.Feb 14 2020, 4:35 PM

In T196159#5885148, @Edtadros wrote:

@phuedx Can you confirm that the code has been removed in production as well please?

It hasn't yet been removed in production as the 🚂 is blocked.

Also the Acceptance Criteria states:

Once code is removed, please add a note on the Schema:Print documentation page and also mark the schema as inactive. Just add status=inactive to schema definition
See https://meta.wikimedia.org/w/index.php?title=Schema_talk%3AMobileWebMainMenuClickTracking&type=revision&diff=19264159&oldid=19048492 on how it can be done.

This indicates to me that the Schema:Print documentation page should be listed on the Categories:Schemas (inactive) page in addition to having the schema status=inactive on the schema page. If this is the case I don't believe that either have been implemented.

I see

Status: inactive

on https://meta.wikimedia.org/wiki/Schema_talk:Print and I see the schema's documentation page listed on https://meta.wikimedia.org/wiki/Category:Schemas_(inactive).

Would you mind rechecking?

phuedx reassigned this task from phuedx to Edtadros.Feb 17 2020, 10:45 AM

@Edtadros: I can confirm that the patch has been deployed to all wikis.

Test Result

Status: ✅ PASS
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhoneX

Test Artifact(s):

Beta
✅ AC1: Verify code removed T196159#5877931
Navigate to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page
✅ AC2: Observe that there are no errors in the console

Enwiki
✅ AC3: Verify code removed T196159#5898178
✅ AC4: Update Schema:Print Documentation page
Verified on:
https://meta.wikimedia.org/wiki/Schema_talk:Print
https://meta.wikimedia.org/wiki/Category:Schemas_(inactive).
Navigate to https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page
✅ AC5: Observe that there are no errors in the console

Edtadros updated the task description. (Show Details)Feb 19 2020, 6:09 PM

ovasileva closed this task as Resolved.Feb 20 2020, 12:18 PM

Change 570625 merged by jenkins-bot:

[operations/mediawiki-config@master] Clean-up decommisioned Print schema configs