Page MenuHomePhabricator
Create Task
Maniphest T196523

Page Preview should not strip space before period
Closed, ResolvedPublic
Actions

Assigned To
MSantos
Authored By
Krinkle
Jun 6 2018, 2:09 AM
Tags
Referenced Files
F23681129: Screen Shot 2018-07-12 at 6.24.22 AM.png
Jul 12 2018, 12:25 PM
F18827163: preview.png
Jun 6 2018, 2:09 AM
F18827142: article.png
Jun 6 2018, 2:09 AM
Subscribers
• bearND
• Jhernandez
Krinkle
MSantos
• Pchelolo
Stashbot

Description

Article: .NET FoundationPreview at /wiki/Miguel de Icaza
article.png (456×1 px, 120 KB)
preview.png (1×1 px, 412 KB)

API:
https://en.wikipedia.org/api/rest_v1/page/summary/.NET_Foundation

{"type":"standard","title":".NET Foundation","displaytitle":".NET Foundation","namespace":{"id":0,"text":""},"titles":{"canonical":".NET_Foundation","normalized":".NET Foundation","display":".NET Foundation"},"pageid":46762138,"lang":"en","dir":"ltr","revision":"787437872","tid":"ab0506f5-4895-11e8-8c29-681bb1fdb7b8","timestamp":"2017-06-25T12:09:23Z","description":"organization to improve open-source development around the .NET framework","content_urls":{"desktop":{"page":"https://en.wikipedia.org/wiki/.NET_Foundation","revisions":"https://en.wikipedia.org/wiki/.NET_Foundation?action=history","edit":"https://en.wikipedia.org/wiki/.NET_Foundation?action=edit","talk":"https://en.wikipedia.org/wiki/Talk:.NET_Foundation"},"mobile":{"page":"https://en.m.wikipedia.org/wiki/.NET_Foundation","revisions":"https://en.m.wikipedia.org/wiki/Special:History/.NET_Foundation","edit":"https://en.m.wikipedia.org/wiki/.NET_Foundation?action=edit","talk":"https://en.m.wikipedia.org/wiki/Talk:.NET_Foundation"}},"api_urls":{"summary":"https://en.wikipedia.org/api/rest_v1/page/summary/.NET_Foundation","metadata":"https://en.wikipedia.org/api/rest_v1/page/metadata/.NET_Foundation","references":"https://en.wikipedia.org/api/rest_v1/page/references/.NET_Foundation","media":"https://en.wikipedia.org/api/rest_v1/page/media/.NET_Foundation","edit_html":"https://en.wikipedia.org/api/rest_v1/page/html/.NET_Foundation","talk_page_html":"https://en.wikipedia.org/api/rest_v1/page/html/Talk:.NET_Foundation"},"extract":"The .NET Foundation is an independent organization, incorporated on March 31, 2014, by Microsoft, to improve open-source software development and collaboration around the.NET Framework. It was launched at the annual Build 2014 conference held by Microsoft. The foundation is license-agnostic, and projects that come to the foundation are free to choose any open-source license, as defined by the Open Source Initiative (OSI). The foundation uses GitHub to host the open-source projects it manages.","extract_html":"<p>The <b>.NET Foundation</b> is an independent organization, incorporated on March 31, 2014, by Microsoft, to improve open-source software development and collaboration around the.NET Framework. It was launched at the annual Build 2014 conference held by Microsoft. The foundation is license-agnostic, and projects that come to the foundation are free to choose any open-source license, as defined by the Open Source Initiative (OSI). The foundation uses GitHub to host the open-source projects it manages.</p>"}

Details

SubjectRepoBranchLines +/-
Summary: Don't strip space before periodmediawiki/services/mobileappsmaster+23 -9
Summary: Don't strip space before periodmediawiki/services/mobileappsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Jun 6 2018, 2:09 AM
Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptJun 6 2018, 2:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle moved this task from Needs Triage to Needs Decision on the Page Content Service board.Jun 6 2018, 2:11 AM
• Niedzielski added a project: Web-Team-Backlog.Jun 6 2018, 2:19 PM
• Niedzielski moved this task from Incoming to Tracking on the Web-Team-Backlog board.
• Niedzielski edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
• bearND triaged this task as Medium priority.Jun 6 2018, 2:28 PM
• bearND moved this task from Needs triage to Kanban on the Product-Infrastructure-Team-Backlog-Deprecated board.
• bearND edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.
MSantos claimed this task.Jun 28 2018, 2:09 PM
MSantos moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
gerritbot subscribed.Jun 29 2018, 1:08 PM

Change 443087 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/services/mobileapps@master] [POC] Summary: Don't strip space before period

https://gerrit.wikimedia.org/r/443087

gerritbot added a project: Patch-For-Review.Jun 29 2018, 1:08 PM
gerritbot added a comment.Jun 29 2018, 1:13 PM

Change 443088 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/services/mobileapps@master] Summary: Don't strip space before period

https://gerrit.wikimedia.org/r/443088

MSantos added a comment.Jun 29 2018, 1:14 PM
This comment was removed by MSantos.
gerritbot added a comment.Jun 29 2018, 2:12 PM

Change 443088 abandoned by MSantos:
Summary: Don't strip space before period

Reason:
Commit shouldn't be pushed before the test. It was supposed to be an alternative to https://gerrit.wikimedia.org/r/443087, but it has to be discarded.

https://gerrit.wikimedia.org/r/443088

MSantos moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jun 29 2018, 6:59 PM
• Vvjjkkii renamed this task from Page Preview should not strip space before period to ckbaaaaaaa.Jul 1 2018, 1:05 AM
• Vvjjkkii removed MSantos as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: MSantos; removed: gerritbot, Aklapper.
Krinkle renamed this task from ckbaaaaaaa to Page Preview should not strip space before period.Jul 1 2018, 11:59 PM
Krinkle assigned this task to MSantos.
Krinkle removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Krinkle updated the task description. (Show Details)
CommunityTechBot lowered the priority of this task from High to Medium.Jul 5 2018, 6:58 PM
gerritbot added a comment.Jul 10 2018, 6:44 PM

Change 443087 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Summary: Don't strip space before period

https://gerrit.wikimedia.org/r/443087

• bearND moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jul 10 2018, 9:38 PM
Stashbot mentioned this in T195325: Page media endpoint missing math formula images.Jul 11 2018, 8:16 PM
Stashbot mentioned this in T189830: Improve media endpoint performance.
Stashbot mentioned this in T177619: Return variant URLs and titles in the metadata response.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-07-11T20:16:33Z] <bsitzmann@deploy1001> Started deploy [mobileapps/deploy@03fa731]: Update mobileapps to b5e152d (T195325 T189830 T177619 T196523)

Stashbot added a comment.Jul 11 2018, 8:20 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-11T20:20:04Z] <bsitzmann@deploy1001> Finished deploy [mobileapps/deploy@03fa731]: Update mobileapps to b5e152d (T195325 T189830 T177619 T196523) (duration: 03m 30s)

Stashbot added a comment.Jul 11 2018, 10:18 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-11T22:18:16Z] <bsitzmann@deploy1001> Started deploy [mobileapps/deploy@03fa731]: Update mobileapps to b5e152d (T195325 T189830 T177619 T196523)

Stashbot added a comment.Jul 11 2018, 10:25 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-11T22:25:00Z] <bsitzmann@deploy1001> Finished deploy [mobileapps/deploy@03fa731]: Update mobileapps to b5e152d (T195325 T189830 T177619 T196523) (duration: 06m 44s)

• bearND moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jul 11 2018, 10:33 PM
• Jhernandez subscribed.EditedJul 12 2018, 11:41 AM
> curl -s https://en.wikipedia.org/api/rest_v1/page/summary/.NET_Foundation | jq .extract
"The .NET Foundation is an independent organization, incorporated on March 31, 2014, by Microsoft, to improve open-source software development and collaboration around the.NET Framework. It was launched at the annual Build 2014 conference held by Microsoft. The foundation is license-agnostic, and projects that come to the foundation are free to choose any open-source license, as defined by the Open Source Initiative (OSI). The foundation uses GitHub to host the open-source projects it manages."

Let me know when it can be verified in prod (see "the.NET Framework" there).

• bearND added a project: ChangeProp.Jul 12 2018, 12:10 PM
• bearND added subscribers: • Pchelolo, • bearND.

@Pchelolo Hmm, I think there's something wrong with ChangeProp. I just ran the ?action=purge command and directly on the prod machines I get the new version 1.3.7,

bsitzmann@scb1001:/srv/deployment/mobileapps$ curl -sI localhost:8888/en.wikipedia.org/v1/page/summary/.NET_Foundation | grep Spec
Content-Type: application/json; charset=utf-8; profile="https://www.mediawiki.org/wiki/Specs/Summary/1.3.7"

The output looks correct directly on scb1001:

bsitzmann@scb1001:/srv/deployment/mobileapps$ curl -s localhost:8888/en.wikipedia.org/v1/page/summary/.NET_Foundation | jq .extract
"The .NET Foundation is an independent organization, incorporated on March 31, 2014, by Microsoft, to improve open-source software development and collaboration around the .NET Framework. It was launched at the annual Build 2014 conference held by Microsoft. The foundation is license-agnostic, and projects that come to the foundation are free to choose any open-source license, as defined by the Open Source Initiative (OSI). The foundation uses GitHub to host the open-source projects it manages."

but externally (through RB) I only get the old content:

curl -sI https://en.wikipedia.org/api/rest_v1/page/summary/.NET_Foundation | grep 'Specs'
content-type: application/json; charset=utf-8; profile="https://www.mediawiki.org/wiki/Specs/Summary/1.3.6"
• bearND added a comment.Jul 12 2018, 12:19 PM

@Jhernandez Looks like it's working now. I see 1.3.7 externally, too, now. Usually just running ?action=purge on the affected page or waiting for an edit or a transclusion update should fix it. I guess ChangeProp was still recovering from the outages and failing over.

• bearND removed projects: ChangeProp, Patch-For-Review.EditedJul 12 2018, 12:21 PM

There was a spike in mw-purge-resource-change_delay in https://grafana.wikimedia.org/dashboard/db/eventbus?panelId=10&fullscreen&orgId=1&from=1531396280821&to=1531398122863

Screen Shot 2018-07-12 at 6.24.22 AM.png (712×947 px, 139 KB)

• Jhernandez closed this task as Resolved.Jul 13 2018, 3:57 PM

Cool! Thanks for checking Bernd. Confirmed fixed! 👍

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL