Page MenuHomePhabricator
Create Task
Maniphest T204793

Flow TopicPageCreationListener causes "InvalidArgumentException: The given Title does not belong" from MutableRevisionRecord.php
Open, Needs TriagePublicPRODUCTION ERROR
Actions

Description

Error

Request ID: W5A4mwpAIDEAAIJd2S8AAACM

message
[{exception_id}] {exception_url}   InvalidArgumentException from line 279 of /srv/mediawiki/php-1.32.0-wmf.20/includes/Storage/MutableRevisionRecord.php: The given Title does not belong to page ID 813794
stacktrace
#0 /srv/mediawiki/php-1.32.0-wmf.20/includes/Storage/PageUpdater.php(865): MediaWiki\Storage\MutableRevisionRecord->setPageId(integer)
#1 /srv/mediawiki/php-1.32.0-wmf.20/includes/Storage/PageUpdater.php(926): MediaWiki\Storage\PageUpdater->makeNewRevision(CommentStoreComment, User, string, integer, Status)
#2 /srv/mediawiki/php-1.32.0-wmf.20/includes/Storage/PageUpdater.php(733): MediaWiki\Storage\PageUpdater->doModify(CommentStoreComment, User, integer)
#3 /srv/mediawiki/php-1.32.0-wmf.20/includes/page/WikiPage.php(1865): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
#4 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Flow/includes/TalkpageManager.php(136): WikiPage->doEditContent(Flow\Content\BoardContent, CommentStoreComment, integer, boolean, User)
#5 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Flow/includes/Data/Listener/TopicPageCreationListener.php(44): Flow\TalkpageManager->ensureFlowRevision(Article, Flow\Model\Workflow)
#6 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/MWCallableUpdate.php(34): Closure$Flow\Data\Listener\TopicPageCreationListener::onAfterInsert()
#7 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/DeferredUpdates.php(268): MWCallableUpdate->doUpdate()
#8 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/DeferredUpdates.php(214): DeferredUpdates::runUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, string, integer)
#9 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/DeferredUpdates.php(130): DeferredUpdates::execute(array, string, integer)
#10 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(607): DeferredUpdates::doUpdates(string, integer)
#11 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(576): MediaWiki::preOutputCommit(RequestContext, Closure$MediaWiki::main;2427)
#12 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(884): MediaWiki->doPreOutputCommit(Closure$MediaWiki::main;2427)
#13 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(525): MediaWiki->main()
#14 /srv/mediawiki/php-1.32.0-wmf.20/index.php(42): MediaWiki->run()

Notes

It seems to mostly happen on Special:Preferences from a deferred update.

Screen Shot 2018-09-19 at 02.38.29.png (760×2 px, 147 KB)

This fatal exception was recorded 127 times by Logstash in the last 7 days. It is a new regression introduced in 1.32.0-wmf.20. It was not seen prior to that.

Possibly related:

Details

SubjectRepoBranchLines +/-
RevisionStore and PageUpdater: handle stale page IDmediawiki/coremaster+161 -9
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Sep 19 2018, 1:43 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 19 2018, 1:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle updated the task description. (Show Details)Sep 19 2018, 1:46 AM
SBisson subscribed.Sep 19 2018, 3:30 PM
kostajh subscribed.Sep 25 2018, 8:51 PM

This exception occurs when you enable Flow on your talk page via Special:Preferences. Despite this exception, the Flow-enabled talk page is successfully created.

Trizek-WMF subscribed.Sep 26 2018, 1:17 PM
In T204793#4616901, @kostajh wrote:

This exception occurs when you enable Flow on your talk page via Special:Preferences. Despite this exception, the Flow-enabled talk page is successfully created.

You mean that's through the Beta feature system?

kostajh added a comment.Sep 26 2018, 1:22 PM

@Trizek-WMF yes, through Beta features.

Trizek-WMF added a comment.Sep 26 2018, 1:27 PM

Oh no. It is back.

Krinkle added a comment.EditedOct 13 2018, 11:44 PM

(Still seen on 1.32-wmf.24, and 1.33-wmf.16, and 1.33-wmf.21)

Krinkle mentioned this in Blog Post: Production Excellence #8: February 2019.Mar 21 2019, 5:56 PM
kostajh added a comment.Mar 21 2019, 8:48 PM

I can reproduce this:

  • Create a new user
  • Create your talk page (i.e. should not be a red link)
  • Enable the BetaFeature

In includes/Data/Listener/TopicPageCreationListener.php, moving the ensureFlowRevision() code out of the deferred update resolves the issue. I'll see if I can find a better solution than that, though.

kostajh added a comment.Mar 21 2019, 9:04 PM

Also noting that in includes/Storage/PageUpdater.php#makeNewRevision, changing $rev->setPageId( $title->getArticleID() ); to query master with $rev->setPageId( $title->getArticleID( Title::GAID_FOR_UPDATE ) ); fixes this issue as well.

kostajh moved this task from Inbox to Needs Discussion on the Growth-Team board.Mar 21 2019, 9:04 PM
Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.Mar 25 2019, 10:18 PM
JTannerWMF moved this task from Needs Discussion to Revisit on the Growth-Team board.May 14 2019, 5:52 PM
JTannerWMF subscribed.

Since this isn't blocking end users we will revisit this when we have more time.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Krinkle mentioned this in T246720: Unable to save edit due to "The given Title does not belong to page" error (Wikipedias with FlaggedRevs enabled).Mar 10 2020, 1:35 AM
gerritbot added a comment.Apr 9 2020, 12:08 PM

Change 587722 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] RevisionStore and PageUpdater: handle stale page ID

https://gerrit.wikimedia.org/r/587722

gerritbot added a project: Patch-For-Review.Apr 9 2020, 12:08 PM
Trizek-WMF unsubscribed.Apr 15 2020, 1:49 PM
gerritbot added a comment.Apr 27 2020, 9:16 PM

Change 587722 merged by jenkins-bot:
[mediawiki/core@master] RevisionStore and PageUpdater: handle stale page ID

https://gerrit.wikimedia.org/r/587722

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2020, 10:11 PM
DannyS712 added subscribers: daniel, DannyS712.Jul 1 2020, 4:26 AM

@daniel i this still an issue following your patch in April?

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL