Page MenuHomePhabricator
Create Task
Maniphest T205675

Move action aborted by fatal error "Argument must be MediaWiki\Storage\RevisionRecord, null given"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: W61juwrAMGkAAHdPhScAAACK

message
PHP Fatal Error: Argument 1 passed to MediaWiki\Storage\MutableRevisionRecord::newFromParentRevision() must be an instance of MediaWiki\Storage\RevisionRecord, null given
stacktrace
#0 /srv/mediawiki/php-1.32.0-wmf.23/includes/Storage/MutableRevisionRecord.php(64): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.23/includes/Storage/RevisionStore.php(1082): MediaWiki\Storage\MutableRevisionRecord::newFromParentRevision(NULL)
#2 /srv/mediawiki/php-1.32.0-wmf.23/includes/Revision.php(1180): MediaWiki\Storage\RevisionStore->newNullRevision(Wikimedia\Rdbms\DatabaseMysqli, Title, CommentStoreComment, boolean, User)
#3 /srv/mediawiki/php-1.32.0-wmf.23/includes/MovePage.php(537): Revision::newNullRevision(Wikimedia\Rdbms\DatabaseMysqli, integer, string, boolean, User)
#4 /srv/mediawiki/php-1.32.0-wmf.23/includes/MovePage.php(271): MovePage->moveToInternal(User, Title, string, boolean, array)
#5 /srv/mediawiki/php-1.32.0-wmf.23/includes/api/ApiMove.php(189): MovePage->move(User, string, boolean, array)
#6 /srv/mediawiki/php-1.32.0-wmf.23/includes/api/ApiMove.php(87): ApiMove->movePage(Title, Title, string, boolean, array)
#7 /srv/mediawiki/php-1.32.0-wmf.23/includes/api/ApiMain.php(1587): ApiMove->execute()
#8 /srv/mediawiki/php-1.32.0-wmf.23/includes/api/ApiMain.php(531): ApiMain->executeAction()
#9 /srv/mediawiki/php-1.32.0-wmf.23/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#10 /srv/mediawiki/php-1.32.0-wmf.23/api.php(87): ApiMain->execute()

Also seen from Special:Move:

trace
reqId: W6px6ArAADwAAJ@r1lgAAACM

PHP Error: Argument 1 passed to MediaWiki\Storage\MutableRevisionRecord::newFromParentRevision() must be an instance of MediaWiki\Storage\RevisionRecord, null given

#1 /srv/mediawiki/php-1.32.0-wmf.22/includes/Storage/RevisionStore.php(1082): MediaWiki\Storage\MutableRevisionRecord::newFromParentRevision(NULL)
#2 /srv/mediawiki/php-1.32.0-wmf.22/includes/Revision.php(1180): MediaWiki\Storage\RevisionStore->newNullRevision(Wikimedia\Rdbms\DatabaseMysqli, Title, CommentStoreComment, boolean, User)
#3 /srv/mediawiki/php-1.32.0-wmf.22/includes/MovePage.php(537): Revision::newNullRevision(Wikimedia\Rdbms\DatabaseMysqli, integer, string, boolean, User)
#4 /srv/mediawiki/php-1.32.0-wmf.22/includes/MovePage.php(271): MovePage->moveToInternal(User, Title, string, boolean, array)
#5 /srv/mediawiki/php-1.32.0-wmf.22/includes/specials/SpecialMovepage.php(595): MovePage->move(User, string, boolean)
#6 /srv/mediawiki/php-1.32.0-wmf.22/includes/specials/SpecialMovepage.php(128): MovePageForm->doSubmit()
#7 /srv/mediawiki/php-1.32.0-wmf.22/includes/specialpage/SpecialPage.php(569): MovePageForm->execute(NULL)
#8 /srv/mediawiki/php-1.32.0-wmf.22/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run(NULL)
#9 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#10 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(868): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.32.0-wmf.22/includes/MediaWiki.php(525): MediaWiki->main()
#12 /srv/mediawiki/php-1.32.0-wmf.22/index.php(42): MediaWiki->run()

Notes

Seen over 352 times in the last few weeks. Seems to be affecting commons.wikimedia.org and ar.wikipedia.org more than other wikis, but could be a coincidence.

Details

SubjectRepoBranchLines +/-
Avoid fatal when finding no base revision for a null revision.mediawiki/coremaster+16 -3
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Sep 27 2018, 11:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2018, 11:49 PM
Krinkle mentioned this in T205677: HHVM "Recoverable fatal error" should log to "fatal" instead of "error" channel.Sep 27 2018, 11:53 PM
Krinkle renamed this task from Move action aborted by fatal error "Argument 1 must be an instance of MediaWiki\Storage\RevisionRecord, null given" to Move action aborted by fatal error "Argument must be MediaWiki\Storage\RevisionRecord, null given".Sep 28 2018, 12:08 AM
Krinkle removed a project: MediaWiki-Action-API.
Krinkle updated the task description. (Show Details)
Krinkle updated the task description. (Show Details)
Krinkle moved this task from Untriaged to Older on the Wikimedia-production-error board.
CCicalese_WMF added projects: Platform Engineering (MCR: Reactive), Platform Team Legacy (Next).Oct 3 2018, 7:12 PM
CCicalese_WMF moved this task from Inbox to Next on the Multi-Content-Revisions board.
daniel added a comment.Oct 4 2018, 10:48 AM

The relevant code in MovePage was recently touched by @Anomie in I9ebdcbc566b11dea3, but I don't see how that change could have caused this problem.

I'll change the code to handle the error more nicely and log more info, but I currently have no idea why it actually happens.

gerritbot subscribed.Oct 4 2018, 10:50 AM

Change 464509 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Avoid fatal when finding no base revision for a null revision.

https://gerrit.wikimedia.org/r/464509

gerritbot added a project: Patch-For-Review.Oct 4 2018, 10:50 AM
daniel moved this task from Next to In Progress on the Multi-Content-Revisions board.Oct 4 2018, 10:51 AM
daniel edited projects, added Platform Team Legacy (Designing); removed Platform Team Legacy (Next).
CCicalese_WMF moved this task from In Progress to Reactive on the Multi-Content-Revisions board.Oct 4 2018, 2:57 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions (Reactive); removed Multi-Content-Revisions.
CCicalese_WMF moved this task from MCR: Reactive to MCR on the Platform Engineering board.Oct 4 2018, 3:14 PM
CCicalese_WMF edited projects, added Platform Engineering (MCR); removed Platform Engineering (MCR: Reactive).
CCicalese_WMF moved this task from Inbox to Waiting for Review on the Platform Team Legacy (Designing) board.Oct 4 2018, 3:21 PM
gerritbot added a comment.Oct 4 2018, 6:12 PM

Change 464509 merged by jenkins-bot:
[mediawiki/core@master] Avoid fatal when finding no base revision for a null revision.

https://gerrit.wikimedia.org/r/464509

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 4 2018, 7:00 PM
Anomie removed a project: Patch-For-Review.Oct 4 2018, 7:13 PM

Status: The merged patch should fix the fatal, but replaces it with another log message and an MWException that will probably also be logged.

For the benefit of searches, those will be like "Failed to load latest revision ID $Y of page ID $X" (the logged message) and "Failed to create null revision while moving page ID $X to $TITLE" (the MWException).

CCicalese_WMF edited projects, added Platform Team Workboards (Waiting for Review); removed Platform Team Legacy (Designing).Oct 14 2018, 3:43 PM
CCicalese_WMF triaged this task as High priority.Oct 15 2018, 3:13 PM
CCicalese_WMF edited projects, added Platform Team Workboards; removed Platform Team Workboards (Waiting for Review).
Anomie added a comment.Nov 5 2018, 11:57 PM

I spot-checked a few of these "Failed to load latest revision ID $Y of page ID $X" errors, and in all 7 cases the revision that couldn't be loaded seems to have been a page move null-revision timestamped within a few seconds of the error message. It seems like we're running into a situation where, when a move gets double-submitted, the first submission does the move and somehow the second sees the updated page.page_latest but somehow can't load the RevisionRecord. I can't see how that would happen though.

Aklapper edited projects, added MediaWiki-General; removed MediaWiki-extensions-General.Nov 10 2018, 7:36 PM
Aklapper mentioned this in T209202: Page Move Internal Error.
CCicalese_WMF lowered the priority of this task from High to Medium.Nov 26 2018, 4:17 PM
CCicalese_WMF edited projects, added Technical-Debt, Platform Team Legacy (Next); removed Platform Team Workboards.
CCicalese_WMF subscribed.

Reducing to normal since the fatal error is addressed. The root cause will still need to be investigated.

Krinkle moved this task from Older to Resolved on the Wikimedia-production-error board.Nov 26 2018, 4:17 PM
CCicalese_WMF merged a task: T209202: Page Move Internal Error.Nov 27 2018, 2:08 PM
CCicalese_WMF added subscribers: Barkeep49, Kizule, Krenair.
Anomie mentioned this in T210739: Target deletion during page move fails.Nov 30 2018, 10:15 PM
In T205675#4723071, @Anomie wrote:

and somehow the second sees the updated page.page_latest but somehow can't load the RevisionRecord. I can't see how that would happen though.

A possibility would be the REPEATABLE-READ transaction isolation level MySQL uses by default. If the read of page.page_latest is done with a FOR UPDATE and the load of the RevisionRecord was hitting the "repeatable" bit, that could give this result.

Krinkle removed a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Dec 11 2018, 6:24 PM
zeljkofilipin added a project: User-zeljkofilipin.Jun 5 2019, 1:52 PM
zeljkofilipin moved this task from Backlog 🪒 to Project ♟ on the User-zeljkofilipin board.
Krinkle added a comment.Jun 5 2019, 2:11 PM
In T205675#4643381, @Anomie wrote:

Status: The merged patch should fix the fatal, but replaces it with [an] MWException that will probably also be logged.

For the benefit of searches, those will be like […] "Failed to create null revision while moving page ID $X to $TITLE".

Indeed. The fatal error is gone, but we now have a fatal exception instead. Here's a recent example as recorded in Logstash from user requests:

  • Request ID: XPfDwApAIDUAAINsMG8AAACK
  • Request URL: POST /w/api.php
message
MWException: Failed to create null revision while moving page ID … to …
trace
0 /srv/mediawiki/php-1.34.0-wmf.8/includes/MovePage.php(452): MovePage->moveToInternal(User, Title, string, boolean, array)
#1 /srv/mediawiki/php-1.34.0-wmf.8/includes/MovePage.php(262): MovePage->moveUnsafe(User, string, boolean, array)
#2 /srv/mediawiki/php-1.34.0-wmf.8/includes/api/ApiMove.php(190): MovePage->move(User, string, boolean, array)
#3 /srv/mediawiki/php-1.34.0-wmf.8/includes/api/ApiMove.php(87): ApiMove->movePage(Title, Title, string, boolean, array)
#4 /srv/mediawiki/php-1.34.0-wmf.8/includes/api/ApiMain.php(1595): ApiMove->execute()
#5 /srv/mediawiki/php-1.34.0-wmf.8/includes/api/ApiMain.php(531): ApiMain->executeAction()
#6 /srv/mediawiki/php-1.34.0-wmf.8/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#7 /srv/mediawiki/php-1.34.0-wmf.8/api.php(87): ApiMain->execute()
#8 /srv/mediawiki/w/api.php(3): include(string)

Recent weeks:

Screenshot 2019-06-05 at 15.10.49.png (1×1 px, 86 KB)

Krinkle moved this task from Resolved to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Jun 5 2019, 2:12 PM
Krinkle mentioned this in Blog Post: Production Excellence #11: May 2019.Jul 1 2019, 6:48 PM
Aklapper mentioned this in T227517: MWException when moving talk page on enwiki: "Failed to create null revision while moving page".Jul 8 2019, 8:00 PM
Anomie merged a task: T227517: MWException when moving talk page on enwiki: "Failed to create null revision while moving page".Jul 10 2019, 1:16 PM
Anomie added a subscriber: DannyS712.
Anomie mentioned this in T227739: Contention on User::getActorId ?.Jul 11 2019, 6:13 PM
Aklapper mentioned this in T32211: Detect conflict on move.Jul 11 2019, 10:40 PM
Urbanecm subscribed.Jul 12 2019, 11:23 AM

I've posted the same backtrace at T32211#5324446. Two users were moving one page at almost the same time, so I originally thought it might be just T32211: Detect conflict on move. However, @Aklapper pointed that the same backtrace is in this task, so I'm putting this info here. Have no idea if it is actually a conflict or not, might be just a coincience :).

CCicalese_WMF edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Legacy (Next).Jul 14 2019, 3:19 PM
WDoranWMF moved this task from MCR to mop on the Platform Engineering board.Jul 26 2019, 6:39 PM
WDoranWMF edited projects, added Platform Team Initiatives (MCR); removed Platform Engineering (MCR).
zeljkofilipin removed a project: User-zeljkofilipin.Aug 21 2019, 1:45 PM
Krinkle unsubscribed.Aug 21 2019, 2:32 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
daniel moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Oct 8 2019, 9:57 AM
• AMooney changed the task status from Open to Stalled.Mar 12 2020, 1:22 PM
• AMooney edited projects, added Platform Engineering; removed Platform Team Workboards (Clinic Duty Team).
CCicalese_WMF moved this task from mop to Icebox on the Platform Engineering board.Mar 12 2020, 1:45 PM
WDoranWMF edited projects, added Platform Engineering (Icebox); removed Platform Engineering.Mar 23 2020, 2:04 PM
CCicalese_WMF removed a project: Platform Engineering (Icebox).Mar 24 2020, 10:31 PM
Krinkle edited projects, added MediaWiki-Page-rename; removed MediaWiki-General.Apr 8 2020, 4:35 PM
Krinkle closed this task as Resolved.Apr 8 2020, 10:46 PM

When querying mediawiki-errors on Logstash now, I no longer find any matches for "must be an instance of" that relate to RevisionRecord or MutableRevisionRecord.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL