Page MenuHomePhabricator
Create Task
Maniphest T206673

1.33.0-wmf.19 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Release Version
1.33.0-wmf.19
Release Date
Feb 25 2019, 12:00 AM

2019 week 09 1.33-wmf.19 Changes wmf/1.33.0-wmf.19

This MediaWiki Train Deployment is scheduled for the week of Monday, February 25th:

Monday February 25thTuesday, February 26thWednesday, February 27thThursday, February 28thFriday
Backports only.Branch wmf.19 and deploy to Group 0 Wikis.Deploy wmf.19 to Group 1 Wikis.Deploy wmf.19 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.19 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.33.0-wmf.18
Next: 1.33.0-wmf.20
SubjectRepoBranchLines +/-
group1 (except commonswiki) to 1.33.0-wmf.19operations/mediawiki-configmaster+505 -505
Revert "group1 wikis to 1.33.0-wmf.19"operations/mediawiki-configmaster+505 -505
Group0 to 1.33.0-wmf.19operations/mediawiki-configmaster+131 -131
Customize query in gerrit

Related Objects
Search...

Event Timeline

greg created this task.Oct 10 2018, 5:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2018, 5:23 PM
greg triaged this task as Medium priority.Oct 10 2018, 7:26 PM
Liuxinyu970226 subscribed.Oct 27 2018, 8:50 AM
Stashbot subscribed.Feb 26 2019, 2:20 PM

Mentioned in SAL (#wikimedia-operations) [2019-02-26T14:20:47Z] <hashar> Applied 1.33.0-wmf.19 security patches | T206673

gerritbot subscribed.Feb 26 2019, 2:24 PM

Change 493028 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/mediawiki-config@master] Group0 to 1.33.0-wmf.19

https://gerrit.wikimedia.org/r/493028

gerritbot added a project: Patch-For-Review.Feb 26 2019, 2:24 PM
Stashbot added a comment.Feb 26 2019, 3:02 PM

Mentioned in SAL (#wikimedia-operations) [2019-02-26T15:02:12Z] <hashar@deploy1001> Started scap: testwiki to php-1.33.0-wmf.19 and rebuild l10n cache # T206673

Stashbot added a comment.Feb 26 2019, 4:00 PM

Mentioned in SAL (#wikimedia-operations) [2019-02-26T16:00:27Z] <hashar@deploy1001> Finished scap: testwiki to php-1.33.0-wmf.19 and rebuild l10n cache # T206673 (duration: 58m 17s)

gerritbot added a comment.Feb 26 2019, 4:11 PM

Change 493028 merged by jenkins-bot:
[operations/mediawiki-config@master] Group0 to 1.33.0-wmf.19

https://gerrit.wikimedia.org/r/493028

Stashbot added a comment.Feb 26 2019, 4:11 PM

Mentioned in SAL (#wikimedia-releng) [2019-02-26T16:11:39Z] <hashar> Generating 1.33.0-wmf.19 deploy notes https://integration.wikimedia.org/ci/job/train-deploy-notes/9/console | T206673

Stashbot added a comment.Feb 26 2019, 4:14 PM

Mentioned in SAL (#wikimedia-operations) [2019-02-26T16:14:18Z] <hashar@deploy1001> rebuilt and synchronized wikiversions files: group0 to 1.33.0-wmf.19 # T206673

hashar claimed this task.Feb 26 2019, 4:14 PM
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptFeb 26 2019, 4:14 PM
hashar added a subtask: T217145: Catchable fatal error: Argument 1 passed to EventBusHooks::sendResourceChangedEvent() must be an instance of LinkTarget, Title given in /srv/mediawiki/php-1.33.0-wmf.19/extensions/EventBus/includes/EventBusHooks.php on line 324.Feb 26 2019, 4:24 PM
Jdlrobson changed the status of subtask T217146: ConfigException from line 339 of /srv/mediawiki/php-1.33.0-wmf.19/extensions/EventBus/includes/EventBus.php: EventBus::getInstance requires a configured $eventServiceName from Duplicate to Resolved.Feb 26 2019, 6:17 PM
hashar closed subtask T217145: Catchable fatal error: Argument 1 passed to EventBusHooks::sendResourceChangedEvent() must be an instance of LinkTarget, Title given in /srv/mediawiki/php-1.33.0-wmf.19/extensions/EventBus/includes/EventBusHooks.php on line 324 as Resolved.Feb 26 2019, 8:28 PM
Addshore added a subtask: T217241: PHP Notice: Use of undefined constant PREG_UNMATCHED_AS_NULL.Feb 27 2019, 1:55 PM
hashar closed subtask T217241: PHP Notice: Use of undefined constant PREG_UNMATCHED_AS_NULL as Resolved.Feb 27 2019, 4:58 PM
• alaa_wmde reopened subtask T217241: PHP Notice: Use of undefined constant PREG_UNMATCHED_AS_NULL as Open.Feb 27 2019, 5:26 PM
Addshore removed a subtask: T217241: PHP Notice: Use of undefined constant PREG_UNMATCHED_AS_NULL.Feb 27 2019, 5:27 PM
gerritbot added a comment.Feb 27 2019, 8:15 PM

Change 493309 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/mediawiki-config@master] Revert "group1 wikis to 1.33.0-wmf.19"

https://gerrit.wikimedia.org/r/493309

gerritbot added a comment.Feb 27 2019, 8:16 PM

Change 493309 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "group1 wikis to 1.33.0-wmf.19"

https://gerrit.wikimedia.org/r/493309

hashar added a comment.Feb 27 2019, 8:38 PM

commonswiki is emitting exceptions so I have rollbacked group1. Filled as T217285

gerritbot added a comment.Feb 27 2019, 8:44 PM

Change 493319 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/mediawiki-config@master] group1 (except commonswiki) to 1.33.0-wmf.19

https://gerrit.wikimedia.org/r/493319

gerritbot added a comment.Feb 27 2019, 8:48 PM

Change 493319 abandoned by Hashar:
group1 (except commonswiki) to 1.33.0-wmf.19

Reason:
Per internal discussion, it is better to just block the whole train instead of leaving commonswiki behind.

https://gerrit.wikimedia.org/r/493319

hashar removed a subtask: T217285: commonswiki / wikibase: Postcondition failed: Namespace for entity type property must be defined!.Feb 28 2019, 2:48 PM

T217285 has been hotfixed ;)

Stashbot added a comment.Feb 28 2019, 10:03 PM

Mentioned in SAL (#wikimedia-operations) [2019-02-28T22:03:58Z] <hashar> MediaWiki 1.33.0-wmf.19 deployed on all wikis # T206673

hashar closed this task as Resolved.Feb 28 2019, 10:05 PM

The last promotion went a bit crazy since we suffered a logging outage around the deployment. But eventually it got resolved and logstash is not concerning for 1.33.0-wmf.19.

There are a few follow up tasks but nothing worth a rollback.

MW-1.33-notes (1.33.0-wmf.19; 2019-02-26) has made it to all wikis \o/

Reedy closed subtask T217376: PHP fatal error: Class 'PHPlot' not found as Resolved.Feb 28 2019, 10:32 PM
Reedy removed a project: Patch-For-Review.
Anomie closed subtask T217382: APIEditPage -> ApiBase->checkTitleUserPermissions PHP Warning: Invalid operand type was used: Invalid type used as key as Resolved.Mar 4 2019, 8:34 PM
greg removed a subtask: T217380: TranslateRenderJob: Cannot render translation page for Wikimania/pa-guru!.Mar 8 2019, 12:47 AM
Liuxinyu970226 unsubscribed.Mar 11 2019, 12:17 AM
Ladsgroup subscribed.Feb 10 2020, 11:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL