Page MenuHomePhabricator
Create Task
Maniphest T208308

Beta: Argument 2 passed to Wikibase\Repo\Specials\SpecialEntitiesWithoutPageFactory::__construct() must be an instance of array, null given
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

On a repo with no entity types defined for some reason our list of empty entity types ends up being null instead of an array.

This goes against the phpdoc so should be fixed.

#0 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Specials/SpecialEntitiesWithoutPageFactory.php(31): NO_FUNCTION_GIVEN()
#1 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Specials/SpecialEntitiesWithoutPageFactory.php(35): Wikibase\Repo\Specials\SpecialEntitiesWithoutPageFactory::newFromGlobalState()
#2 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(393): Wikibase\Repo\Specials\SpecialEntitiesWithoutPageFactory::newSpecialEntitiesWithoutLabel()
#3 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(426): MediaWiki\Special\SpecialPageFactory->getPage(string)
#4 /srv/mediawiki/php-master/includes/specials/SpecialSpecialpages.php(56): MediaWiki\Special\SpecialPageFactory->getUsablePages(User)
#5 /srv/mediawiki/php-master/includes/specials/SpecialSpecialpages.php(44): SpecialSpecialpages->getPageGroups()
#6 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(569): SpecialSpecialpages->execute(NULL)
#7 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(558): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-master/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(862): MediaWiki->performRequest()
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(517): MediaWiki->main()
#11 /srv/mediawiki/php-master/index.php(42): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}

Reproduction https://commons.wikimedia.beta.wmflabs.org/wiki/Special:SpecialPages

Details

SubjectRepoBranchLines +/-
Test for RepositoryDefinitions no entity handelingmediawiki/extensions/Wikibasemaster+20 -0
Define RepositoryDefinitions namespace array even with 0 namespacesmediawiki/extensions/Wikibasemaster+3 -0
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedJdforrester-WMFT159708 Deploy WikibaseMediaInfo extension to production
ResolvedAddshoreT208308 Beta: Argument 2 passed to Wikibase\Repo\Specials\SpecialEntitiesWithoutPageFactory::__construct() must be an instance of array, null given
· · ·

Event Timeline

Addshore created this task.Oct 30 2018, 11:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2018, 11:45 AM
Addshore added a parent task: T180981: Deploy WikibaseMediaInfo extension to beta.Oct 30 2018, 11:45 AM
Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Addshore added a comment.EditedOct 30 2018, 11:59 AM

Related is also this stack

#0 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/WikibaseRepo.php(1339): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Specials/SpecialEntitiesWithoutPageFactory.php(31): Wikibase\Repo\WikibaseRepo->getLocalEntityTypes()
#2 /srv/mediawiki/php-master/extensions/Wikibase/repo/includes/Specials/SpecialEntitiesWithoutPageFactory.php(35): Wikibase\Repo\Specials\SpecialEntitiesWithoutPageFactory::newFromGlobalState()
#3 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(393): Wikibase\Repo\Specials\SpecialEntitiesWithoutPageFactory::newSpecialEntitiesWithoutLabel()
#4 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(426): MediaWiki\Special\SpecialPageFactory->getPage(string)
#5 /srv/mediawiki/php-master/includes/specials/SpecialSpecialpages.php(56): MediaWiki\Special\SpecialPageFactory->getUsablePages(User)
#6 /srv/mediawiki/php-master/includes/specials/SpecialSpecialpages.php(44): SpecialSpecialpages->getPageGroups()
#7 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(569): SpecialSpecialpages->execute(NULL)
#8 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(558): SpecialPage->run(NULL)
#9 /srv/mediawiki/php-master/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#10 /srv/mediawiki/php-master/includes/MediaWiki.php(862): MediaWiki->performRequest()
#11 /srv/mediawiki/php-master/includes/MediaWiki.php(517): MediaWiki->main()
#12 /srv/mediawiki/php-master/index.php(42): MediaWiki->run()
#13 /srv/mediawiki/w/index.php(3): include(string)
#14 {main}

So if no repo is configured we hit the exceptional case.
The local repo definition should probably always exist...

gerritbot subscribed.Oct 30 2018, 12:37 PM

Change 470582 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Define RepositoryDefinitions namespace array even with 0 namespaces

https://gerrit.wikimedia.org/r/470582

gerritbot added a project: Patch-For-Review.Oct 30 2018, 12:37 PM
Addshore moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Oct 30 2018, 12:41 PM
gerritbot added a comment.Oct 30 2018, 12:42 PM

Change 470584 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Test for RepositoryDefinitions no entity handeling

https://gerrit.wikimedia.org/r/470584

Jdforrester-WMF edited parent tasks, added: T159708: Deploy WikibaseMediaInfo extension to production; removed: T180981: Deploy WikibaseMediaInfo extension to beta.Oct 30 2018, 3:39 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Oct 31 2018, 10:42 AM
Addshore claimed this task.Oct 31 2018, 11:05 AM
Restricted Application added a project: User-Addshore. · View Herald TranscriptOct 31 2018, 11:05 AM
Addshore set the point value for this task to 3.Oct 31 2018, 11:05 AM
gerritbot added a comment.Oct 31 2018, 11:59 PM

Change 470582 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Define RepositoryDefinitions namespace array even with 0 namespaces

https://gerrit.wikimedia.org/r/470582

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 1 2018, 12:00 AM
Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 1 2018, 10:22 AM
gerritbot added a comment.Nov 5 2018, 5:43 PM

Change 470584 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Test for RepositoryDefinitions no entity handeling

https://gerrit.wikimedia.org/r/470584

Addshore closed this task as Resolved.Nov 6 2018, 12:19 PM
Addshore triaged this task as Medium priority.
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL