Change itself should be simple, but 5 because there will likely be a lot of if/then conditions. Some uncertaintly about log lines (do they become unsuppressed?)

And we should write tests

On Test Wiki this is limited to only indefinite blocks, but it may be different across our various wikis.

The "hide user" checkbox is hidden from the UI if the expiration is not set to "indefinite" - do we need to worry about this? (That said, I can't imagine a use case for a non-indefinite suppression.)

In T210002#4873927, @Tchanders wrote:

On Test Wiki this is limited to only indefinite blocks, but it may be different across our various wikis.

The "hide user" checkbox is hidden from the UI if the expiration is not set to "indefinite" - do we need to worry about this? (That said, I can't imagine a use case for a non-indefinite suppression.)

This functionality should continue to exist. Maybe we can piggy-back on this logic?

It is intentional that only indef blocks allow for user names to be suppressed. We are using it only to suppress indef blocked troll accounts that meet a strict criteria for suppression. This is not needed for partial blocks even if time period was indef.

There are other workflows used to rename accounts that are used for other situations.

See also: T133036: Field "hideuser" on Special:Block should be hidden when time field not indefinite

• If the person changes a suppressed sitewide block to a partial block, it should become unsuppressed.

In order to do this, we need to uncheck the "hide user" checkbox whenever it is hidden. Otherwise, on reblocking the suppressed user with a partial block, the form will have the "hide user" checkbox checked and hidden, making it impossible to uncheck (without playing around with the parameters of the block).

Change 484526 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Do not allow user suppression in a partial block

https://gerrit.wikimedia.org/r/484526

I would think this is should be 'Editing' checkbox AND 'Sitewide' radio button... not 'or'.

See also: T213972: Consider updating the Oversight/Suppress UX on Special:Block

Just wondering: why not force sitewide/indef blocking when you click 'hideuser' option? That would be less click <_<

In T210002#4889247, @revi wrote:

Just wondering: why not force sitewide/indef blocking when you click 'hideuser' option? That would be less click <_<

That's the change we're proposing in T213972: Consider updating the Oversight/Suppress UX on Special:Block

This current task (T210002) is just to fix oversighting for partial blocks.

@TBolliger Can we decline this task in favor of T213972 ? I can't imagine it would be more than 5 points.

@dbarratt @TBolliger There's already a patch up for this - it might be better to merge that fix to ensure no partial-block suppressions accidentally get made, and then get to work on T213972.

The current patch also makes sure partial-block suppressions can't be made over the API, which would need to stay.

In T210002#4890002, @Tchanders wrote:

@dbarratt @TBolliger There's already a patch up for this - it might be better to merge that fix to ensure no partial-block suppressions accidentally get made, and then get to work on T213972.

The current patch also makes sure partial-block suppressions can't be made over the API, which would need to stay.

👍

Change 484526 merged by jenkins-bot:
[mediawiki/core@master] Disallow user suppression in a partial block

https://gerrit.wikimedia.org/r/484526