Search request failures when offset+limit is out of bounds (cirrussearch-backend-error)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Vort
	Jan 14 2019, 5:55 PM

Description

One of my queries (which should be run from bot account) is failing with error:

<?xml version="1.0"?>
<api servedby="mw1347">
  <error code="cirrussearch-backend-error" info="We could not complete your search due to a temporary problem. Please try again later." xml:space="preserve">See https://ru.wikipedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &amp;lt;https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce&amp;gt; for notice of API deprecations and breaking changes.</error>
</api>

I don't know if its reproducing is stable, but, please, try to fix it.

Details

	Subject	Repo	Branch	Lines +/-
	Fix regression on out of bounds offset+limit	mediawiki/extensions/CirrusSearch	master	+64 -8

Customize query in gerrit

Related Objects

Mentioned Here: T177270: API:Search maxes out at 10000

Event Timeline

Vort created this task.Jan 14 2019, 5:55 PM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptJan 14 2019, 5:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

You're probably reaching the max value for offset+limit. A clear error message should be presented but it's not.
Please see T177270 for more details on the limations of offset+limit.

I thought that results are limited, not requests.

dcausse renamed this task from API request failure (cirrussearch-backend-error) to Search request failures when offset+limit is out bounds (cirrussearch-backend-error) .Jan 15 2019, 8:02 AM

dcausse triaged this task as High priority.

dcausse moved this task from needs triage to Current work on the Discovery-Search board.

dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.

This is a regression, previously the requests asking out of bounds offset/limit were automatically corrected and did not produce an error, the API request you pasted is one of them.
Sorry for the inconvenience.

dcausse renamed this task from Search request failures when offset+limit is out bounds (cirrussearch-backend-error) to Search request failures when offset+limit is out of bounds (cirrussearch-backend-error) .Jan 15 2019, 8:05 AM

dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Jan 15 2019, 8:08 AM

Change 484361 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Fix regression on out of bounds offset+limit

https://gerrit.wikimedia.org/r/484361

gerritbot added a project: Patch-For-Review.Jan 15 2019, 8:08 AM

Change 484361 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Fix regression on out of bounds offset+limit

https://gerrit.wikimedia.org/r/484361

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 15 2019, 6:01 PM

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jan 15 2019, 6:24 PM

debt closed this task as Resolved.Jan 18 2019, 7:17 PM