Page MenuHomePhabricator
Create Task
Maniphest T217626

[subtask] Move headings specific styles to 'headings.less'
Closed, ResolvedPublic
Actions

Description

Instead of reset apply heading specific styles in 'headings.less'.

Details

SubjectRepoBranchLines +/-
Move headings specific reset to 'headings.less'mediawiki/skins/MinervaNeuereset-cleanup+13 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Mar 5 2019, 6:56 AM
gerritbot subscribed.Mar 5 2019, 7:02 AM

Change 494412 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Move headings specific reset to 'headings.less'

https://gerrit.wikimedia.org/r/494412

gerritbot added a project: Patch-For-Review.Mar 5 2019, 7:02 AM
Jdlrobson added a comment.Mar 5 2019, 9:50 PM

PS1 https://gerrit.wikimedia.org/r/494412

Before:

Screen Shot 2019-03-05 at 1.48.21 PM.png (366×686 px, 106 KB)

After:

Screen Shot 2019-03-05 at 1.47.27 PM.png (195×720 px, 30 KB)

Intentional?

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Mar 5 2019, 9:50 PM
Volker_E added a comment.Mar 5 2019, 11:36 PM

@Jdlrobson No, unintended. font: inherit was carrying font-weight: normal through. Will amend the patch.

ovasileva triaged this task as Medium priority.Mar 6 2019, 9:25 AM
Jdlrobson renamed this task from Move headings specific styles to 'headings.less' to [subtask] Move headings specific styles to 'headings.less'.Mar 8 2019, 12:26 AM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
Jdlrobson mentioned this in T205341: Replace reset.css rules with ResourceLoaderSkinModule `normalize` feature.Mar 8 2019, 12:36 AM
gerritbot added a comment.Apr 4 2019, 4:58 PM

Change 494412 had a related patch set uploaded (by Jdlrobson; owner: VolkerE):
[mediawiki/skins/MinervaNeue@reset-cleanup] Move headings specific reset to 'headings.less'

https://gerrit.wikimedia.org/r/494412

gerritbot added a comment.Apr 4 2019, 11:56 PM

Change 494412 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@reset-cleanup] Move headings specific reset to 'headings.less'

https://gerrit.wikimedia.org/r/494412

Jdlrobson removed a project: Patch-For-Review.May 7 2019, 6:45 PM
Jdlrobson moved this task from Backlog to Code organisation on the MinervaNeue board.Jan 17 2020, 11:22 PM
Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.Sep 15 2021, 5:16 PM
Jdlrobson removed a project: Web-Team-Backlog (Tracking).Oct 20 2021, 3:28 PM
Jdlrobson closed this task as Resolved.Feb 21 2024, 4:47 PM
Jdlrobson claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL