Page MenuHomePhabricator

Evaluate 'notice' type messages and decide on deprecating it in favor of 'warning'
Open, LowPublic

Description

Resulting out of conversation on patch for T145674 we've tried to pinpoint user experience usefulness on 'notice' type inline form messages.
While 'error', 'warning' and 'success' messages all have distinct use cases, there doesn't seem to be clear such use case for 'notices'

As part of current demos, v0.30.4:

image.png (760×1 px, 94 KB)

The demo already shows, mostly those messages don't need to be dynamic, rather labels or inlined help texts.

Event Timeline

@Jdforrester-WMF shared on IRC:

They were used in VE transclusion dialog (that's what I created it for).
And in the meta dialog, maybe?

I created this for non-fatal interactive warnings to users about issues that weren't so serious the user had to drop everything and 'fix' their input, but needed to consider.

Most obvious example is user name creation – "You entered 'foo ! ', but for technical reasons it will be 'Foo_!'."
This is distinct from a fatal error warning, like "You entered 'foo@', which is not allowed." and a success message like "This user name is available".

Maybe its no longer being used?

I think we decided to call these non-fatal messages "warnings", and the fatal failures "errors". The way we previously used "notices" is the same way we want to use "warnings".

'notices' https://codesearch.wmflabs.org/search/?q=notices%3A&i=nope&files=&repos= appears to be used in

  • ve.init.mw.ArticleTarget.js 1x and
  • ve.init.mw.DesktopArticleTarget.test.js 1x (neglible).

Nowhere else…

'notices' https://codesearch.wmflabs.org/search/?q=notices%3A&i=nope&files=&repos= appears to be used in

  • ve.init.mw.ArticleTarget.js 1x and
  • ve.init.mw.DesktopArticleTarget.test.js 1x (neglible).

Nowhere else…

The VisualEditor results are a false positive as well (they refer to editnotices).

However, notice messages are used via setNotices() in UploadWizard: https://codesearch.wmflabs.org/search/?q=setNotices&i=nope&files=&repos= (the other results are false positives)

And they are used in PHP code via 'notices' => in MediaWiki's HTMLForm: https://codesearch.wmflabs.org/search/?q=%27notices%27&i=nope&files=&repos= (again, the rest are false positives)

(Tracking down which HTMLForm forms actually make use of this is another thing, might not really be possible, unless you wanted to add some logging there…)