Structured fields don't show a notice about IP logging for users who aren't logged in
Closed, ResolvedPublicFeature
Actions

Assigned To

Authored By

	• Ramsey-WMF
	Mar 19 2019, 1:09 AM

Description

User story: N/A

We have this:

We show users a notification about CC0 licensing and the terms of use when they first edit/add structured data, but we don't explicitly say anything about IP logging, like we do with wikitext.

Wikidata accomplishes this with a small alert popover:

Screenshot 2019-03-20 16.12.34.png (714×1 px, 116 KB)

We want this:

A way to notify users about IP logging, positioned in the top center of the screen, per the visual styling guidance provided on M241

Screenshots (if possible):

Background color: #FEF6E7
Icon color: #FFCC33
OOUI icon label: "alert"
Note: link should _underline_ upon hover

Acceptance Criteria:

Logged out users always see some sort of warning/notification that their IP will be logged for anonymous edits.
IP address url: https://en.wikipedia.org/wiki/IP_address
Log in url: https://commons.wikimedia.org/w/index.php?title=Special:UserLogin
Create an account url: https://commons.wikimedia.org/w/index.php?title=Special:CreateAccount

QA Results

AC	Status	Details
1	✅	T218628#5071464
2	✅	T218628#5071464
3	✅	T218628#5071464
4	❌	T218628#5071464

Details

Subject	Repo	Branch	Lines +/-
Follow-up I3c037a8bd, Iaeaae3ded: Parse `anoneditwarning` server-side	mediawiki/extensions/WikibaseMediaInfo	master	+16 -4
Follow-up I3c037a8bd: Parse `anoneditwarning`; it contains rich content	mediawiki/extensions/WikibaseMediaInfo	master	+2 -2
Warn anonymous editing users that their IP will be logged	mediawiki/extensions/WikibaseMediaInfo	master	+20 -1

Customize query in gerrit

Related Objects

Mentioned In: rEWBI2ad974ecb3e6: Follow-up I3c037a8bd, Iaeaae3ded: Parse `anoneditwarning` server-side
rEWBI294cceae200d: Follow-up I3c037a8bd, Iaeaae3ded: Parse `anoneditwarning` server-side
rEWBId8a95fb25b55: Follow-up I3c037a8bd: Parse `anoneditwarning`; it contains rich content
rEWBIc253587dda3d: Warn anonymous editing users that their IP will be logged
rEWBIa4235317a8db: Warn anonymous editing users that their IP will be logged
rEWBI4b7b89bbde87: Warn anonymous editing users that their IP will be logged
Mentioned Here: M241: WikimediaUI: Messages (Errors, Warnings, Successes, Notices)

Event Timeline

• Ramsey-WMF created this task.Mar 19 2019, 1:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2019, 1:09 AM

This feature may not be necessary, but I wanted to explicitly address it before we go too much further. Thoughts, @Abit or @Keegan ? Should we get legal involved too? (fodder for our Wednesday meeting, Amanda?)

Should we get legal involved too? (fodder for our Wednesday meeting, Amanda?)

Totes, I've added it to the Wed agenda.

Background info: we did check the way it's currently done on Wikidata with legal back then. So if you want to do the same it will probably be fine. if you'd like to do it differently then it might be a good idea o get input again.

That's a huge problem IMO. Since the product is already in production, it would be nice if it could be solved very quickly. Thanks.

• PDrouin-WMF updated the task description. (Show Details)Mar 25 2019, 3:15 PM

• PDrouin-WMF updated the task description. (Show Details)

• PDrouin-WMF updated the task description. (Show Details)Mar 25 2019, 4:13 PM

• PDrouin-WMF updated the task description. (Show Details)

Cparle added a project: Structured-Data-Team-Current-Work.Mar 25 2019, 4:18 PM

Cparle claimed this task.Mar 25 2019, 4:24 PM

• PDrouin-WMF updated the task description. (Show Details)Mar 25 2019, 4:29 PM

Cparle removed Cparle as the assignee of this task.Mar 25 2019, 4:50 PM

Cparle subscribed.

• Ramsey-WMF assigned this task to egardner.Mar 25 2019, 4:53 PM

• Ramsey-WMF triaged this task as High priority.

• Ramsey-WMF moved this task from To Do to Doing on the Structured-Data-Team-Current-Work board.

I'm going to attempt to address this ticket using the generic mw.notification system (which seems to be what Wikibase uses anyway), so that we don't need to re-invent the wheel. I'll see if I can arrive at the desired behavior based on the options provided by this feature.

This ended up being pretty straightforward, since we can rely on existing functionality. Here's a screenshot:

Screen Shot 2019-03-25 at 1.11.30 PM.png (1×2 px, 2 MB)

There are no custom styles or other UI elements, just the default mw.notification behavior when you set the type option to warn. This is the same way Wikibase handles things.

Change 498986 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/WikibaseMediaInfo@master] Warn anonymous editing users that their IP will be logged

https://gerrit.wikimedia.org/r/498986

gerritbot added a project: Patch-For-Review.Mar 25 2019, 8:19 PM

egardner moved this task from Doing to Code Review on the Structured-Data-Team-Current-Work board.Mar 25 2019, 8:21 PM

egardner mentioned this in rEWBI4b7b89bbde87: Warn anonymous editing users that their IP will be logged.Mar 25 2019, 8:22 PM

egardner mentioned this in rEWBIa4235317a8db: Warn anonymous editing users that their IP will be logged.Mar 25 2019, 10:50 PM

• Ramsey-WMF moved this task from Needs Design to Next up on the Multimedia board.Mar 26 2019, 4:21 PM

Jdforrester-WMF mentioned this in rEWBIc253587dda3d: Warn anonymous editing users that their IP will be logged.Mar 26 2019, 6:27 PM

Change 498986 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Warn anonymous editing users that their IP will be logged

https://gerrit.wikimedia.org/r/498986

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 26 2019, 10:01 PM

Change 499342 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Follow-up I3c037a8bd: Parse anoneditwarning; it contains rich content

https://gerrit.wikimedia.org/r/499342

Jdforrester-WMF mentioned this in rEWBId8a95fb25b55: Follow-up I3c037a8bd: Parse `anoneditwarning`; it contains rich content.Mar 26 2019, 10:20 PM

Change 499342 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Follow-up I3c037a8bd: Parse anoneditwarning; it contains rich content

https://gerrit.wikimedia.org/r/499342

Jdforrester-WMF merged a task: T219422: Something wrong with the 'you are not logged in' warning on beta.Mar 27 2019, 5:06 PM

Jdforrester-WMF subscribed.

egardner moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.Mar 27 2019, 5:07 PM

No, still doing.

Change 499556 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Follow-up I3c037a8bd, Iaeaae3ded: Parse anoneditwarning server-side

https://gerrit.wikimedia.org/r/499556

Jdforrester-WMF mentioned this in rEWBI294cceae200d: Follow-up I3c037a8bd, Iaeaae3ded: Parse `anoneditwarning` server-side.Mar 27 2019, 6:12 PM

Jdforrester-WMF mentioned this in rEWBI2ad974ecb3e6: Follow-up I3c037a8bd, Iaeaae3ded: Parse `anoneditwarning` server-side.Mar 28 2019, 4:12 PM

Change 499556 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Follow-up I3c037a8bd, Iaeaae3ded: Parse anoneditwarning server-side

https://gerrit.wikimedia.org/r/499556

Now for QA.

Example screenshot from Beta Cluster including the deep magic template/Lua version used on production:

Test Result

Status: ❓ Please review
OS: macOS Mojave
Browser: Chrome

Test Artifact(s):

✅ AC1: Logged out users always see some sort of warning/notification that their IP will be logged for anonymous edits.

Screen Shot 2019-03-29 at 7.16.53 PM.png (2×2 px, 893 KB)

✅ AC2: IP address url: https://en.wikipedia.org/wiki/IP_address

Screen Shot 2019-03-29 at 7.18.30 PM.png (2×2 px, 794 KB)

✅ AC3: Log in url: https://commons.wikimedia.org/w/index.php?title=Special:UserLogin

Screen Shot 2019-03-29 at 7.22.33 PM.png (2×2 px, 838 KB)

❌ AC4: Create an account url: https://commons.wikimedia.org/w/index.php?title=Special:CreateAccount
There was no link in the popover for creating an account.

Edtadros updated the task description. (Show Details)Mar 30 2019, 2:35 AM

@Jdforrester-WMF hey James, the screenshot you posted has different text than the one from Wikidata included in the description. How/why is it different?

In T218628#5075311, @PDrouin-WMF wrote:

@Jdforrester-WMF hey James, the screenshot you posted has different text than the one from Wikidata included in the description. How/why is it different?

It's using the proper text from MediaWiki, which is what Commons uses and the community has translated, not Wikidata's localised version.

It is my understanding that the text is always going to depend on the way the Wiki in question has been configured. I think this is the correct behavior, even if some sites have been configured to display text different than what we are expecting.

Given this fact, the expected behavior is working correctly on both Beta and Test commons, so I'm moving this to "verify on production".

egardner moved this task from Needs QA to Verify on Production on the Structured-Data-Team-Current-Work board.Apr 16 2019, 9:46 PM

• PDrouin-WMF moved this task from Backlog 📚 to Doing 📝 on the SDC Design board.Apr 17 2019, 2:28 PM

• PDrouin-WMF moved this task from Doing 📝 to Done/Handed off 📮 on the SDC Design board.

Ok on test-commons

The engineering part of this works. We still need to update the text though, but that's a separate thing.

	F28514043: Screen Shot 2019-03-29 at 7.16.53 PM.png
	Mar 30 2019, 2:31 AM

	F28514056: Screen Shot 2019-03-29 at 7.18.30 PM.png
	Mar 30 2019, 2:31 AM

	F28514068: Screen Shot 2019-03-29 at 7.22.33 PM.png
	Mar 30 2019, 2:31 AM

	F28465310: Screen Shot 2019-03-25 at 1.11.30 PM.png
	Mar 25 2019, 8:13 PM

	F28464384: Screenshot 2019-03-20 16.12.34.png
	Mar 25 2019, 3:15 PM

	F28499863: image.png
	Mar 28 2019, 6:40 PM

Structured fields don't show a notice about IP logging for users who aren't logged inClosed, ResolvedPublicFeatureActions