Maniphest T220155

Implement Doctrine DBAL Driver Connection wrapper for MW db connection
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• alaa_wmde
	Apr 4 2019, 9:12 PM

Description

Motivation
When we want to use Doctrine DBAL, we do not want to create a direct connection to the database because then we will have to also deal with multiple environments and the load balancer on our own. So we thought we might reuse the connection that is created in MW core and pass it to Doctrine's DBAL connection.

In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/500837/5/lib/MediaWikiDoctrineDBALDriver.php, we experimented on how we can create a wrapper of MW db connection that implements Doctrine DBAL Driver Connection and be used with Doctrine DBAL Connection instance.

Now we want to implement the driver connections for the different databases supported by mw/wikibase properly as a separate library, which then we can use in Wikibase project wherever needed.

Details

	Subject	Repo	Branch	Lines +/-
	Allow getting db connection from Database	mediawiki/core	master	+7 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Addshore	T208425 [EPIC] Kill the wb_terms table
Resolved	ArielGlenn	T226167 audit public tables and make sure we dump them all
Resolved	Addshore	T219175 [Mega] - Migrate data from wb_terms to new schema
Resolved	Addshore	T219121 [Checkpoint 2] Refactor Write & Migration code for Properties
Declined	None	T219805 Investigate Doctrine DBAL usage possibility
Resolved	JeroenDeDauw	T220155 Implement Doctrine DBAL Driver Connection wrapper for MW db connection

Event Timeline

• alaa_wmde created this task.Apr 4 2019, 9:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 4 2019, 9:12 PM

• alaa_wmde updated the task description. (Show Details)Apr 4 2019, 9:16 PM

• alaa_wmde added a parent task: T219120: [Checkpoint 1] Create Schema, Migration plan and Doctrine DBAL connection .Apr 4 2019, 10:13 PM

Wikibase Client also uses the TermIndex stuff, so I'm afraid we can't just put this into Wikibase Repository. Some options:

1. Dump the stuff in WikibaseLib garbage bin
Pro: least initial work
Con: minor increase of tech debt, further away from killing WikibaseLib
Con: not usable without loading Wikibase

2. Create dedicated library
Pro: max separation and reusability
Con: need to create library and have MW tests in it

3. Put in wikibase/term-store
Pro: partially reusable
Pro: encapsulation: MediaWikiTermStore that wraps DoctrineTermStore taking Database in constructor
Con: need to setup MW tests in library
Con: part of the library depends on MW (the rest would still work without and be tested without MW loaded)

Thoughts?

JeroenDeDauw added a parent task: T219295: Create service for writing property terms.Apr 5 2019, 5:13 AM

After a bunch of consideration I moderately prefer "2. Create dedicated library". That approach does not clutter anything and it gives us a building block we can use in other projects, which I think is worth the small initial investment.

• alaa_wmde removed a parent task: T219295: Create service for writing property terms.Apr 5 2019, 8:00 AM

I'd go for 2 as well. Updated task description to reflect that ;)

• alaa_wmde mentioned this in T219805: Investigate Doctrine DBAL usage possibility.Apr 5 2019, 1:12 PM

• alaa_wmde renamed this task from Implement Doctrine DBAL Driver Connection wrapper for mw context to Implement Doctrine DBAL Driver Connection wrapper for MW db connection.Apr 5 2019, 1:18 PM

• alaa_wmde updated the task description. (Show Details)

JeroenDeDauw claimed this task.Apr 7 2019, 1:25 AM

Started at https://github.com/wmde/mediawiki-doctrine-connection

JeroenDeDauw moved this task from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.Apr 7 2019, 3:22 AM

Setting this up turned out to be easier than expected. The library has running tests on TravisCI and can transform Mysqli and SQLite (PDO) based MW Database objects.

Next steps:

Figure out if we need to support other database types (Which ones does Wikibase support?)
Improve access to the wrapped connections in MW core (currently done via Reflection)

Also: please review the code I wrote :)

Change 501119 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan):
[mediawiki/core@master] Allow getting db connection from Database

https://gerrit.wikimedia.org/r/501119

gerritbot added a project: Patch-For-Review.Apr 9 2019, 3:54 PM

JeroenDeDauw moved this task from In Progress to In Review on the Wikidata wb_terms Trailblazing board.Apr 10 2019, 11:55 AM

JeroenDeDauw moved this task from In Review to Done on the Wikidata wb_terms Trailblazing board.Apr 12 2019, 11:06 AM

JeroenDeDauw closed this task as Resolved.Apr 12 2019, 11:18 AM

• alaa_wmde edited parent tasks, added: T219805: Investigate Doctrine DBAL usage possibility; removed: T219120: [Checkpoint 1] Create Schema, Migration plan and Doctrine DBAL connection .Apr 23 2019, 2:26 PM

Change 501119 abandoned by Alaa Sarhan:
Allow getting db connection from Database

https://gerrit.wikimedia.org/r/501119